FlaskrTestCase

Complexity

Total Complexity

14

Size/Duplication

Total Lines	93
Duplicated Lines	0 %

Test Coverage

Coverage

100%

9 Methods

Rating	Name	Duplication	Size	Complexity
A	test_robotstxt()	0	2	2
A	test_del_rule()	0	12	1
A	setUp()	0	5	1
A	tearDown()	0	2	1
A	test_redirect_root()	0	4	1
A	test_plain_rule()	0	20	3
B	test_add_rule()	0	24	1
A	__create_rule()	0	12	2
A	__delete_rule()	0	3	2

from time import strftime, localtime

This module should have a docstring.

try:
    from urlparse import urlparse
except ImportError:  # python3
    from urllib.parse import urlparse

from spike import create_app
from spike.model import db
from spike.model.naxsi_rules import NaxsiRules
import unittest


class FlaskrTestCase(unittest.TestCase):

This class should have a docstring.

    def setUp(self):
        app = create_app()
        db.init_app(app)
        app.config['TESTING'] = True
        self.app = app.test_client()

    def tearDown(self):
        pass

    def __create_rule(self):
        """

        :return int: The id of the new rule
        """
        current_sid = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).first()
        current_sid = 1337 if current_sid is None else current_sid.sid + 1

        db.session.add(NaxsiRules(u'POUET', 'str:test', u'BODY', u'$SQL:8', current_sid, u'web_server.rules',

This line is too long as per the coding-style (109/90).

                                  u'f hqewifueiwf hueiwhf uiewh fiewh fhw', '1', True, 1457101045))

This line is too long as per the coding-style (99/90).

        self.sid_to_delete = current_sid

The attribute sid_to_delete was defined outside __init__.

        return current_sid

    def __delete_rule(self, sid=None):

This method should have a docstring.

        sid = self.sid_to_delete if sid is None else sid
        db.session.delete(NaxsiRules.query.filter(sid == NaxsiRules.sid).first())

    def test_robotstxt(self):

This method should have a docstring.

        assert self.app.get('/robots.txt').data == 'User-agent: *\n Disallow: /'

    def test_redirect_root(self):

This method should have a docstring.

        rv = self.app.get('/', follow_redirects=False)

The name rv does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

        self.assertEqual(rv.status_code, 302)
        self.assertEqual(urlparse(rv.location).path, '/rules')

    def test_add_rule(self):

This method should have a docstring.

        data = {
            'msg': 'this is a test message',
            'detection': 'DETECTION',
            'mz': 'BODY',
            'custom_mz_val': '',
            'negative': 'checked',
            'score_$SQL': 8,
            'score': '$SQL',
            'rmks': 'this is a test remark',
            'ruleset': 'scanner.rules'
        }
        rv = self.app.post('/rules/new', data=data, follow_redirects=True)

The name rv does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

        _rule = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).first()

        self.assertIn(('<li> - OK: created %d : %s</li>' % (_rule.sid, _rule.msg)), rv.data)

This line is too long as per the coding-style (92/90).

        self.assertEqual(_rule.msg, data['msg'])
        self.assertEqual(_rule.detection, 'str:' + data['detection'])
        self.assertEqual(_rule.mz, data['mz'])
        self.assertEqual(_rule.score, data['score'] + ':' + str(data['score_$SQL']))
        self.assertEqual(_rule.rmks, data['rmks'])
        self.assertEqual(_rule.ruleset, data['ruleset'])

        self.__delete_rule(_rule.sid)

    def test_del_rule(self):

This method should have a docstring.

        old_sid = self.__create_rule()

        db.session.add(NaxsiRules(u'POUET', 'str:test', u'BODY', u'$SQL:8', old_sid + 1, u'web_server.rules',

This line is too long as per the coding-style (109/90).

                                  u'f hqewifueiwf hueiwhf uiewh fiewh fhw', '1', True, 1457101045))

This line is too long as per the coding-style (99/90).

        rv = self.app.get('/rules/del/%d' % (old_sid + 1))

The name rv does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

        self.assertEqual(rv.status_code, 302)

        _rule = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).first()
        self.assertEqual(_rule.sid, old_sid)

        self.__delete_rule()

    def test_plain_rule(self):

This method should have a docstring.

        self.__create_rule()
        _rule = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).first()
        rv = self.app.get('/rules/plain/%d' % _rule.sid)

The name rv does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

        self.assertEqual(rv.status_code, 200)
        rdate = strftime("%F - %H:%M", localtime(float(str(_rule.timestamp))))
        rmks = "# ".join(_rule.rmks.strip().split("\n"))
        detect = _rule.detection.lower() if _rule.detection.startswith("str:") else _rule.detection

This line is too long as per the coding-style (99/90).

        negate = 'negative' if _rule.negative == 1 else ''
        expected = """
#
# sid: %s | date: %s
#
# %s
#
MainRule %s "%s" "msg:%s" "mz:%s" "s:%s" id:%s ;

""" % (_rule.sid, rdate, rmks, negate, detect, _rule.msg, _rule.mz, _rule.score, _rule.sid)

This line is too long as per the coding-style (91/90).

        self.assertEqual(expected, rv.data)
        self.__delete_rule()


if __name__ == '__main__':
    unittest.main()