check_or_get_latest_sid() - Code Metrics - Inspection of "Rework a bit the templates" - nbs-system/spike - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 63da58...9fdcd8 )

by -

created 2016-03-04 10:00 UTC

check_or_get_latest_sid() B

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Metric	Value
cc	5
dl	0
loc	22
rs	8.3411

from flask.ext.sqlalchemy import SQLAlchemy

db = SQLAlchemy()

from naxsi_rules import NaxsiRules, NaxsiRuleSets
from settings import Settings


def check_constraint(ctype, value):
    if ctype == "settings":
        cres = Settings.query.filter(Settings.name == value).first()
    elif ctype == "ruleset":
        cres = NaxsiRuleSets.query.filter(NaxsiRuleSets.file == value).first()
    else:
        cres = 1

    if not cres:
        return 0
    return (cres)



def get_latest_sid():  # FIXME I'm ugly as fuck

    latest = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).first()
    if latest is None:
        latest = Settings.query.filter(Settings.name == "rules_offset").first()
        return int(latest.value) + 1
    return latest.sid + 1


1			from flask.ext.sqlalchemy import SQLAlchemy
2
3			db = SQLAlchemy()
4
5			from naxsi_rules import NaxsiRules, NaxsiRuleSets
6			from settings import Settings
7
8
9			def check_constraint(ctype, value):
10			if ctype == "settings":
11			cres = Settings.query.filter(Settings.name == value).first()
12			elif ctype == "ruleset":
13			cres = NaxsiRuleSets.query.filter(NaxsiRuleSets.file == value).first()
14			else:
15			cres = 1
16
17			if not cres:
18			return 0
19			return (cres)
			0 ignored issues – show Unused Code Coding Style introduced 2016-03-03 14:14 UTC by Report Bug Copy Issue Report There is an unnecessary parenthesis after `return`. Loading history...
20
21
22			def get_latest_sid(): # FIXME I'm ugly as fuck
			0 ignored issues – show Coding Style introduced 2016-03-03 14:14 UTC by Report Bug Copy Issue Report `TODO` and `FIXME` comments should generally be avoided. Loading history...
23			latest = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).first()
24			if latest is None:
25			latest = Settings.query.filter(Settings.name == "rules_offset").first()
26			return int(latest.value) + 1
27			return latest.sid + 1
28

nbs-system / spike

Push — master ( 63da58...9fdcd8 )

check_or_get_latest_sid() B

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like