del_sid() - Code Metrics - Inspection of "Bump coverage once again" - nbs-system/spike - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 00fa6c...ba46ed )

by -

created 2016-04-13 12:52 UTC

del_sid() A

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	15
Ratio	100 %

Code Coverage

Tests	9
CRAP Score	3.054

Metric	Value
cc	3
dl	15
loc	15
ccs	9
cts	11
cp	0.8182
crap	3.054
rs	9.4285

try:
    from urlparse import parse_qs
except ImportError:  # python3
    from urllib.parse import parse_qs
import logging
from time import time

from flask import Blueprint, render_template, request, redirect, flash, Response, url_for
from sqlalchemy.exc import SQLAlchemyError
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3

from spike.model import db
from spike.model.naxsi_whitelist import NaxsiWhitelist
from spike.model.naxsi_whitelistsets import NaxsiWhitelistSets
from spike.model import naxsi_mz

whitelists = Blueprint('whitelists', __name__)


@whitelists.route("/")
def index():
    _wlist = NaxsiWhitelist.query.order_by(NaxsiWhitelist.wid.desc()).all()

    if not _wlist:
        flash("No whitelist found, please create one", "success")
        return redirect(url_for('whitelists.new'))
    return render_template("whitelists/index.html", whitelists=_wlist)


@whitelists.route("/plain/<string:wid>", methods=["GET"])
def plain(wid):
    _wlist = NaxsiWhitelist.query.filter(NaxsiWhitelist.id == wid).first()

    if not _wlist:
        flash("No rules found, please create one", "error")
        return redirect(url_for('whitelists.index'))
    return Response(str(_wlist), mimetype='text/plain')


@whitelists.route("/view/<int:wid>", methods=["GET"])
def view(wid):
    _wlist = NaxsiWhitelist.query.filter(NaxsiWhitelist.id == wid).first()

    if _wlist is None:
        flash("The whitelist %d was not found." % wid, "error")
        return redirect(url_for('whitelists.index'))
    return render_template("whitelists/view.html", whitelist=_wlist)


@whitelists.route("/edit/<string:wid>", methods=["GET"])
def edit(wid):
    return redirect(url_for('whitelists.new'))


@whitelists.route("/del/<string:wid>", methods=["GET"])

def del_sid(wid):
    _wlist = NaxsiWhitelist.query.filter(NaxsiWhitelist.id == wid).first()

    if not _wlist:
        return redirect(url_for('whitelists.index'))

    db.session.delete(_wlist)

    try:
        db.session.commit()
        flash("Successfully deleted %s" % wid, "success")
    except SQLAlchemyError:
        flash("Error while trying to update %s" % wid, "error")

    return redirect(url_for('whitelists.index'))


@whitelists.route("/generate", methods=["GET", "POST"])
def generate():
    if request.method == "GET":
        return render_template("misc/whitelist_generator.html")
    nxlogs = request.form.get('nxlogs', '')

    if not nxlogs:
        flash('Please input nxlogs')
        return render_template("misc/whitelist_generator.html")

    whitelist = list()
    for nxlog in nxlogs.split('\n'):
        if not nxlog:
            continue
        start = nxlog.find("ip=")
        if start < 0:
            flash('{} is an invalid extlog, string "ip=" not found.'.format(nxlog))
            return render_template("misc/whitelist_generator.html", nxlogs=nxlogs)

        end = nxlog.find(", ")
        if end < 0:
            flash('{} is an invalid extlog, string "," not found.'.format(nxlog))
            return render_template("misc/whitelist_generator.html", nxlogs=nxlogs)

        # Flatten the dict, since parse_qs is a bit annoying
        nxdic = parse_qs(nxlog[start:end])
        for key, value in nxdic.items():
            nxdic[key] = value[0]

        cpt = 0
        while "id{}".format(cpt) in nxdic:

            _id = "id{}".format(cpt)
            _var_name = "var_name{}".format(cpt)
            _zone = "zone{}".format(cpt)
            if "var_name{}".format(cpt) in nxdic:
                whitelist.append('BasicRule wl:{} "mz:{}:{}"'.format(nxdic[_id], nxdic[_var_name], nxdic[_zone]))
            else:
                whitelist.append('BasicRule wl:{} "mz:{}"'.format(nxdic[_id], nxdic[_var_name]))
            cpt += 1
    return render_template("misc/whitelist_generator.html", whitelist='\n'.join(whitelist) + ';', nxlogs=nxlogs)


@whitelists.route('/new', methods=["GET", "POST"])
def new():
    if request.method == "GET":
        _whitelistesets = NaxsiWhitelistSets.query.all()

        return render_template('whitelists/new.html', matchzones=naxsi_mz, whitelistsets=_whitelistesets)

    logging.debug('Posted new request: %s', request.form)

    mz = "|".join(filter(len, request.form.getlist("mz") + request.form.getlist("custom_mz_val")))
    wid = request.form.get('wid', '')
    whitelistset = request.form.get("whitelistset", '')

    if not wid:
        flash('Please enter a wid', category='error')
        return render_template('whitelists/new.html')
    elif not whitelistset:
        flash('Please enter a whitelistset', category='error')
        return render_template('whitelists/new.html')

    wlist = NaxsiWhitelist(wid=wid, timestamp=int(time()),
                           whitelistset=whitelistset, mz=mz, active=1,
                           negative=request.form.get("negative", "") == 'checked')
    wlist.validate()

    if wlist.error:
        flash(",".join(wlist.error), 'error')
        return redirect(url_for('whitelists.new'))
    elif wlist.warnings:
        flash(",".join(wlist.warnings), 'warning')

    db.session.add(wlist)

    try:
        db.session.commit()
        flash('Created!')
    except SQLAlchemyError as e:

        flash("Error : %s" % e, "error")

    return render_template('whitelists/index.html')


1	1		try:
2	1		from urlparse import parse_qs
3			except ImportError: # python3
4			from urllib.parse import parse_qs
5	1		import logging
6	1		from time import time
7
8	1		from flask import Blueprint, render_template, request, redirect, flash, Response, url_for
9	1		from sqlalchemy.exc import SQLAlchemyError
			0 ignored issues – show Configuration introduced 2016-03-30 15:16 UTC by Report Bug Copy Issue Report The import `sqlalchemy.exc` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
10
11	1		from spike.model import db
12	1		from spike.model.naxsi_whitelist import NaxsiWhitelist
13	1		from spike.model.naxsi_whitelistsets import NaxsiWhitelistSets
14	1		from spike.model import naxsi_mz
15
16	1		whitelists = Blueprint('whitelists', __name__)
17
18
19	1		@whitelists.route("/")
20			def index():
21	1		_wlist = NaxsiWhitelist.query.order_by(NaxsiWhitelist.wid.desc()).all()
			0 ignored issues – show Bug introduced 2016-03-30 15:16 UTC by Report Bug Copy Issue Report The Class `NaxsiWhitelist` does not seem to have a member named `query`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
22	1		if not _wlist:
23			flash("No whitelist found, please create one", "success")
24			return redirect(url_for('whitelists.new'))
25	1		return render_template("whitelists/index.html", whitelists=_wlist)
26
27
28	1		@whitelists.route("/plain/<string:wid>", methods=["GET"])
29			def plain(wid):
30	1		_wlist = NaxsiWhitelist.query.filter(NaxsiWhitelist.id == wid).first()
			0 ignored issues – show Bug introduced 2016-03-31 14:38 UTC by Report Bug Copy Issue Report The Class `NaxsiWhitelist` does not seem to have a member named `query`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
31	1		if not _wlist:
32	1		flash("No rules found, please create one", "error")
33	1		return redirect(url_for('whitelists.index'))
34	1		return Response(str(_wlist), mimetype='text/plain')
35
36
37	1		@whitelists.route("/view/<int:wid>", methods=["GET"])
38			def view(wid):
39	1		_wlist = NaxsiWhitelist.query.filter(NaxsiWhitelist.id == wid).first()
			0 ignored issues – show Bug introduced 2016-04-13 12:54 UTC by Report Bug Copy Issue Report The Class `NaxsiWhitelist` does not seem to have a member named `query`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
40	1		if _wlist is None:
41	1		flash("The whitelist %d was not found." % wid, "error")
42	1		return redirect(url_for('whitelists.index'))
43			return render_template("whitelists/view.html", whitelist=_wlist)
44
45
46	1		@whitelists.route("/edit/<string:wid>", methods=["GET"])
47			def edit(wid):
48			return redirect(url_for('whitelists.new'))
49
50
51	1	View Code Duplication	@whitelists.route("/del/<string:wid>", methods=["GET"])
			0 ignored issues – show Duplication introduced 2016-04-13 12:54 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
52			def del_sid(wid):
53	1		_wlist = NaxsiWhitelist.query.filter(NaxsiWhitelist.id == wid).first()
			0 ignored issues – show Bug introduced 2016-04-13 12:54 UTC by Report Bug Copy Issue Report The Class `NaxsiWhitelist` does not seem to have a member named `query`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
54	1		if not _wlist:
55	1		return redirect(url_for('whitelists.index'))
56
57	1		db.session.delete(_wlist)
58
59	1		try:
60	1		db.session.commit()
61	1		flash("Successfully deleted %s" % wid, "success")
62			except SQLAlchemyError:
63			flash("Error while trying to update %s" % wid, "error")
64
65	1		return redirect(url_for('whitelists.index'))
66
67
68	1		@whitelists.route("/generate", methods=["GET", "POST"])
69			def generate():
70	1		if request.method == "GET":
71	1		return render_template("misc/whitelist_generator.html")
72	1		nxlogs = request.form.get('nxlogs', '')
73
74	1		if not nxlogs:
75	1		flash('Please input nxlogs')
76	1		return render_template("misc/whitelist_generator.html")
77
78	1		whitelist = list()
79	1		for nxlog in nxlogs.split('\n'):
80	1		if not nxlog:
81			continue
82	1		start = nxlog.find("ip=")
83	1		if start < 0:
84	1		flash('{} is an invalid extlog, string "ip=" not found.'.format(nxlog))
85	1		return render_template("misc/whitelist_generator.html", nxlogs=nxlogs)
86
87	1		end = nxlog.find(", ")
88	1		if end < 0:
89	1		flash('{} is an invalid extlog, string "," not found.'.format(nxlog))
90	1		return render_template("misc/whitelist_generator.html", nxlogs=nxlogs)
91
92			# Flatten the dict, since parse_qs is a bit annoying
93	1		nxdic = parse_qs(nxlog[start:end])
94	1		for key, value in nxdic.items():
95	1		nxdic[key] = value[0]
96
97	1		cpt = 0
98	1	View Code Duplication	while "id{}".format(cpt) in nxdic:
			0 ignored issues – show Duplication introduced 2016-04-12 14:52 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
99	1		_id = "id{}".format(cpt)
100	1		_var_name = "var_name{}".format(cpt)
101	1		_zone = "zone{}".format(cpt)
102	1		if "var_name{}".format(cpt) in nxdic:
103	1		whitelist.append('BasicRule wl:{} "mz:{}:{}"'.format(nxdic[_id], nxdic[_var_name], nxdic[_zone]))
104			else:
105			whitelist.append('BasicRule wl:{} "mz:{}"'.format(nxdic[_id], nxdic[_var_name]))
106	1		cpt += 1
107	1		return render_template("misc/whitelist_generator.html", whitelist='\n'.join(whitelist) + ';', nxlogs=nxlogs)
108
109
110	1		@whitelists.route('/new', methods=["GET", "POST"])
111			def new():
112	1		if request.method == "GET":
113	1		_whitelistesets = NaxsiWhitelistSets.query.all()
			0 ignored issues – show Bug introduced 2016-03-30 15:16 UTC by Report Bug Copy Issue Report The Class `NaxsiWhitelistSets` does not seem to have a member named `query`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
114	1		return render_template('whitelists/new.html', matchzones=naxsi_mz, whitelistsets=_whitelistesets)
115
116	1		logging.debug('Posted new request: %s', request.form)
117
118	1		mz = "\|".join(filter(len, request.form.getlist("mz") + request.form.getlist("custom_mz_val")))
119	1		wid = request.form.get('wid', '')
120	1		whitelistset = request.form.get("whitelistset", '')
121
122	1		if not wid:
123	1		flash('Please enter a wid', category='error')
124	1		return render_template('whitelists/new.html')
125	1		elif not whitelistset:
126	1		flash('Please enter a whitelistset', category='error')
127	1		return render_template('whitelists/new.html')
128
129	1		wlist = NaxsiWhitelist(wid=wid, timestamp=int(time()),
130			whitelistset=whitelistset, mz=mz, active=1,
131			negative=request.form.get("negative", "") == 'checked')
132	1		wlist.validate()
133
134	1		if wlist.error:
135	1		flash(",".join(wlist.error), 'error')
136	1		return redirect(url_for('whitelists.new'))
137	1		elif wlist.warnings:
138			flash(",".join(wlist.warnings), 'warning')
139
140	1		db.session.add(wlist)
141
142	1		try:
143	1		db.session.commit()
144	1		flash('Created!')
145			except SQLAlchemyError as e:
			0 ignored issues – show Coding Style Naming introduced 2016-03-30 15:16 UTC by Report Bug Copy Issue Report The name `e` does not conform to the variable naming conventions (`[a-z_][a-z0-9_]{1,30}$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
146			flash("Error : %s" % e, "error")
147
148			return render_template('whitelists/index.html')
149

nbs-system / spike

Push — master ( 00fa6c...ba46ed )

del_sid() A

Complexity

Size

Duplication

Code Coverage

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files