deact() - Code Metrics - Inspection of "Bump coverage once again" - nbs-system/spike - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 00fa6c...ba46ed )

by -

created 2016-04-13 12:52 UTC

deact() A

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	4.0466

Metric	Value
cc	4
dl	0
loc	18
rs	9.2
ccs	12
cts	14
cp	0.8571
crap	4.0466

import logging
import re
import string

from time import time
from flask import Blueprint, render_template, request, redirect, flash, Response, url_for
from sqlalchemy.exc import SQLAlchemyError
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3

from spike.model import db
from spike.model.naxsi_rules import NaxsiRules
from spike.model.naxsi_rulesets import NaxsiRuleSets
from spike.model import naxsi_mz, naxsi_score

rules = Blueprint('rules', __name__)


@rules.route("/")
def index():
    _rules = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).all()

    if not _rules:
        flash("no rules found, please create one", "success")
        return redirect(url_for("rules.new"))
    return render_template("rules/index.html", rules=_rules)


@rules.route("/plain/<int:sid>", methods=["GET"])
def plain(sid):
    _rule = NaxsiRules.query.filter(NaxsiRules.sid == sid).first()

    if not _rule:
        flash("no rules found, please create one", "error")
        return redirect(url_for("rules.new"))
    return Response(_rule.fullstr(), mimetype='text/plain')


@rules.route("/view/<int:sid>", methods=["GET"])
def view(sid):
    _rule = NaxsiRules.query.filter(NaxsiRules.sid == sid).first()

    if _rule is None:
        flash("no rules found, please create one", "error")
        return redirect(url_for("rules.index"))
    return render_template("rules/view.html", rule=_rule, rtext=_rule)


@rules.route("/search/", methods=["GET"])
def search():
    terms = request.args.get('s', '')

    if len(terms) < 2:
        return redirect(url_for("rules.index"))

    # No fancy injections
    whitelist = set(string.ascii_letters + string.digits + ':-_ ')
    filtered = ''.join(filter(whitelist.__contains__, terms))

    if filtered.isdigit():  # get rule by id
        _rules = db.session.query(NaxsiRules).filter(NaxsiRules.sid == int(filtered)).all()
    else:
        expression = '%' + filtered + '%'
        _rules = db.session.query(NaxsiRules).filter(
            db.or_(
                NaxsiRules.msg.like(expression),
                NaxsiRules.rmks.like(expression),
                NaxsiRules.detection.like(expression)
            )
        ).order_by(NaxsiRules.sid.desc()).all()
    return render_template("rules/index.html", rules=_rules, selection="Search: %s" % filtered, lsearch=terms)


@rules.route("/new", methods=["GET", "POST"])
def new():
    latest_sid = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).first()

    if latest_sid is None:
        sid = 200001
    else:
        sid = latest_sid.sid + 1

    if request.method == "GET":
        _rulesets = NaxsiRuleSets.query.all()

        return render_template("rules/new.html", mz=naxsi_mz, rulesets=_rulesets, score=naxsi_score, latestn=sid)

    # create new rule
    logging.debug('Posted new request: %s', request.form)
    mz = "|".join(filter(len, request.form.getlist("mz") + request.form.getlist("custom_mz_val")))

    score = request.form.get("score", "")
    score += ':'
    score += request.form.get("score_%s" % request.form.get("score", ""), "")

    nrule = NaxsiRules(request.form.get("msg", ""), request.form.get("detection", ""), mz, score, sid,
                       request.form.get("ruleset", ""), request.form.get("rmks", ""), "1",
                       request.form.get("negative", "") == 'checked', int(time()))

    nrule.validate()

    if nrule.error:
        for error in nrule.error:
            flash(error, category='error')
        return redirect(url_for("rules.new"))
    elif nrule.warnings:
        for warning in nrule.warnings:
            flash(warning, category='warnings')
    db.session.add(nrule)

    try:
        db.session.commit()
        flash("OK: created %s : %s" % (sid, request.form.get("msg", "")), "success")
        return redirect("/rules/edit/%s" % sid)
    except SQLAlchemyError:
        flash("Error while trying to create %s : %s" % (sid, request.form.get("msg", "")), "error")

    return render_template("rules/new.html")


@rules.route("/edit/<int:sid>", methods=["GET", "POST"])
def edit(sid):
    rinfo = NaxsiRules.query.filter(NaxsiRules.sid == sid).first()

    if not rinfo:
        return redirect(url_for("rules.index"))

    _rulesets = NaxsiRuleSets.query.all()

    rruleset = NaxsiRuleSets.query.filter(NaxsiRuleSets.name == rinfo.ruleset).first()

    custom_mz = ""
    mz_check = rinfo.mz
    if re.search(r"^\$[A-Z]+:(.*)\|[A-Z]+", mz_check):
        custom_mz = mz_check
        rinfo.mz = "custom"
    return render_template("rules/edit.html", mz=naxsi_mz, rulesets=_rulesets, score=naxsi_score, rules_info=rinfo,
                           rule_ruleset=rruleset, custom_mz=custom_mz)


@rules.route("/save/<int:sid>", methods=["POST"])
def save(sid):
    mz = "|".join(filter(len, request.form.getlist("mz") + request.form.getlist("custom_mz_val")))
    score = "{}:{}".format(request.form.get("score", ""), request.form.get("score_%s" % request.form.get("score", "")))
    nrule = NaxsiRules.query.filter(NaxsiRules.sid == sid).first()

    nrule.msg = request.form.get("msg", "")
    nrule.detection = request.form.get("detection", "")
    nrule.mz = mz
    nrule.score = score
    nrule.ruleset = request.form.get("ruleset", "")
    nrule.rmks = request.form.get("rmks", "")
    nrule.active = request.form.get("active", "")
    nrule.negative = request.form.get("negative", "") == 'checked'
    nrule.timestamp = int(time())
    nrule.validate()

    if nrule.error:
        flash(",".join(nrule.error), 'error')
        return redirect("/rules/edit/%s" % sid)
    elif nrule.warnings:
        flash(",".join(nrule.warnings), 'warning')

    db.session.add(nrule)
    try:
        db.session.commit()
    except SQLAlchemyError:
        flash("Error while trying to update %s : %s" % (sid, nrule.error), "error")
    return redirect("/rules/edit/%s" % sid)


@rules.route("/del/<int:sid>", methods=["GET"])

def del_sid(sid=''):
    nrule = NaxsiRules.query.filter(NaxsiRules.sid == sid).first()

    if not nrule:
        return redirect(url_for("rules.index"))

    db.session.delete(nrule)
    try:
        db.session.commit()
        flash("OK: deleted %s : %s" % (sid, nrule.msg), "success")
    except SQLAlchemyError:
        flash("Error while trying to update %s : %s" % (sid, nrule.msg), "error")

    return redirect(url_for("rules.index"))


@rules.route("/deact/<int:sid>", methods=["GET"])
def deact(sid):
    nrule = NaxsiRules.query.filter(NaxsiRules.sid == sid).first()

    if nrule is None:
        return redirect(url_for("rules.index"))

    fm = 'deactivate' if nrule.active else 'reactivate'
    nrule.active = not nrule.active

    db.session.add(nrule)
    try:
        db.session.commit()
        flash("OK: %s %sd : %s" % (fm, sid, nrule.msg), "success")
    except SQLAlchemyError:
        flash("Error while trying to %s %s : %s" % (fm, sid, nrule.msg), "error")

    _rulesets = NaxsiRuleSets.query.all()

    return render_template("rules/edit.html", mz=naxsi_mz, rulesets=_rulesets, score=naxsi_score, rules_info=nrule)


Push — master ( 00fa6c...ba46ed )

deact() A

Complexity

Size

Duplication

Code Coverage

1. Missing Dependencies

2. Missing init.py files

1	1		import logging
2	1		import re
3	1		import string
4
5	1		from time import time
6	1		from flask import Blueprint, render_template, request, redirect, flash, Response, url_for
7	1		from sqlalchemy.exc import SQLAlchemyError
			0 ignored issues – show Configuration introduced 2016-03-03 17:09 UTC by Report Bug Copy Issue Report The import `sqlalchemy.exc` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
8
9	1		from spike.model import db
10	1		from spike.model.naxsi_rules import NaxsiRules
11	1		from spike.model.naxsi_rulesets import NaxsiRuleSets
12	1		from spike.model import naxsi_mz, naxsi_score
13
14	1		rules = Blueprint('rules', __name__)
15
16
17	1		@rules.route("/")
18			def index():
19	1		_rules = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).all()
			0 ignored issues – show Bug introduced 2016-03-04 13:07 UTC by Report Bug Copy Issue Report The Class `NaxsiRules` does not seem to have a member named `query`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
20	1		if not _rules:
21			flash("no rules found, please create one", "success")
22			return redirect(url_for("rules.new"))
23	1		return render_template("rules/index.html", rules=_rules)
24
25
26	1		@rules.route("/plain/<int:sid>", methods=["GET"])
27			def plain(sid):
28	1		_rule = NaxsiRules.query.filter(NaxsiRules.sid == sid).first()
			0 ignored issues – show Bug introduced 2016-03-04 14:05 UTC by Report Bug Copy Issue Report The Class `NaxsiRules` does not seem to have a member named `query`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
29	1		if not _rule:
30			flash("no rules found, please create one", "error")
31			return redirect(url_for("rules.new"))
32	1		return Response(_rule.fullstr(), mimetype='text/plain')
33
34
35	1		@rules.route("/view/<int:sid>", methods=["GET"])
36			def view(sid):
37	1		_rule = NaxsiRules.query.filter(NaxsiRules.sid == sid).first()
			0 ignored issues – show Bug introduced 2016-03-04 13:07 UTC by Report Bug Copy Issue Report The Class `NaxsiRules` does not seem to have a member named `query`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
38	1		if _rule is None:
39	1		flash("no rules found, please create one", "error")
40	1		return redirect(url_for("rules.index"))
41	1		return render_template("rules/view.html", rule=_rule, rtext=_rule)
42
43
44	1		@rules.route("/search/", methods=["GET"])
45			def search():
46	1		terms = request.args.get('s', '')
47
48	1		if len(terms) < 2:
49	1		return redirect(url_for("rules.index"))
50
51			# No fancy injections
52	1		whitelist = set(string.ascii_letters + string.digits + ':-_ ')
53	1		filtered = ''.join(filter(whitelist.__contains__, terms))
54
55	1		if filtered.isdigit(): # get rule by id
56	1		_rules = db.session.query(NaxsiRules).filter(NaxsiRules.sid == int(filtered)).all()
57			else:
58	1		expression = '%' + filtered + '%'
59	1		_rules = db.session.query(NaxsiRules).filter(
60			db.or_(
61			NaxsiRules.msg.like(expression),
62			NaxsiRules.rmks.like(expression),
63			NaxsiRules.detection.like(expression)
64			)
65			).order_by(NaxsiRules.sid.desc()).all()
66	1		return render_template("rules/index.html", rules=_rules, selection="Search: %s" % filtered, lsearch=terms)
67
68
69	1		@rules.route("/new", methods=["GET", "POST"])
70			def new():
71	1		latest_sid = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).first()
			0 ignored issues – show Bug introduced 2016-03-04 13:07 UTC by Report Bug Copy Issue Report The Class `NaxsiRules` does not seem to have a member named `query`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
72	1		if latest_sid is None:
73			sid = 200001
74			else:
75	1		sid = latest_sid.sid + 1
76
77	1		if request.method == "GET":
78	1		_rulesets = NaxsiRuleSets.query.all()
			0 ignored issues – show Bug introduced 2016-03-04 13:07 UTC by Report Bug Copy Issue Report The Class `NaxsiRuleSets` does not seem to have a member named `query`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
79	1		return render_template("rules/new.html", mz=naxsi_mz, rulesets=_rulesets, score=naxsi_score, latestn=sid)
80
81			# create new rule
82	1		logging.debug('Posted new request: %s', request.form)
83	1		mz = "\|".join(filter(len, request.form.getlist("mz") + request.form.getlist("custom_mz_val")))
84
85	1		score = request.form.get("score", "")
86	1		score += ':'
87	1		score += request.form.get("score_%s" % request.form.get("score", ""), "")
88
89	1		nrule = NaxsiRules(request.form.get("msg", ""), request.form.get("detection", ""), mz, score, sid,
90			request.form.get("ruleset", ""), request.form.get("rmks", ""), "1",
91			request.form.get("negative", "") == 'checked', int(time()))
92
93	1		nrule.validate()
94
95	1		if nrule.error:
96	1		for error in nrule.error:
97	1		flash(error, category='error')
98	1		return redirect(url_for("rules.new"))
99	1		elif nrule.warnings:
100	1		for warning in nrule.warnings:
101	1		flash(warning, category='warnings')
102	1		db.session.add(nrule)
103
104	1		try:
105	1		db.session.commit()
106	1		flash("OK: created %s : %s" % (sid, request.form.get("msg", "")), "success")
107	1		return redirect("/rules/edit/%s" % sid)
108			except SQLAlchemyError:
109			flash("Error while trying to create %s : %s" % (sid, request.form.get("msg", "")), "error")
110
111			return render_template("rules/new.html")
112
113
114	1		@rules.route("/edit/<int:sid>", methods=["GET", "POST"])
115			def edit(sid):
116	1		rinfo = NaxsiRules.query.filter(NaxsiRules.sid == sid).first()
			0 ignored issues – show Bug introduced 2016-03-04 13:07 UTC by Report Bug Copy Issue Report The Class `NaxsiRules` does not seem to have a member named `query`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
117	1		if not rinfo:
118	1		return redirect(url_for("rules.index"))
119
120	1		_rulesets = NaxsiRuleSets.query.all()
			0 ignored issues – show Bug introduced 2016-03-04 13:07 UTC by Report Bug Copy Issue Report The Class `NaxsiRuleSets` does not seem to have a member named `query`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
121	1		rruleset = NaxsiRuleSets.query.filter(NaxsiRuleSets.name == rinfo.ruleset).first()
			0 ignored issues – show Bug introduced 2016-03-04 13:07 UTC by Report Bug Copy Issue Report The Class `NaxsiRuleSets` does not seem to have a member named `query`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
122	1		custom_mz = ""
123	1		mz_check = rinfo.mz
124	1		if re.search(r"^\$[A-Z]+:(.*)\\|[A-Z]+", mz_check):
125			custom_mz = mz_check
126			rinfo.mz = "custom"
127	1		return render_template("rules/edit.html", mz=naxsi_mz, rulesets=_rulesets, score=naxsi_score, rules_info=rinfo,
128			rule_ruleset=rruleset, custom_mz=custom_mz)
129
130
131	1		@rules.route("/save/<int:sid>", methods=["POST"])
132			def save(sid):
133	1		mz = "\|".join(filter(len, request.form.getlist("mz") + request.form.getlist("custom_mz_val")))
134	1		score = "{}:{}".format(request.form.get("score", ""), request.form.get("score_%s" % request.form.get("score", "")))
135	1		nrule = NaxsiRules.query.filter(NaxsiRules.sid == sid).first()
			0 ignored issues – show Bug introduced 2016-03-04 13:07 UTC by Report Bug Copy Issue Report The Class `NaxsiRules` does not seem to have a member named `query`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
136	1		nrule.msg = request.form.get("msg", "")
137	1		nrule.detection = request.form.get("detection", "")
138	1		nrule.mz = mz
139	1		nrule.score = score
140	1		nrule.ruleset = request.form.get("ruleset", "")
141	1		nrule.rmks = request.form.get("rmks", "")
142	1		nrule.active = request.form.get("active", "")
143	1		nrule.negative = request.form.get("negative", "") == 'checked'
144	1		nrule.timestamp = int(time())
145	1		nrule.validate()
146
147	1		if nrule.error:
148	1		flash(",".join(nrule.error), 'error')
149	1		return redirect("/rules/edit/%s" % sid)
150	1		elif nrule.warnings:
151	1		flash(",".join(nrule.warnings), 'warning')
152
153	1		db.session.add(nrule)
154	1		try:
155	1		db.session.commit()
156			except SQLAlchemyError:
157			flash("Error while trying to update %s : %s" % (sid, nrule.error), "error")
158	1		return redirect("/rules/edit/%s" % sid)
159
160
161	1	View Code Duplication	@rules.route("/del/<int:sid>", methods=["GET"])
			0 ignored issues – show Duplication introduced 2016-04-13 12:54 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
162	1		def del_sid(sid=''):
163	1		nrule = NaxsiRules.query.filter(NaxsiRules.sid == sid).first()
			0 ignored issues – show Bug introduced 2016-03-04 13:07 UTC by Report Bug Copy Issue Report The Class `NaxsiRules` does not seem to have a member named `query`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
164	1		if not nrule:
165			return redirect(url_for("rules.index"))
166
167	1		db.session.delete(nrule)
168	1		try:
169	1		db.session.commit()
170	1		flash("OK: deleted %s : %s" % (sid, nrule.msg), "success")
171			except SQLAlchemyError:
172			flash("Error while trying to update %s : %s" % (sid, nrule.msg), "error")
173
174	1		return redirect(url_for("rules.index"))
175
176
177	1		@rules.route("/deact/<int:sid>", methods=["GET"])
178			def deact(sid):
179	1		nrule = NaxsiRules.query.filter(NaxsiRules.sid == sid).first()
			0 ignored issues – show Bug introduced 2016-03-04 13:07 UTC by Report Bug Copy Issue Report The Class `NaxsiRules` does not seem to have a member named `query`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
180	1		if nrule is None:
181	1		return redirect(url_for("rules.index"))
182
183	1		fm = 'deactivate' if nrule.active else 'reactivate'
184	1		nrule.active = not nrule.active
185
186	1		db.session.add(nrule)
187	1		try:
188	1		db.session.commit()
189	1		flash("OK: %s %sd : %s" % (fm, sid, nrule.msg), "success")
190			except SQLAlchemyError:
191			flash("Error while trying to %s %s : %s" % (fm, sid, nrule.msg), "error")
192
193	1		_rulesets = NaxsiRuleSets.query.all()
			0 ignored issues – show Bug introduced 2016-03-04 13:07 UTC by Report Bug Copy Issue Report The Class `NaxsiRuleSets` does not seem to have a member named `query`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
194			return render_template("rules/edit.html", mz=naxsi_mz, rulesets=_rulesets, score=naxsi_score, rules_info=nrule)
195

nbs-system / spike

Push — master ( 00fa6c...ba46ed )

deact() A

Complexity

Size

Duplication

Code Coverage

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files