FlaskrTestCase

Complexity

Total Complexity

18

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

6 Methods

Rating	Name	Duplication	Size	Complexity
A	test_robotstxt()	0	2	2
A	test_del_rule()	0	11	3
A	setUp()	0	4	1
A	tearDown()	0	2	1
A	test_redirect_root()	0	4	3
C	test_add_rule()	0	21	8

try:

This module should have a docstring.

    from urlparse import urlparse
except ImportError:  # python3
    from urllib.parse import urlparse

import re

The import re seems to be unused.

from spike import create_app
from spike.model import db

Unused db imported from spike.model

from spike.model.naxsi_rules import ValueTemplates, NaxsiRules, NaxsiRuleSets

Unused ValueTemplates imported from spike.model.naxsi_rules

Unused NaxsiRuleSets imported from spike.model.naxsi_rules

import unittest


class FlaskrTestCase(unittest.TestCase):

This class should have a docstring.

    def setUp(self):
        app = create_app()
        app.config['TESTING'] = True
        self.app = app.test_client()

    def tearDown(self):
        pass

    def test_robotstxt(self):

This method should have a docstring.

        assert self.app.get('/robots.txt').data == 'User-agent: *\n Disallow: /'

    def test_redirect_root(self):

This method should have a docstring.

        rv = self.app.get('/', follow_redirects=False)

The name rv does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

        assert rv.status_code == 302
        assert urlparse(rv.location).path == '/rules'

    def test_add_rule(self):

This method should have a docstring.

        data = {
            'msg': 'this is a test message',
            'detection': 'DETECTION',
            'mz': 'BODY',
            'custom_mz_val': '',
            'negative': 'checked',
            'score_$SQL': 8,
            'score': '$SQL',
            'rmks': 'this is a test remark',
            'ruleset': 'scanner.rules'
        }
        rv = self.app.post('/rules/new', data=data, follow_redirects=True)

The name rv does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

        rule = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).first()

The Class NaxsiRules does not seem to have a member named query.

        assert ('<li> - OK: created %d : %s</li>' % (rule.sid, rule.msg)) in rv.data

There is an unnecessary parenthesis after assert.

        assert rule.msg == data['msg']
        assert rule.detection == 'str:' + data['detection']
        assert rule.mz == data['mz']
        assert rule.score == data['score'] + ':' + str(data['score_$SQL'])
        assert rule.rmks == data['rmks']
        assert rule.ruleset == data['ruleset']

    def test_del_rule(self):

This method should have a docstring.

        current_sid = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).first().sid

The Class NaxsiRules does not seem to have a member named query.

        self.test_add_rule()

        sid = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).first().sid

The Class NaxsiRules does not seem to have a member named query.

        rv = self.app.get('/rules/del/%d' % sid)

The name rv does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

        assert rv.status_code == 302

        rule = NaxsiRules.query.order_by(NaxsiRules.sid.desc()).first()

The Class NaxsiRules does not seem to have a member named query.

        assert rule.sid == current_sid



if __name__ == '__main__':
    unittest.main()

Final newline missing