execute_sql()

Complexity

Conditions

8

Size

Total Lines

29

Duplication

Lines	0
Ratio	0 %

1 Method

Rating	Name	Duplication	Size	Complexity
A	mz_new()	0	6	1

import os

This module should have a docstring.

import logging

from flask import current_app, Blueprint, render_template, request, redirect, flash

The import flask could not be resolved.

Unused current_app imported from flask

from spike.model import Settings, ValueTemplates, db

settings = Blueprint('settings', __name__, url_prefix='/settings')

The name settings does not conform to the constant naming conventions ((([A-Z_][A-Z0-9_]*)|(__.*__))$).

@settings.route("/")
def index():

This function should have a docstring.

    _settings = Settings.query.order_by(Settings.name).all()
    if not _settings:
        return redirect("/rules")
    return render_template("settings/index.html", settings=_settings)


@settings.route("/mz")
def mz_index():

This function should have a docstring.

    mz = ValueTemplates.query.filter(ValueTemplates.name == "naxsi_mz").order_by(ValueTemplates.value).all()

This line is too long as per the coding-style (108/90).

The name mz does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

    if not mz:
        return redirect("/settings")
    return render_template("settings/mz.html", mz=mz)


@settings.route("/mz/del", methods=["POST"])

This code seems to be duplicated in your project.

def mz_del():

This function should have a docstring.

    dmz = ValueTemplates.query.filter(ValueTemplates.id == request.form["mzid"]).first()
    if not dmz:
        flash("Nothing found in %s " % (request.form["mzid"]), "error")
        return redirect("/settings/mz")

    db.session.delete(dmz)
    try:
        db.session.commit()
        flash("OK: deleted %s " % dmz.value, "success")
    except:

General except handlers without types should be used sparingly.

        flash("ERROR while trying to delete : %s" % dmz.value, "error")
    return redirect("/settings/mz")


@settings.route("/mz/new", methods=["POST"])
def mz_new():

This function should have a docstring.

    db.session.add(ValueTemplates("naxsi_mz", request.form["nmz"]))
    db.session.commit()
    flash("Updated MZ: %s" % request.form["nmz"], "success")
    return redirect("/settings/mz")


@settings.route("/scores")
def score_index():

This function should have a docstring.

    sc = ValueTemplates.query.filter(ValueTemplates.name == "naxsi_score").order_by(ValueTemplates.value).all()

This line is too long as per the coding-style (111/90).

The name sc does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

    if not sc:
        return redirect("/settings")
    return render_template("settings/scores.html", scores=sc)


@settings.route("/scores/new", methods=["POST"])
def score_new():

This function should have a docstring.

    if not request.form["nscore"].startswith("$"):
        request.form["nscore"] = '$' + request.form["nscore"]

    db.session.add(ValueTemplates("naxsi_score", request.form["nscore"].upper()))
    db.session.commit()
    flash("Updated Score: %s" % request.form["nscore"], "success")
    return redirect("/settings/scores")


@settings.route("/scores/del", methods=["POST"])

This code seems to be duplicated in your project.

def scores_del():

This function should have a docstring.

    dsc = ValueTemplates.query.filter(ValueTemplates.id == request.form["scid"]).first()
    if not dsc:
        flash("Nothing found in %s " % (request.form["scid"]), "error")
        return redirect("/settings/scores")
    db.session.delete(dsc)

    try:
        db.session.commit()
        flash("OK: deleted %s " % dsc.value, "success")
    except:

General except handlers without types should be used sparingly.

        flash("ERROR while trying to delete : %s" % dsc.value, "error")
    return redirect("/settings/scores")

@settings.route("/save", methods=["POST"])
def save_settings():

This function should have a docstring.

    s = ''

The name s does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

    for s in request.form:

The name s does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

        sfind = Settings.query.filter(Settings.name == s).first()
        if not sfind:
            logging.error("no value for %s", sfind)
            continue

        if sfind.value != request.form[s]:
            sfind.value = request.form[s]
            db.session.add(sfind)

    flash("Updated setting: %s" % s, "success")
    db.session.commit()
    os.system("touch spike/__init__.py")
    return redirect("/settings")