ConfigurationParser::parseToJson() - Code Metrics - Inspection of "[master] feat: Add new ConfigurationManager" - nbremont/cap-sniffer - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( fa8c20...ab35ba )

by Nicolas

created 2016-12-27 12:23 UTC

ConfigurationParser::parseToJson() B

↳ Parent: ConfigurationParser

Complexity

Conditions	5
Paths	5

Size

Total Lines	18
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	18
rs	8.8571
cc	5
eloc	11
nc	5
nop	1

<?php

namespace Cp\Parser;
use Cp\Transformer\UrlTransformer;

/**
 * Class ConfigurationParser
 */
class ConfigurationParser extends AbstractCpParser
{
    /**
     * @var UrlTransformer
     */
    protected $urlTransformer;

    /**
     * @param string $url
     *
     * @return string
     * @throws \Exception
     */
    public function parseToJson($url)
    {
        $this->loadContent($url);
        $configurations = $this->parser->find('ul#blocsplans li');
        if (0 >= $configurations->count()) {
            throw new \Exception(sprintf('Configuration not found for this url: %s', $url));
        }

        $configurationList = [];
        foreach ($configurations as $conf) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            foreach ($conf->find('p a') as $link) {
                if (null !== $configurationFor = $this->urlTransformer->reverseConfiguration($link->href))
                $configurationList[] = $configurationFor;
            }
        }

        return json_encode($configurationList, true);
    }

    /**
     * @param UrlTransformer $urlTransformer
     */
    public function setUrlTransformer(UrlTransformer $urlTransformer)
    {
        $this->urlTransformer = $urlTransformer;
    }
}

1			<?php
2
3			namespace Cp\Parser;
4			use Cp\Transformer\UrlTransformer;
5
6			/**
7			* Class ConfigurationParser
8			*/
9			class ConfigurationParser extends AbstractCpParser
10			{
11			/**
12			* @var UrlTransformer
13			*/
14			protected $urlTransformer;
15
16			/**
17			* @param string $url
18			*
19			* @return string
20			* @throws \Exception
21			*/
22			public function parseToJson($url)
23			{
24			$this->loadContent($url);
25			$configurations = $this->parser->find('ul#blocsplans li');
26			if (0 >= $configurations->count()) {
27			throw new \Exception(sprintf('Configuration not found for this url: %s', $url));
28			}
29
30			$configurationList = [];
31			foreach ($configurations as $conf) {
			0 ignored issues – show Bug introduced 2016-12-27 12:24 UTC by Report Bug Copy Issue Report The expression `$configurations` of type `array\|object<PHPHtmlParser\Dom\AbstractNode>` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
32			foreach ($conf->find('p a') as $link) {
33			if (null !== $configurationFor = $this->urlTransformer->reverseConfiguration($link->href))
34			$configurationList[] = $configurationFor;
35			}
36			}
37
38			return json_encode($configurationList, true);
39			}
40
41			/**
42			* @param UrlTransformer $urlTransformer
43			*/
44			public function setUrlTransformer(UrlTransformer $urlTransformer)
45			{
46			$this->urlTransformer = $urlTransformer;
47			}
48			}

nbremont / cap-sniffer

Push — master ( fa8c20...ab35ba )

ConfigurationParser::parseToJson() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like