Cp\Manager\ConfigurationManager

Complexity

Total Complexity

3

Size/Duplication

Total Lines	88
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

85.71%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	1
A	createConfiguration()	0	11	1
B	findConfigurationsByType()	0	27	1

<?php

namespace Cp\Manager;

use Cp\DomainObject\Configuration;
use Cp\Parser\ConfigurationParser;
use Cp\Provider\TypeProvider;
use Doctrine\Common\Cache\MemcachedCache;

/**
 * Class ConfigurationManager
 */
class ConfigurationManager
{
    const CACHE_KEY = 'configuration.list';

    /**
     * @var TypeProvider
     */
    private $typeProvider;

    /**
     * @var ConfigurationParser
     */
    protected $configurationParser;

    /**
     * @var MemcachedCache
     */
    protected $memcache;

    /**
     * ConfigurationManager constructor.
     *
     * @param TypeProvider        $typeProvider
     * @param ConfigurationParser $configurationParser
     * @param MemcachedCache      $memcachedCache
     */
    public function __construct(
        TypeProvider $typeProvider,
        ConfigurationParser $configurationParser,
        MemcachedCache $memcachedCache
    ) {
        $this->typeProvider = $typeProvider;
        $this->configurationParser = $configurationParser;
        $this->memcache = $memcachedCache;
    }

    /**
     * @param string $typeName
     * @param int    $week
     * @param int    $seance
     *
     * @return Configuration
     */
    public function createConfiguration($typeName, $week, $seance)
    {
        $type = $this->typeProvider->getTypeByName($typeName);

        $configuration = new Configuration();
        $configuration->setType($type);
        $configuration->setNumberOfWeek($week);
        $configuration->setNumberOfSeance($seance);

        return $configuration;
    }

    /**
     * @param string $typeName
     *
     * @return array

Should the return type not be array|null?

     */
    public function findConfigurationsByType($typeName)

The parameter $typeName is not used and could be removed.

    {
        /*

58% of this comment could be valid code. Did you maybe forget this after debugging?

        $configurationForType = $this->memcache->fetch(self::CACHE_KEY.$typeName);

        if (false === $configurationForType) {
            $configurationForType = json_decode(
                $this
                    ->configurationParser
                    ->parseToJson('/Users/perso/Workspace/cap-sniffer-api/web/mock/plan-10-home.html')
                , true);
            $this->memcache->save(self::CACHE_KEY.$typeName, $configurationForType, 3600);
        }

        $configurationList = [];
        foreach ($configurationForType as $conf) {
            $configuration = new Configuration();
            $configuration->setType($typeName);
            $configuration->setNumberOfSeance($conf['seance']);
            $configuration->setNumberOfWeek($conf['week']);

            $configurationList[] = $configuration;
        }

        return $configurationList;
        */
    }
}