Complex classes like Page often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Page, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
35 | class Page { |
||
36 | use |
||
37 | Singleton, |
||
38 | Assets; |
||
39 | const INIT_STATE_METHOD = 'init'; |
||
40 | /** |
||
41 | * Complete page contents |
||
42 | * |
||
43 | * @var string |
||
44 | */ |
||
45 | public $Content; |
||
46 | /** |
||
47 | * If `false` - only page content will be shown, without the rest of interface (useful for AJAX request, though for API it is set to `false` automatically) |
||
48 | * |
||
49 | * @var bool |
||
50 | */ |
||
51 | public $interface; |
||
52 | /** |
||
53 | * @var string |
||
54 | */ |
||
55 | public $pre_Html; |
||
56 | /** |
||
57 | * @var string |
||
58 | */ |
||
59 | public $Html; |
||
60 | /** |
||
61 | * @var string |
||
62 | */ |
||
63 | public $Description; |
||
64 | /** |
||
65 | * @var string|string[] |
||
66 | */ |
||
67 | public $Title; |
||
68 | /** |
||
69 | * @var string |
||
70 | */ |
||
71 | public $Head; |
||
72 | /** |
||
73 | * @var string |
||
74 | */ |
||
75 | public $pre_Body; |
||
76 | /** |
||
77 | * @var string |
||
78 | */ |
||
79 | public $Left; |
||
80 | /** |
||
81 | * @var string |
||
82 | */ |
||
83 | public $Top; |
||
84 | /** |
||
85 | * @var string |
||
86 | */ |
||
87 | public $Right; |
||
88 | /** |
||
89 | * @var string |
||
90 | */ |
||
91 | public $Bottom; |
||
92 | /** |
||
93 | * @var string |
||
94 | */ |
||
95 | public $post_Body; |
||
96 | /** |
||
97 | * @var string |
||
98 | */ |
||
99 | public $post_Html; |
||
100 | /** |
||
101 | * Number of tabs by default for indentation the substitution of values into template |
||
102 | * |
||
103 | * @var array |
||
104 | */ |
||
105 | public $level; |
||
106 | /** |
||
107 | * @var array[] |
||
108 | */ |
||
109 | protected $link; |
||
110 | /** |
||
111 | * @var string[] |
||
112 | */ |
||
113 | protected $search_replace; |
||
114 | /** |
||
115 | * @var false|string |
||
116 | */ |
||
117 | protected $canonical_url; |
||
118 | protected $theme; |
||
119 | /** |
||
120 | * @param string $property |
||
121 | * |
||
122 | * @return false|null|string |
||
123 | */ |
||
124 | public function __get ($property) { |
||
125 | // Hack: for internal use by \cs\Meta class |
||
126 | if ($property === 'canonical_url') { |
||
127 | return $this->canonical_url; |
||
128 | } |
||
129 | return false; |
||
130 | } |
||
131 | 34 | protected function init () { |
|
132 | 34 | $this->Content = ''; |
|
133 | 34 | $this->interface = true; |
|
134 | 34 | $this->pre_Html = ''; |
|
135 | 34 | $this->Html = ''; |
|
136 | 34 | $this->Description = ''; |
|
137 | 34 | $this->Title = []; |
|
138 | 34 | $this->Head = ''; |
|
139 | 34 | $this->pre_Body = ''; |
|
140 | 34 | $this->Left = ''; |
|
141 | 34 | $this->Top = ''; |
|
142 | 34 | $this->Right = ''; |
|
143 | 34 | $this->Bottom = ''; |
|
144 | 34 | $this->post_Body = ''; |
|
145 | 34 | $this->post_Html = ''; |
|
146 | 34 | $this->level = [ |
|
147 | 'Head' => 0, |
||
148 | 'pre_Body' => 1, |
||
149 | 'Left' => 3, |
||
150 | 'Top' => 3, |
||
151 | 'Content' => 4, |
||
152 | 'Bottom' => 3, |
||
153 | 'Right' => 3, |
||
154 | 'post_Body' => 1 |
||
155 | ]; |
||
156 | 34 | $this->link = []; |
|
157 | 34 | $this->search_replace = []; |
|
158 | 34 | $this->canonical_url = false; |
|
159 | 34 | $this->theme = null; |
|
160 | 34 | $this->init_assets(); |
|
161 | 34 | $Config = Config::instance(true); |
|
162 | /** |
||
163 | * We need Config for initialization |
||
164 | */ |
||
165 | 34 | if (!$Config) { |
|
166 | 4 | Event::instance()->once( |
|
167 | 4 | 'System/Config/init/after', |
|
168 | function () { |
||
169 | 2 | $this->theme = Config::instance()->core['theme']; |
|
170 | 4 | } |
|
171 | ); |
||
172 | } else { |
||
173 | 32 | $this->theme = Config::instance()->core['theme']; |
|
174 | } |
||
175 | 34 | Event::instance()->on( |
|
176 | 34 | 'System/Config/changed', |
|
177 | 34 | function () { |
|
178 | $this->theme = Config::instance()->core['theme']; |
||
179 | 34 | } |
|
180 | ); |
||
181 | 34 | } |
|
182 | /** |
||
183 | * Adding of content on the page |
||
184 | * |
||
185 | * @param string $add |
||
186 | * @param bool|int $level |
||
187 | * |
||
188 | * @return Page |
||
189 | */ |
||
190 | public function content ($add, $level = false) { |
||
191 | if ($level !== false) { |
||
192 | $this->Content .= h::level($add, $level); |
||
193 | } else { |
||
194 | $this->Content .= $add; |
||
195 | } |
||
196 | return $this; |
||
197 | } |
||
198 | /** |
||
199 | * Sets body with content, that is transformed into JSON format |
||
200 | * |
||
201 | * @param mixed $content |
||
202 | * |
||
203 | * @return Page |
||
204 | */ |
||
205 | 20 | public function json ($content) { |
|
211 | /** |
||
212 | * Loading of theme template |
||
213 | */ |
||
214 | 2 | protected function get_template () { |
|
226 | /** |
||
227 | * Processing of template, substituting of content, preparing for the output |
||
228 | * |
||
229 | * @return Page |
||
230 | */ |
||
231 | 2 | protected function prepare () { |
|
322 | /** |
||
323 | * @return string |
||
324 | */ |
||
325 | 2 | protected function get_favicon_path () { |
|
332 | /** |
||
333 | * @param string $property |
||
334 | * |
||
335 | * @return string |
||
336 | */ |
||
337 | 2 | protected function get_property_with_indentation ($property) { |
|
340 | /** |
||
341 | * Replacing anything in source code of finally generated page |
||
342 | * |
||
343 | * Parameters may be both simply strings for str_replace() and regular expressions for preg_replace() |
||
344 | * |
||
345 | * @param string|string[] $search |
||
346 | * @param string|string[] $replace |
||
347 | * |
||
348 | * @return Page |
||
349 | */ |
||
350 | public function replace ($search, $replace = '') { |
||
351 | if (is_array($search)) { |
||
352 | $this->search_replace = $search + $this->search_replace; |
||
353 | } else { |
||
354 | /** @noinspection OffsetOperationsInspection */ |
||
355 | $this->search_replace[$search] = $replace; |
||
356 | } |
||
357 | return $this; |
||
358 | } |
||
359 | /** |
||
360 | * Processing of replacing in content |
||
361 | * |
||
362 | * @param string $content |
||
363 | * |
||
364 | * @return string |
||
365 | */ |
||
366 | 22 | protected function process_replacing ($content) { |
|
373 | /** |
||
374 | * Adding links |
||
375 | * |
||
376 | * @param array $data According to h class syntax |
||
377 | * |
||
378 | * @return Page |
||
379 | */ |
||
380 | public function link ($data) { |
||
381 | if ($data !== false) { |
||
382 | $this->link[] = $data; |
||
383 | } |
||
384 | return $this; |
||
385 | } |
||
386 | /** |
||
387 | * Simple wrapper of $Page->link() for inserting Atom feed on page |
||
388 | * |
||
389 | * @param string $href |
||
390 | * @param string $title |
||
391 | * |
||
392 | * @return Page |
||
393 | */ |
||
394 | public function atom ($href, $title = 'Atom Feed') { |
||
395 | return $this->link( |
||
396 | [ |
||
397 | 'href' => $href, |
||
398 | 'title' => $title, |
||
399 | 'rel' => 'alternate', |
||
400 | 'type' => 'application/atom+xml' |
||
401 | ] |
||
402 | ); |
||
403 | } |
||
404 | /** |
||
405 | * Simple wrapper of $Page->link() for inserting RSS feed on page |
||
406 | * |
||
407 | * @param string $href |
||
408 | * @param string $title |
||
409 | * |
||
410 | * @return Page |
||
411 | */ |
||
412 | public function rss ($href, $title = 'RSS Feed') { |
||
413 | return $this->link( |
||
414 | [ |
||
415 | 'href' => $href, |
||
416 | 'title' => $title, |
||
417 | 'rel' => 'alternate', |
||
418 | 'type' => 'application/rss+xml' |
||
419 | ] |
||
420 | ); |
||
421 | } |
||
422 | /** |
||
423 | * Specify canonical url of current page |
||
424 | * |
||
425 | * @param string $url |
||
426 | * |
||
427 | * @return Page |
||
428 | */ |
||
429 | public function canonical_url ($url) { |
||
430 | $this->canonical_url = $url; |
||
431 | $this->link['canonical_url'] = [ |
||
432 | 'href' => $this->canonical_url, |
||
433 | 'rel' => 'canonical' |
||
434 | ]; |
||
435 | return $this; |
||
436 | } |
||
437 | /** |
||
438 | * Adding text to the title page |
||
439 | * |
||
440 | * @param string $title |
||
441 | * @param bool $replace Replace whole title by this |
||
442 | * |
||
443 | * @return Page |
||
444 | */ |
||
445 | 2 | public function title ($title, $replace = false) { |
|
454 | /** |
||
455 | * Display success message |
||
456 | * |
||
457 | * @param string $success_text |
||
458 | * |
||
459 | * @return Page |
||
460 | */ |
||
461 | public function success ($success_text) { |
||
462 | return $this->top_message($success_text, 'success'); |
||
463 | } |
||
464 | /** |
||
465 | * Display notice message |
||
466 | * |
||
467 | * @param string $notice_text |
||
468 | * |
||
469 | * @return Page |
||
470 | */ |
||
471 | public function notice ($notice_text) { |
||
472 | return $this->top_message($notice_text, 'warning'); |
||
473 | } |
||
474 | /** |
||
475 | * Display warning message |
||
476 | * |
||
477 | * @param string $warning_text |
||
478 | * |
||
479 | * @return Page |
||
480 | */ |
||
481 | 2 | public function warning ($warning_text) { |
|
484 | /** |
||
485 | * Generic method for 3 methods above |
||
486 | * |
||
487 | * @param string $message |
||
488 | * @param string $class_ending |
||
489 | * |
||
490 | * @return Page |
||
491 | */ |
||
492 | 2 | protected function top_message ($message, $class_ending) { |
|
501 | /** |
||
502 | * Error pages processing |
||
503 | * |
||
504 | * @param null|string|string[] $custom_text Custom error text instead of text like "404 Not Found" or array with two elements: [error, error_description] |
||
505 | * @param bool $json Force JSON return format |
||
506 | */ |
||
507 | 14 | public function error ($custom_text = null, $json = false) { |
|
534 | /** |
||
535 | * @param int $code |
||
536 | * @param null|string|string[] $custom_text |
||
537 | * |
||
538 | * @return string[] |
||
539 | */ |
||
540 | 14 | protected function error_title_description ($code, $custom_text) { |
|
548 | /** |
||
549 | * @param string $title |
||
550 | * @param string $description |
||
551 | * |
||
552 | * @return string |
||
553 | */ |
||
554 | 4 | protected function error_page ($title, $description) { |
|
567 | /** |
||
568 | * Provides next events: |
||
569 | * System/Page/render/before |
||
570 | * |
||
571 | * System/Page/render/after |
||
572 | * |
||
573 | * Page generation |
||
574 | */ |
||
575 | 22 | public function render () { |
|
603 | } |
||
604 |