Inspection of "More refactoring, system doesn't use superglobals..." - nazar-pc/CleverStyle-Framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 031d4a...13e14b )

by Nazar

created 2016-03-29 17:05 UTC

Status

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -31,7 +31,7 @@
 block discarded – undo
  * Time of start of execution, is used as current time
  */
 define('MICROTIME', microtime(true)); //Time in seconds (float)
-define('TIME', floor(MICROTIME));     //Time in seconds (integer)
-define('DIR', __DIR__);               //Root directory
+define('TIME', floor(MICROTIME)); //Time in seconds (integer)
+define('DIR', __DIR__); //Root directory
 chdir(DIR);
-require_once DIR.'/core/loader.php';  //Loader starting
+require_once DIR.'/core/loader.php'; //Loader starting

Please login to merge, or discard this patch.

Indentation +24 added lines, -24 removed lines patch added patch discarded remove patch

@@ -1,35 +1,35 @@
 block discarded – undo
 <?php
 /**
- * @package   CleverStyle CMS
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   CleverStyle CMS
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 /**
- * Requirements:
- * * Apache2
- *  Apache2 modules MUST be enabled:
- *  * rewrite
- *  * headers
- *  Optional Apache2 modules:
- *  * expires
- * * or Nginx
- * * PHP 5.6+
- *  PHP libraries MUST be present:
- *  * cURL
- *  Optional PHP libraries:
- *  * APCu, Memcached
- * * or HHVM 3.3.2+ LTS or HHVM 3.4.1+
- * * MySQL 5.6+
- * * or MariaDB 10.0.5+
- */
+	 * Requirements:
+	 * * Apache2
+	 *  Apache2 modules MUST be enabled:
+	 *  * rewrite
+	 *  * headers
+	 *  Optional Apache2 modules:
+	 *  * expires
+	 * * or Nginx
+	 * * PHP 5.6+
+	 *  PHP libraries MUST be present:
+	 *  * cURL
+	 *  Optional PHP libraries:
+	 *  * APCu, Memcached
+	 * * or HHVM 3.3.2+ LTS or HHVM 3.4.1+
+	 * * MySQL 5.6+
+	 * * or MariaDB 10.0.5+
+	 */
 if (version_compare(PHP_VERSION, '5.6', '<')) {
 	echo 'CleverStyle CMS require PHP 5.6 or higher';
 	return;
 }
 /**
- * Time of start of execution, is used as current time
- */
+	 * Time of start of execution, is used as current time
+	 */
 define('MICROTIME', microtime(true)); //Time in seconds (float)
 define('TIME', floor(MICROTIME));     //Time in seconds (integer)
 define('DIR', __DIR__);               //Root directory

Please login to merge, or discard this patch.

components/modules/Polls/Options.php 2 patches

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -20,7 +20,7 @@
 block discarded – undo
 	use
 		CRUD,
 		Singleton;
-	protected $data_model          = [
+	protected $data_model = [
 		'id'     => 'int',
 		'title'  => 'ml:text',
 		'path'   => 'ml:text',

Please login to merge, or discard this patch.

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   Polls
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2014-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Polls
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2014-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\modules\Polls;
 
 use

Please login to merge, or discard this patch.

components/modules/Polls/Polls.php 2 patches

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -20,7 +20,7 @@
 block discarded – undo
 	use
 		CRUD,
 		Singleton;
-	protected $data_model          = [
+	protected $data_model = [
 		'id'     => 'int',
 		'title'  => 'ml:text',
 		'path'   => 'ml:text',

Please login to merge, or discard this patch.

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   Polls
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2014-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Polls
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2014-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\modules\Polls;
 
 use

Please login to merge, or discard this patch.

components/modules/Shop/Attributes.php 2 patches

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -20,7 +20,7 @@
 block discarded – undo
 	use
 		CRUD,
 		Singleton;
-	protected $data_model          = [
+	protected $data_model = [
 		'id'     => 'int',
 		'title'  => 'ml:text',
 		'path'   => 'ml:text',

Please login to merge, or discard this patch.

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   Shop
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2014-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Shop
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2014-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\modules\Shop;
 use
 	h,

Please login to merge, or discard this patch.

components/modules/Shop/Categories.php 2 patches

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -20,7 +20,7 @@
 block discarded – undo
 	use
 		CRUD,
 		Singleton;
-	protected $data_model          = [
+	protected $data_model = [
 		'id'     => 'int',
 		'title'  => 'ml:text',
 		'path'   => 'ml:text',

Please login to merge, or discard this patch.

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   Shop
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2014-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Shop
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2014-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\modules\Shop;
 use
 	h,

Please login to merge, or discard this patch.

components/modules/Shop/Order_statuses.php 2 patches

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -20,7 +20,7 @@
 block discarded – undo
 	use
 		CRUD,
 		Singleton;
-	protected $data_model          = [
+	protected $data_model = [
 		'id'     => 'int',
 		'title'  => 'ml:text',
 		'path'   => 'ml:text',

Please login to merge, or discard this patch.

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   Shop
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2014-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Shop
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2014-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\modules\Shop;
 use
 	h,

Please login to merge, or discard this patch.

components/modules/Shop/Shipping_types.php 2 patches

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -20,7 +20,7 @@
 block discarded – undo
 	use
 		CRUD,
 		Singleton;
-	protected $data_model          = [
+	protected $data_model = [
 		'id'     => 'int',
 		'title'  => 'ml:text',
 		'path'   => 'ml:text',

Please login to merge, or discard this patch.

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   Shop
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2014-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Shop
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2014-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\modules\Shop;
 use
 	h,

Please login to merge, or discard this patch.

upload_build.php 1 patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -23,8 +23,8 @@
 block discarded – undo
 	]
 );
 /**
- * Check whether commit is tagged - if so - we are dealing with release
- */
+	 * Check whether commit is tagged - if so - we are dealing with release
+	 */
 $tag = exec('git describe --tags --exact-match HEAD 2>/dev/null');
 if (!$on_master && !$tag) {
 	echo "Distributive is uploaded only when on master branch or releases\n";

Please login to merge, or discard this patch.

components/modules/Blogs/Posts.php 2 patches

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -24,7 +24,7 @@  discard block
 block discarded – undo
 	use
 		CRUD,
 		Singleton;
-	protected $data_model                  = [
+	protected $data_model = [
 		'id'      => 'int:0',
 		'user'    => 'int:0',
 		'date'    => 'int:0',
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
 						FROM `$this->table_sections`
 						WHERE `id` = $id"
 					);
-					$data['tags']          = $this->db()->qfas(
+					$data['tags'] = $this->db()->qfas(
 						"SELECT DISTINCT `tag`
 						FROM `$this->table_tags`
 						WHERE
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
 							`lang`	= '$L->clang'"
 					);
 					if (!$data['tags']) {
-						$l            = $this->db()->qfs(
+						$l = $this->db()->qfs(
 							"SELECT `lang`
 							FROM `$this->table_tags`
 							WHERE `id` = $id

Please login to merge, or discard this patch.

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   Blogs
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Blogs
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\modules\Blogs;
 use
 	cs\Language;

Please login to merge, or discard this patch.

		@@ -31,7 +31,7 @@
		block discarded – undo
31	31	* Time of start of execution, is used as current time
32	32	*/
33	33	define('MICROTIME', microtime(true)); //Time in seconds (float)
34		-define('TIME', floor(MICROTIME)); //Time in seconds (integer)
35		-define('DIR', __DIR__); //Root directory
	34	+define('TIME', floor(MICROTIME)); //Time in seconds (integer)
	35	+define('DIR', __DIR__); //Root directory
36	36	chdir(DIR);
37		-require_once DIR.'/core/loader.php'; //Loader starting
	37	+require_once DIR.'/core/loader.php'; //Loader starting

		@@ -1,35 +1,35 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * @package CleverStyle CMS
4		- * @author Nazar Mokrynskyi <[email protected]>
5		- * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
6		- * @license MIT License, see license.txt
7		- */
	3	+ * @package CleverStyle CMS
	4	+ * @author Nazar Mokrynskyi <[email protected]>
	5	+ * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
	6	+ * @license MIT License, see license.txt
	7	+ */
8	8	/**
9		- * Requirements:
10		- * * Apache2
11		- * Apache2 modules MUST be enabled:
12		- * * rewrite
13		- * * headers
14		- * Optional Apache2 modules:
15		- * * expires
16		- * * or Nginx
17		- * * PHP 5.6+
18		- * PHP libraries MUST be present:
19		- * * cURL
20		- * Optional PHP libraries:
21		- * * APCu, Memcached
22		- * * or HHVM 3.3.2+ LTS or HHVM 3.4.1+
23		- * * MySQL 5.6+
24		- * * or MariaDB 10.0.5+
25		- */
	9	+ * Requirements:
	10	+ * * Apache2
	11	+ * Apache2 modules MUST be enabled:
	12	+ * * rewrite
	13	+ * * headers
	14	+ * Optional Apache2 modules:
	15	+ * * expires
	16	+ * * or Nginx
	17	+ * * PHP 5.6+
	18	+ * PHP libraries MUST be present:
	19	+ * * cURL
	20	+ * Optional PHP libraries:
	21	+ * * APCu, Memcached
	22	+ * * or HHVM 3.3.2+ LTS or HHVM 3.4.1+
	23	+ * * MySQL 5.6+
	24	+ * * or MariaDB 10.0.5+
	25	+ */
26	26	if (version_compare(PHP_VERSION, '5.6', '<')) {
27	27	echo 'CleverStyle CMS require PHP 5.6 or higher';
28	28	return;
29	29	}
30	30	/**
31		- * Time of start of execution, is used as current time
32		- */
	31	+ * Time of start of execution, is used as current time
	32	+ */
33	33	define('MICROTIME', microtime(true)); //Time in seconds (float)
34	34	define('TIME', floor(MICROTIME)); //Time in seconds (integer)
35	35	define('DIR', __DIR__); //Root directory

		@@ -20,7 +20,7 @@
		block discarded – undo
20	20	use
21	21	CRUD,
22	22	Singleton;
23		- protected $data_model = [
	23	+ protected $data_model = [
24	24	'id' => 'int',
25	25	'title' => 'ml:text',
26	26	'path' => 'ml:text',

		@@ -1,11 +1,11 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * @package Polls
4		- * @category modules
5		- * @author Nazar Mokrynskyi <[email protected]>
6		- * @copyright Copyright (c) 2014-2016, Nazar Mokrynskyi
7		- * @license MIT License, see license.txt
8		- */
	3	+ * @package Polls
	4	+ * @category modules
	5	+ * @author Nazar Mokrynskyi <[email protected]>
	6	+ * @copyright Copyright (c) 2014-2016, Nazar Mokrynskyi
	7	+ * @license MIT License, see license.txt
	8	+ */
9	9	namespace cs\modules\Polls;
10	10
11	11	use

		@@ -23,8 +23,8 @@
		block discarded – undo
23	23	]
24	24	);
25	25	/**
26		- * Check whether commit is tagged - if so - we are dealing with release
27		- */
	26	+ * Check whether commit is tagged - if so - we are dealing with release
	27	+ */
28	28	$tag = exec('git describe --tags --exact-match HEAD 2>/dev/null');
29	29	if (!$on_master && !$tag) {
30	30	echo "Distributive is uploaded only when on master branch or releases\n";

		@@ -24,7 +24,7 @@ discard block
		block discarded – undo
24	24	use
25	25	CRUD,
26	26	Singleton;
27		- protected $data_model = [
	27	+ protected $data_model = [
28	28	'id' => 'int:0',
29	29	'user' => 'int:0',
30	30	'date' => 'int:0',
		@@ -84,7 +84,7 @@ discard block
		block discarded – undo
84	84	FROM `$this->table_sections`
85	85	WHERE `id` = $id"
86	86	);
87		- $data['tags'] = $this->db()->qfas(
	87	+ $data['tags'] = $this->db()->qfas(
88	88	"SELECT DISTINCT `tag`
89	89	FROM `$this->table_tags`
90	90	WHERE
		@@ -92,7 +92,7 @@ discard block
		block discarded – undo
92	92	`lang` = '$L->clang'"
93	93	);
94	94	if (!$data['tags']) {
95		- $l = $this->db()->qfs(
	95	+ $l = $this->db()->qfs(
96	96	"SELECT `lang`
97	97	FROM `$this->table_tags`
98	98	WHERE `id` = $id

nazar-pc / CleverStyle-Framework

Push — master ( 031d4a...13e14b )

Status

Category

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +24 added lines, -24 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch