Data::get_data() - Code Metrics - Inspection of "Some refactoring and removal of redundant checks" - nazar-pc/CleverStyle-Framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 832b5f...553e14 )

by Nazar

created 2016-04-18 02:07 UTC

Data::get_data() C

↳ Parent: Data

Complexity

Conditions	15
Paths	46

Size

Total Lines	66
Code Lines	45

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
dl	0
loc	66
rs	5.8663
c	2
b	1
f	0
cc	15
eloc	45
nc	46
nop	2

How to fix Long Method Complexity

<?php
/**
 * @package   CleverStyle CMS
 * @author    Nazar Mokrynskyi <[email protected]>
 * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
 * @license   MIT License, see license.txt
 */
namespace cs\User;
use
	cs\User;

/**
 * Trait that contains all methods for `cs\User` for working with user's data
 *
 * @property \cs\Cache\Prefix $cache
 * @property int              $id
 *
 * @method \cs\DB\_Abstract db()
 * @method \cs\DB\_Abstract db_prime()
 */
trait Data {
	/**
	 * Getting additional data item(s) of specified user
	 *
	 * @param string|string[] $item
	 * @param false|int       $user If not specified - current user assumed
	 *
	 * @return false|string|mixed[]
	 */
	function get_data ($item, $user = false) {
		$user = (int)$user ?: $this->id;
		if (!$item || $user == User::GUEST_ID) {
			return false;
		}
		$data = $this->cache->{"data/$user"} ?: [];
		if (is_array($item)) {
			$result = [];
			$absent = [];
			foreach ($item as $i) {
				if (isset($data[$i])) {
					$result[$i] = $data[$i];
				} else {
					$absent[] = $i;
				}
			}
			if ($absent) {
				$absent = implode(
					',',
					$this->db()->s($absent)
				);
				$absent = array_column(
					$this->db()->qfa(
						"SELECT `item`, `value`
						FROM `[prefix]users_data`
						WHERE
							`id`	= '$user' AND
							`item`	IN($absent)"
					),
					'value',
					'item'
				);
				foreach ($absent as &$a) {
					$a = _json_decode($a);
					if ($a === null) {
						$a = false;
					}
				}
				unset($a);
				$result += $absent;
				$data += $absent;
				$this->cache->{"data/$user"} = $data;
			}
			return $result;
		}
		if ($data === false || !isset($data[$item])) {
			if (!is_array($data)) {
				$data = [];
			}
			$data[$item] = _json_decode(
				$this->db()->qfs(
					"SELECT `value`
					FROM `[prefix]users_data`
					WHERE
						`id`	= '$user' AND
						`item`	= '%s'",
					$item
				)
			);
			if ($data[$item] === null) {
				$data[$item] = false;
			}
			$this->cache->{"data/$user"} = $data;
		}
		return $data[$item];
	}
	/**
	 * Setting additional data item(s) of specified user
	 *
	 * @param array|string $item Item-value array may be specified for setting several items at once
	 * @param mixed|null   $value
	 * @param false|int    $user If not specified - current user assumed
	 *
	 * @return bool
	 */
	function set_data ($item, $value = null, $user = false) {
		$user = (int)$user ?: $this->id;
		if (!$item || $user == User::GUEST_ID) {
			return false;
		}
		if (!is_array($item)) {
			$item = [
				$item => $value
			];
		}
		$params = [];
		foreach ($item as $i => $v) {
			$params[] = [$i, _json_encode($v)];
		}
		unset($i, $v);
		$result = $this->db_prime()->insert(
			"REPLACE INTO `[prefix]users_data`
				(
					`id`,
					`item`,
					`value`
				) VALUES (
					$user,
					'%s',
					'%s'
				)",
			$params
		);
		$this->cache->del("data/$user");
		return $result;
	}
	/**
	 * Deletion of additional data item(s) of specified user
	 *
	 * @param string|string[] $item
	 * @param false|int       $user If not specified - current user assumed
	 *
	 * @return bool
	 */
	function del_data ($item, $user = false) {
		$user = (int)$user ?: $this->id;
		if (!$item || $user == User::GUEST_ID) {
			return false;
		}
		$item   = implode(
			',',
			$this->db_prime()->s((array)$item)
		);
		$result = $this->db_prime()->q(
			"DELETE FROM `[prefix]users_data`
			WHERE
				`id`	= '$user' AND
				`item`	IN($item)"
		);
		$this->cache->del("data/$user");
		return (bool)$result;
	}
}


1			<?php
2			/**
3			* @package CleverStyle CMS
4			* @author Nazar Mokrynskyi <[email protected]>
5			* @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
6			* @license MIT License, see license.txt
7			*/
8			namespace cs\User;
9			use
10			cs\User;
11
12			/**
13			* Trait that contains all methods for `cs\User` for working with user's data
14			*
15			* @property \cs\Cache\Prefix $cache
16			* @property int $id
17			*
18			* @method \cs\DB\_Abstract db()
19			* @method \cs\DB\_Abstract db_prime()
20			*/
21			trait Data {
22			/**
23			* Getting additional data item(s) of specified user
24			*
25			* @param string\|string[] $item
26			* @param false\|int $user If not specified - current user assumed
27			*
28			* @return false\|string\|mixed[]
29			*/
30			function get_data ($item, $user = false) {
31			$user = (int)$user ?: $this->id;
32			if (!$item \|\| $user == User::GUEST_ID) {
33			return false;
34			}
35			$data = $this->cache->{"data/$user"} ?: [];
36			if (is_array($item)) {
37			$result = [];
38			$absent = [];
39			foreach ($item as $i) {
40			if (isset($data[$i])) {
41			$result[$i] = $data[$i];
42			} else {
43			$absent[] = $i;
44			}
45			}
46			if ($absent) {
47			$absent = implode(
48			',',
49			$this->db()->s($absent)
50			);
51			$absent = array_column(
52			$this->db()->qfa(
53			"SELECT `item`, `value`
54			FROM `[prefix]users_data`
55			WHERE
56			`id` = '$user' AND
57			`item` IN($absent)"
58			),
59			'value',
60			'item'
61			);
62			foreach ($absent as &$a) {
63			$a = _json_decode($a);
64			if ($a === null) {
65			$a = false;
66			}
67			}
68			unset($a);
69			$result += $absent;
70			$data += $absent;
71			$this->cache->{"data/$user"} = $data;
72			}
73			return $result;
74			}
75			if ($data === false \|\| !isset($data[$item])) {
76			if (!is_array($data)) {
77			$data = [];
78			}
79			$data[$item] = _json_decode(
80			$this->db()->qfs(
81			"SELECT `value`
82			FROM `[prefix]users_data`
83			WHERE
84			`id` = '$user' AND
85			`item` = '%s'",
86			$item
87			)
88			);
89			if ($data[$item] === null) {
90			$data[$item] = false;
91			}
92			$this->cache->{"data/$user"} = $data;
93			}
94			return $data[$item];
95			}
96			/**
97			* Setting additional data item(s) of specified user
98			*
99			* @param array\|string $item Item-value array may be specified for setting several items at once
100			* @param mixed\|null $value
101			* @param false\|int $user If not specified - current user assumed
102			*
103			* @return bool
104			*/
105			function set_data ($item, $value = null, $user = false) {
106			$user = (int)$user ?: $this->id;
107			if (!$item \|\| $user == User::GUEST_ID) {
108			return false;
109			}
110			if (!is_array($item)) {
111			$item = [
112			$item => $value
113			];
114			}
115			$params = [];
116			foreach ($item as $i => $v) {
117			$params[] = [$i, _json_encode($v)];
118			}
119			unset($i, $v);
120			$result = $this->db_prime()->insert(
121			"REPLACE INTO `[prefix]users_data`
122			(
123			`id`,
124			`item`,
125			`value`
126			) VALUES (
127			$user,
128			'%s',
129			'%s'
130			)",
131			$params
132			);
133			$this->cache->del("data/$user");
134			return $result;
135			}
136			/**
137			* Deletion of additional data item(s) of specified user
138			*
139			* @param string\|string[] $item
140			* @param false\|int $user If not specified - current user assumed
141			*
142			* @return bool
143			*/
144			function del_data ($item, $user = false) {
145			$user = (int)$user ?: $this->id;
146			if (!$item \|\| $user == User::GUEST_ID) {
147			return false;
148			}
149			$item = implode(
150			',',
151			$this->db_prime()->s((array)$item)
152			);
153			$result = $this->db_prime()->q(
154			"DELETE FROM `[prefix]users_data`
155			WHERE
156			`id` = '$user' AND
157			`item` IN($item)"
158			);
159			$this->cache->del("data/$user");
160			return (bool)$result;
161			}
162			}
163

nazar-pc / CleverStyle-Framework

Push — master ( 832b5f...553e14 )

Data::get_data() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like