Complex classes like Data_and_files often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Data_and_files, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
14 | trait Data_and_files { |
||
15 | /** |
||
16 | * Data array, similar to `$_POST` |
||
17 | * |
||
18 | * @var array |
||
19 | */ |
||
20 | public $data; |
||
21 | /** |
||
22 | * Normalized files array |
||
23 | * |
||
24 | * Each file item can be either single file or array of files (in contrast with native PHP arrays where each field like `name` become an array) with keys |
||
25 | * `name`, `type`, `size`, `tmp_name`, `stream` and `error` |
||
26 | * |
||
27 | * `name`, `type`, `size` and `error` keys are similar to native PHP fields in `$_FILES`; `tmp_name` might not be temporary file, but file descriptor |
||
28 | * wrapper like `request-file:///file` instead and `stream` is resource like obtained with `fopen('/tmp/xyz', 'rb')` |
||
29 | * |
||
30 | * @var array[] |
||
31 | */ |
||
32 | public $files; |
||
33 | /** |
||
34 | * Data stream resource, similar to `fopen('php://input', 'rb')` |
||
35 | * |
||
36 | * Make sure you're controlling position in stream where you read something, if code in some other place might seek on this stream |
||
37 | * |
||
38 | * Stream is read-only |
||
39 | * |
||
40 | * @var null|resource |
||
41 | */ |
||
42 | public $data_stream; |
||
43 | /** |
||
44 | * `$this->init_server()` assumed to be called already |
||
45 | * |
||
46 | * @param array $data Typically `$_POST` |
||
47 | * @param array[] $files Typically `$_FILES`; might be like native PHP array `$_FILES` or normalized; each file item MUST contain keys |
||
48 | * `name`, `type`, `size`, `error` and at least one of `tmp_name` or `stream` |
||
49 | * @param null|resource|string $data_stream String, like `php://input` or resource, like `fopen('php://input', 'rb')` with request body, will be parsed for |
||
50 | * data and files if necessary |
||
51 | * @param bool $copy_stream Sometimes data stream can only being read once (like most of times with `php://input`), so it is necessary to |
||
52 | * copy it and store its contents for longer period of time |
||
53 | * |
||
54 | * @throws ExitException |
||
55 | */ |
||
56 | 32 | function init_data_and_files ($data = [], $files = [], $data_stream = null, $copy_stream = true) { |
|
86 | /** |
||
87 | * Get data item by name |
||
88 | * |
||
89 | * @param string[]|string[][] $name |
||
90 | * |
||
91 | * @return mixed|mixed[]|null Data items (or associative array of data items) if exists or `null` otherwise (in case if `$name` is an array even one |
||
92 | * missing key will cause the whole thing to fail) |
||
93 | */ |
||
94 | 32 | function data (...$name) { |
|
114 | /** |
||
115 | * Get file item by name |
||
116 | * |
||
117 | * @param string $name |
||
118 | * |
||
119 | * @return array|null File item if exists or `null` otherwise |
||
120 | */ |
||
121 | 2 | function files ($name) { |
|
124 | /** |
||
125 | * @param array[] $files |
||
126 | * @param string $file_path |
||
127 | * |
||
128 | * @return array[] |
||
129 | */ |
||
130 | 32 | protected function normalize_files ($files, $file_path = '') { |
|
157 | /** |
||
158 | * @param array $file |
||
159 | * @param string $file_path |
||
160 | * |
||
161 | * @return array |
||
162 | */ |
||
163 | 4 | protected function normalize_file ($file, $file_path) { |
|
179 | /** |
||
180 | * Parsing request body for following Content-Type: `application/json`, `application/x-www-form-urlencoded` and `multipart/form-data` |
||
181 | * |
||
182 | * @throws ExitException |
||
183 | */ |
||
184 | 6 | protected function parse_data_stream () { |
|
214 | /** |
||
215 | * Parse content stream |
||
216 | * |
||
217 | * @param resource $stream |
||
218 | * @param string $boundary |
||
219 | * |
||
220 | * @return array[]|false |
||
221 | * |
||
222 | * @throws UnexpectedValueException |
||
223 | * @throws ExitException |
||
224 | */ |
||
225 | 2 | protected function parse_multipart_into_parts ($stream, $boundary) { |
|
294 | /** |
||
295 | * @param resource $stream |
||
296 | * @param array[] $parts |
||
297 | * |
||
298 | * @return array[] |
||
299 | */ |
||
300 | 2 | protected function parse_multipart_analyze_parts ($stream, $parts) { |
|
345 | /** |
||
346 | * @return int |
||
347 | */ |
||
348 | 2 | protected function post_max_size () { |
|
352 | /** |
||
353 | * @return int |
||
354 | */ |
||
355 | 2 | protected function upload_max_file_size () { |
|
359 | /** |
||
360 | * @param int|string $size |
||
361 | * |
||
362 | * @return int |
||
363 | */ |
||
364 | 2 | protected function convert_size_to_bytes ($size) { |
|
375 | /** |
||
376 | * @param resource $stream |
||
377 | * @param string $next_data |
||
378 | * @param string $target |
||
379 | * |
||
380 | * @return array |
||
381 | * |
||
382 | * @throws UnexpectedValueException |
||
383 | */ |
||
384 | 2 | protected function parse_multipart_find ($stream, $next_data, $target) { |
|
404 | /** |
||
405 | * @param string $content |
||
406 | * |
||
407 | * @return array |
||
408 | */ |
||
409 | 2 | protected function parse_multipart_headers ($content) { |
|
431 | /** |
||
432 | * @param array $source |
||
433 | * @param string $name |
||
434 | * @param array|string $value |
||
435 | */ |
||
436 | 2 | protected function parse_multipart_set_target (&$source, $name, $value) { |
|
453 | } |
||
454 |