Inspection of "Simplification using CRUD trait" - nazar-pc/CleverStyle-Framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7710e6...19a091 )

by Nazar

created 2016-04-05 23:48 UTC

Status

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -1,10 +1,10 @@
 block discarded – undo
 <?php
 /**
- * @package   CleverStyle CMS
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2013-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   CleverStyle CMS
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2013-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\CRUD;
 use
 	cs\Event,

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -61,7 +61,7 @@  discard block
 block discarded – undo
 				'aliases'     => &$aliases,
 				'final_class' => &$next_alias
 			];
-			$classes                  = defined('CUSTOM') ? glob(CUSTOM.'/classes/'.substr($class, 2).'_*.php') : [];
+			$classes = defined('CUSTOM') ? glob(CUSTOM.'/classes/'.substr($class, 2).'_*.php') : [];
 			foreach ($classes as $custom_class) {
 				// Path to file with customized class
 				$custom_class = str_replace(CUSTOM.'/classes/', '', substr($custom_class, 0, -4));
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
 					'alias'    => "cs\\custom\\$_custom_class",
 					'path'     => $custom_class
 				];
-				$next_alias      = "cs\\custom\\$custom_class";
+				$next_alias = "cs\\custom\\$custom_class";
 			}
 			modified_classes($modified_classes);
 		}

Please login to merge, or discard this patch.

core/classes/Request.php 2 patches

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -1,10 +1,10 @@
 block discarded – undo
 <?php
 /**
- * @package   CleverStyle CMS
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   CleverStyle CMS
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\DB;
 class SQLite extends _Abstract {
 	/**

Please login to merge, or discard this patch.

Spacing +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -54,8 +54,7 @@
 block discarded – undo
 	 *
 	 * @throws ExitException
 	 */
-	function init ($server, $query, $data, $files, $data_stream, $cookie, $request_started) {
-		++static::$id;
+	function init ($server, $query, $data, $files, $data_stream, $cookie, $request_started) {++static::$id;
 		$this->init_server($server);
 		$this->init_query($query);
 		$this->init_data_and_files($data, $files, $data_stream);

Please login to merge, or discard this patch.

core/traits/Request/Cookie.php 1 patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -1,10 +1,10 @@
 block discarded – undo
 <?php
 /**
- * @package   CleverStyle CMS
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   CleverStyle CMS
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\DB;
 class SQLite extends _Abstract {
 	/**

Please login to merge, or discard this patch.

core/traits/Request/Query.php 1 patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -1,10 +1,10 @@
 block discarded – undo
 <?php
 /**
- * @package   CleverStyle CMS
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   CleverStyle CMS
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\DB;
 class SQLite extends _Abstract {
 	/**

Please login to merge, or discard this patch.

core/traits/Request/Server.php 1 patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -1,10 +1,10 @@
 block discarded – undo
 <?php
 /**
- * @package   CleverStyle CMS
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   CleverStyle CMS
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\DB;
 class SQLite extends _Abstract {
 	/**

Please login to merge, or discard this patch.

core/classes/Response.php 1 patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -1,10 +1,10 @@
 block discarded – undo
 <?php
 /**
- * @package   CleverStyle CMS
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   CleverStyle CMS
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\DB;
 class SQLite extends _Abstract {
 	/**

Please login to merge, or discard this patch.

components/modules/OAuth2/token.php 1 patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@  discard block
 block discarded – undo
 <?php
 /**
- * @package   OAuth2
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   OAuth2
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\modules\OAuth2;
 
 use
@@ -20,8 +20,8 @@  discard block
 block discarded – undo
 	->header('pragma', 'no-cache');
 interface_off();
 /**
- * Errors processing
- */
+	 * Errors processing
+	 */
 $Config = Config::instance();
 $Page   = Page::instance();
 if (!isset($_POST['grant_type'])) {
@@ -141,8 +141,8 @@  discard block
 block discarded – undo
 	throw $e;
 }
 /**
- * Tokens operations processing
- */
+	 * Tokens operations processing
+	 */
 switch ($_POST['grant_type']) {
 	case 'authorization_code':
 		if (!isset($_POST['code'])) {

Please login to merge, or discard this patch.

themes/DarkEnergy/prepare.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package    CleverStyle CMS
- * @subpackage DarkEnergy theme
- * @author     Nazar Mokrynskyi <[email protected]>
- * @copyright  Copyright (c) 2014-2016, Nazar Mokrynskyi
- * @license    MIT License, see license.txt
- */
+	 * @package    CleverStyle CMS
+	 * @subpackage DarkEnergy theme
+	 * @author     Nazar Mokrynskyi <[email protected]>
+	 * @copyright  Copyright (c) 2014-2016, Nazar Mokrynskyi
+	 * @license    MIT License, see license.txt
+	 */
 namespace cs;
 $Page = Page::instance();
 if (preg_match('/msie|trident/i', Request::instance()->user_agent)) {

Please login to merge, or discard this patch.

core/classes/Menu.php 1 patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -1,10 +1,10 @@
 block discarded – undo
 <?php
 /**
- * @package   CleverStyle CMS
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2014-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   CleverStyle CMS
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2014-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\Page;
 use
 	cs\Core,

Please login to merge, or discard this patch.

		@@ -1,10 +1,10 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * @package CleverStyle CMS
4		- * @author Nazar Mokrynskyi <[email protected]>
5		- * @copyright Copyright (c) 2013-2016, Nazar Mokrynskyi
6		- * @license MIT License, see license.txt
7		- */
	3	+ * @package CleverStyle CMS
	4	+ * @author Nazar Mokrynskyi <[email protected]>
	5	+ * @copyright Copyright (c) 2013-2016, Nazar Mokrynskyi
	6	+ * @license MIT License, see license.txt
	7	+ */
8	8	namespace cs\CRUD;
9	9	use
10	10	cs\Event,

		@@ -61,7 +61,7 @@ discard block
		block discarded – undo
61	61	'aliases' => &$aliases,
62	62	'final_class' => &$next_alias
63	63	];
64		- $classes = defined('CUSTOM') ? glob(CUSTOM.'/classes/'.substr($class, 2).'_*.php') : [];
	64	+ $classes = defined('CUSTOM') ? glob(CUSTOM.'/classes/'.substr($class, 2).'_*.php') : [];
65	65	foreach ($classes as $custom_class) {
66	66	// Path to file with customized class
67	67	$custom_class = str_replace(CUSTOM.'/classes/', '', substr($custom_class, 0, -4));
		@@ -74,7 +74,7 @@ discard block
		block discarded – undo
74	74	'alias' => "cs\\custom\\$_custom_class",
75	75	'path' => $custom_class
76	76	];
77		- $next_alias = "cs\\custom\\$custom_class";
	77	+ $next_alias = "cs\\custom\\$custom_class";
78	78	}
79	79	modified_classes($modified_classes);
80	80	}

		@@ -54,8 +54,7 @@
		block discarded – undo
54	54	*
55	55	* @throws ExitException
56	56	*/
57		- function init ($server, $query, $data, $files, $data_stream, $cookie, $request_started) {
58		- ++static::$id;
	57	+ function init ($server, $query, $data, $files, $data_stream, $cookie, $request_started) {++static::$id;
59	58	$this->init_server($server);
60	59	$this->init_query($query);
61	60	$this->init_data_and_files($data, $files, $data_stream);

		@@ -1,11 +1,11 @@ discard block
		block discarded – undo
1	1	<?php
2	2	/**
3		- * @package OAuth2
4		- * @category modules
5		- * @author Nazar Mokrynskyi <[email protected]>
6		- * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
7		- * @license MIT License, see license.txt
8		- */
	3	+ * @package OAuth2
	4	+ * @category modules
	5	+ * @author Nazar Mokrynskyi <[email protected]>
	6	+ * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
	7	+ * @license MIT License, see license.txt
	8	+ */
9	9	namespace cs\modules\OAuth2;
10	10
11	11	use
		@@ -20,8 +20,8 @@ discard block
		block discarded – undo
20	20	->header('pragma', 'no-cache');
21	21	interface_off();
22	22	/**
23		- * Errors processing
24		- */
	23	+ * Errors processing
	24	+ */
25	25	$Config = Config::instance();
26	26	$Page = Page::instance();
27	27	if (!isset($_POST['grant_type'])) {
		@@ -141,8 +141,8 @@ discard block
		block discarded – undo
141	141	throw $e;
142	142	}
143	143	/**
144		- * Tokens operations processing
145		- */
	144	+ * Tokens operations processing
	145	+ */
146	146	switch ($_POST['grant_type']) {
147	147	case 'authorization_code':
148	148	if (!isset($_POST['code'])) {

		@@ -1,11 +1,11 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * @package CleverStyle CMS
4		- * @subpackage DarkEnergy theme
5		- * @author Nazar Mokrynskyi <[email protected]>
6		- * @copyright Copyright (c) 2014-2016, Nazar Mokrynskyi
7		- * @license MIT License, see license.txt
8		- */
	3	+ * @package CleverStyle CMS
	4	+ * @subpackage DarkEnergy theme
	5	+ * @author Nazar Mokrynskyi <[email protected]>
	6	+ * @copyright Copyright (c) 2014-2016, Nazar Mokrynskyi
	7	+ * @license MIT License, see license.txt
	8	+ */
9	9	namespace cs;
10	10	$Page = Page::instance();
11	11	if (preg_match('/msie\|trident/i', Request::instance()->user_agent)) {

nazar-pc / CleverStyle-Framework

Push — master ( 7710e6...19a091 )

Status

Category

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch