cs\modules\Blogs\api\Controller\admin

Complexity

Total Complexity

17

Size/Duplication

Total Lines	101
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	6

Importance

Changes	3
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	admin___get_settings()	0	10	1
A	admin___save_settings()	0	9	3
A	admin_sections_get()	0	3	1
A	admin_sections_post()	0	16	3
B	admin_sections_put()	0	14	5
A	admin_sections_delete()	0	13	4

<?php
/**
 * @package   Blogs
 * @category  modules
 * @author    Nazar Mokrynskyi <nazar@mokrynskyi.com>
 * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
 * @license   MIT License, see license.txt
 */
namespace cs\modules\Blogs\api\Controller;
use
	cs\Config,
	cs\ExitException,
	cs\Language,
	cs\modules\Blogs\Sections;

trait admin {
	static function admin___get_settings () {
		$module_data = Config::instance()->module('Blogs');
		return [
			'posts_per_page'                => $module_data->posts_per_page,
			'max_sections'                  => $module_data->max_sections,
			'enable_comments'               => $module_data->enable_comments,
			'new_posts_only_from_admins'    => $module_data->new_posts_only_from_admins,
			'allow_iframes_without_content' => $module_data->allow_iframes_without_content
		];
	}
	/**
	 * @param \cs\Request $Request
	 *
	 * @throws ExitException
	 */
	static function admin___save_settings ($Request) {
		$data = $Request->data('posts_per_page', 'max_sections', 'enable_comments', 'new_posts_only_from_admins', 'allow_iframes_without_content');
		if (!$data) {
			throw new ExitException(400);
		}
		if (!Config::instance()->module('Blogs')->set($data)) {
			throw new ExitException(500);
		}
	}
	/**
	 * @param \cs\Request $Request
	 *
	 * @return array
	 *
	 * @throws ExitException
	 */
	static function admin_sections_get ($Request) {
		return static::sections_get($Request);

The method sections_get() does not exist on cs\modules\Blogs\api\Controller\admin. Did you maybe mean admin_sections_get()?

	}
	/**
	 * @param \cs\Request  $Request
	 * @param \cs\Response $Response
	 *
	 * @return array

Consider making the return type a bit more specific; maybe use array<string,integer|string>.

	 *
	 * @throws ExitException
	 */
	static function admin_sections_post ($Request, $Response) {
		$data = $Request->data('title', 'path', 'parent');
		if (!$data) {
			throw new ExitException(400);
		}
		$Sections = Sections::instance();
		$id       = $Sections->add($data['parent'], $data['title'], $data['path']);
		if (!$id) {
			throw new ExitException(Language::instance()->blogs_changes_save_error, 500);
		}
		$Response->code = 201;
		return [
			'id'  => $id,
			'url' => Config::instance()->base_url().'/Blogs/section/'.$Sections->get($id)['full_path']
		];
	}
	/**
	 * @param \cs\Request $Request
	 *
	 * @return array

Should the return type not be array|null? Also, consider making the array more specific, something like array<String>, or String[].

	 *
	 * @throws ExitException
	 */
	static function admin_sections_put ($Request) {
		$id   = $Request->route_ids(0);
		$data = $Request->data('title', 'path', 'parent');
		if (!$id || !$data) {
			throw new ExitException(400);
		}
		$Sections = Sections::instance();
		if (!$Sections->get($id)) {
			throw new ExitException(404);
		}
		if (!$Sections->set($id, $data['parent'], $data['title'], $data['path'])) {
			throw new ExitException(Language::instance()->blogs_changes_save_error, 500);
		}
	}
	/**
	 * @param \cs\Request $Request
	 *
	 * @return array

Should the return type not be array|null? Also, consider making the array more specific, something like array<String>, or String[].

	 *
	 * @throws ExitException
	 */
	static function admin_sections_delete ($Request) {
		$id = $Request->route_ids(0);
		if (!$id) {
			throw new ExitException(400);
		}
		$Sections = Sections::instance();
		if (!$Sections->get($id)) {
			throw new ExitException(404);
		}
		if (!$Sections->del($id)) {
			throw new ExitException(Language::instance()->blogs_changes_save_error, 500);
		}
	}
}