Complex classes like Route often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Route, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
25 | trait Route { |
||
26 | use |
||
27 | Static_files; |
||
28 | /** |
||
29 | * Current mirror according to configuration |
||
30 | * |
||
31 | * @var int |
||
32 | */ |
||
33 | public $mirror_index; |
||
34 | /** |
||
35 | * Normalized processed representation of relative address, may differ from raw, should be used in most cases |
||
36 | * |
||
37 | * @var string |
||
38 | */ |
||
39 | public $path_normalized; |
||
40 | /** |
||
41 | * Contains parsed route of current page url in form of array without module name and prefixes `admin|api` |
||
42 | * |
||
43 | * @var array |
||
44 | */ |
||
45 | public $route; |
||
46 | /** |
||
47 | * Like `$route` property, but excludes numerical items |
||
48 | * |
||
49 | * @var string[] |
||
50 | */ |
||
51 | public $route_path; |
||
52 | /** |
||
53 | * Like `$route` property, but only includes numerical items (opposite to route_path property) |
||
54 | * |
||
55 | * @var int[] |
||
56 | */ |
||
57 | public $route_ids; |
||
58 | /** |
||
59 | * Request to administration section |
||
60 | * |
||
61 | * @var bool |
||
62 | */ |
||
63 | public $admin_path; |
||
64 | /** |
||
65 | * Request to CLI interface |
||
66 | * |
||
67 | * @var bool |
||
68 | */ |
||
69 | public $cli_path; |
||
70 | /** |
||
71 | * Request to api section |
||
72 | * |
||
73 | * @var bool |
||
74 | */ |
||
75 | public $api_path; |
||
76 | /** |
||
77 | * Current module |
||
78 | * |
||
79 | * @var string |
||
80 | */ |
||
81 | public $current_module; |
||
82 | /** |
||
83 | * Home page |
||
84 | * |
||
85 | * @var bool |
||
86 | */ |
||
87 | public $home_page; |
||
88 | /** |
||
89 | * Initialize route based on system configuration, requires `::init_server()` being called first since uses its data |
||
90 | * |
||
91 | * @throws ExitException |
||
92 | */ |
||
93 | 30 | public function init_route () { |
|
132 | /** |
||
133 | * @param Config $Config |
||
134 | * |
||
135 | * @return int |
||
136 | */ |
||
137 | 28 | protected function determine_current_mirror_index ($Config) { |
|
153 | /** |
||
154 | * Process raw relative route. |
||
155 | * |
||
156 | * As result returns current route in system in form of array, normalized path, detects module path points to, whether this is API call, administration |
||
157 | * page, or home page whether this is API call, admin page, or home page |
||
158 | * |
||
159 | * @param string $path |
||
160 | * |
||
161 | * @return array Array contains next elements: `route`, `path_normalized`, `cli_path`, `admin_path`, `api_path`, `current_module`, `home_page` |
||
162 | */ |
||
163 | 30 | public function analyze_route_path ($path) { |
|
164 | 30 | $route = trim($path, '/'); |
|
165 | 30 | Event::instance()->fire( |
|
166 | 30 | 'System/Request/routing_replace/before', |
|
167 | [ |
||
168 | 30 | 'rc' => &$route |
|
169 | ] |
||
170 | ); |
||
171 | 28 | if (Language::instance()->url_language($route)) { |
|
172 | 2 | $route = explode('/', $route, 2); |
|
173 | 2 | $route = isset($route[1]) ? $route[1] : ''; |
|
174 | } |
||
175 | /** |
||
176 | * Obtaining page path in form of array |
||
177 | */ |
||
178 | 28 | $route = $route ? explode('/', $route) : []; |
|
179 | 28 | $cli_path = ''; |
|
180 | 28 | $admin_path = ''; |
|
181 | 28 | $api_path = ''; |
|
182 | 28 | $home_page = false; |
|
183 | /** |
||
184 | * If url is cli, admin or API page - set corresponding variables to corresponding path prefix |
||
185 | */ |
||
186 | 28 | if ($this->cli && @mb_strtolower($route[0]) == 'cli') { |
|
187 | 2 | $cli_path = 'cli/'; |
|
188 | 2 | array_shift($route); |
|
189 | 28 | } elseif (@mb_strtolower($route[0]) == 'admin') { |
|
190 | 4 | $admin_path = 'admin/'; |
|
191 | 4 | array_shift($route); |
|
192 | 26 | } elseif (@mb_strtolower($route[0]) == 'api') { |
|
193 | 6 | $api_path = 'api/'; |
|
194 | 6 | array_shift($route); |
|
195 | } |
||
196 | /** |
||
197 | * Module detection |
||
198 | */ |
||
199 | 28 | $current_module = $this->determine_page_module($route, $home_page, $cli_path, $admin_path, $api_path); |
|
200 | 28 | list($route_path, $route_ids) = $this->split_route($route); |
|
201 | 28 | $rc = implode('/', $route); |
|
202 | 28 | $old_rc = $rc; |
|
203 | 28 | $old_route = $route; |
|
204 | 28 | $old_route_path = $route_path; |
|
205 | 28 | $old_route_ids = $route_ids; |
|
206 | 28 | Event::instance()->fire( |
|
207 | 28 | 'System/Request/routing_replace/after', |
|
208 | [ |
||
209 | 28 | 'rc' => &$rc, // TODO: Deprecated key, remove in 6.x |
|
210 | 28 | 'route' => &$route, |
|
211 | 28 | 'route_path' => &$route_path, |
|
212 | 28 | 'route_ids' => &$route_ids, |
|
213 | 28 | 'cli_path' => &$cli_path, |
|
214 | 28 | 'admin_path' => &$admin_path, |
|
215 | 28 | 'api_path' => &$api_path, |
|
216 | 28 | 'regular_path' => !($cli_path || $admin_path || $api_path), |
|
217 | 28 | 'current_module' => &$current_module, |
|
218 | 28 | 'home_page' => &$home_page |
|
219 | ] |
||
220 | ); |
||
221 | // TODO: Deprecated, remove in 6.x |
||
222 | 28 | if ($rc != $old_rc) { |
|
223 | $route = explode('/', $rc); |
||
224 | list($route_path, $route_ids) = $this->split_route($route); |
||
225 | } |
||
226 | 28 | if ($route != $old_route && $route_path == $old_route_path && $route_ids == $old_route_ids) { |
|
227 | 2 | list($route_path, $route_ids) = $this->split_route($route); |
|
228 | } |
||
229 | return [ |
||
230 | 28 | 'route' => $route, |
|
231 | 28 | 'route_path' => $route_path, |
|
232 | 28 | 'route_ids' => $route_ids, |
|
233 | 28 | 'path_normalized' => trim( |
|
234 | 28 | "$cli_path$admin_path$api_path$current_module/$rc", |
|
235 | 28 | '/' |
|
236 | ), |
||
237 | 28 | 'cli_path' => (bool)$cli_path, |
|
238 | 28 | 'admin_path' => (bool)$admin_path, |
|
239 | 28 | 'api_path' => (bool)$api_path, |
|
240 | 28 | 'current_module' => $current_module, |
|
241 | 28 | 'home_page' => $home_page |
|
242 | ]; |
||
243 | } |
||
244 | /** |
||
245 | * @param array $route |
||
246 | * |
||
247 | * @return array[] Key `0` contains array of paths, key `1` contains array of identifiers |
||
248 | */ |
||
249 | 28 | protected function split_route ($route) { |
|
264 | /** |
||
265 | * @param Config $Config |
||
266 | * @param string $path_normalized |
||
267 | * |
||
268 | * @throws ExitException |
||
269 | */ |
||
270 | 28 | protected function handle_redirect ($Config, $path_normalized) { |
|
286 | /** |
||
287 | * Check whether referer is local |
||
288 | * |
||
289 | * @param Config $Config |
||
290 | * |
||
291 | * @return bool |
||
292 | */ |
||
293 | 2 | protected function is_referer_local ($Config) { |
|
312 | /** |
||
313 | * Determine module of current page based on page path and system configuration |
||
314 | * |
||
315 | * @param array $rc |
||
316 | * @param bool $home_page |
||
317 | * @param string $cli_path |
||
318 | * @param string $admin_path |
||
319 | * @param string $api_path |
||
320 | * |
||
321 | * @return string |
||
322 | */ |
||
323 | 28 | protected function determine_page_module (&$rc, &$home_page, $cli_path, $admin_path, $api_path) { |
|
347 | /** |
||
348 | * Get array of modules |
||
349 | * |
||
350 | * @param Config $Config |
||
351 | * @param bool $admin_path |
||
352 | * |
||
353 | * @return string[] |
||
354 | */ |
||
355 | 28 | protected function get_modules ($Config, $admin_path) { |
|
372 | /** |
||
373 | * Get route part by index |
||
374 | * |
||
375 | * @param int $index |
||
376 | * |
||
377 | * @return int|null|string |
||
378 | */ |
||
379 | 2 | public function route ($index) { |
|
382 | /** |
||
383 | * Get route path part by index |
||
384 | * |
||
385 | * @param int $index |
||
386 | * |
||
387 | * @return null|string |
||
388 | */ |
||
389 | 2 | public function route_path ($index) { |
|
392 | /** |
||
393 | * Get route ids part by index |
||
394 | * |
||
395 | * @param int $index |
||
396 | * |
||
397 | * @return int|null |
||
398 | */ |
||
399 | 2 | public function route_ids ($index) { |
|
402 | } |
||
403 |