CLI::print_cli_structure_internal() - Code Metrics - Inspection of "Few traits decoupled from `cs\App\Router`" - nazar-pc/CleverStyle-Framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 62549b...430ab9 )

by Nazar

created 2016-04-16 08:45 UTC

CLI::print_cli_structure_internal() C

↳ Parent: CLI

Complexity

Conditions	11
Paths	25

Size

Total Lines	26
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	26
rs	5.2653
cc	11
eloc	19
nc	25
nop	5

How to fix Complexity

<?php
/**
 * @package   CleverStyle CMS
 * @author    Nazar Mokrynskyi <[email protected]>
 * @copyright Copyright (c) 2015-2016, Nazar Mokrynskyi
 * @license   MIT License, see license.txt
 */
namespace cs\App\Router;
use
	cli\Table,
	cs\Config,
	cs\Config\Module_Properties,
	cs\Page;

trait CLI {
	protected function print_cli_structure ($path) {
		$Config = Config::instance();
		$result = [];
		foreach ($Config->components['modules'] as $module_name => $data) {
			if ($data['active'] == Module_Properties::ENABLED) {
				$working_dir = MODULES."/$module_name/cli";
				$structure   = file_exists("$working_dir/index.json") ? file_get_json("$working_dir/index.json") : [];
				$this->print_cli_structure_internal($working_dir, $module_name, '', $structure, $result[$module_name]);
			}
		}
		$result = $this->print_cli_structure_normalize_result($result);
		$Page   = Page::instance();
		// Cut `/cli/` prefix
		$path = substr($path, 5);
		if ($path) {
			$Page->content("%yPaths and methods for \"$path\":%n\n");
			$result = array_filter(
				$result,
				function ($item) use ($path) {
					return strpos($item[0], $path) === 0;
				}
			);
		} else {
			$Page->content("%yAll paths and methods:%n\n");
		}
		$Page->content(
			implode("\n", (new Table(['Path', 'Methods available'], $result))->getDisplayLines())."\n"
		);
	}
	/**
	 * @param string $dir
	 * @param string $module_name
	 * @param string $basename
	 * @param array  $structure
	 * @param array  $result
	 */
	protected function print_cli_structure_internal ($dir, $module_name, $basename, $structure, &$result) {
		/** @noinspection NestedTernaryOperatorInspection */
		foreach ($structure ?: (!$basename ? ['index'] : []) as $path => $nested_structure) {
			if (!is_array($nested_structure)) {
				$path             = $nested_structure;
				$nested_structure = [];
			}
			$key = $path == '_' ? 0 : $path;
			if (file_exists("$dir/Controller.php")) {
				$result[$key] = $this->controller_router_available_methods(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
					$dir,
					"\\cs\\modules\\$module_name\\cli\\Controller",
					$basename ? $basename.'_'.$path : $path
				);
				$new_dir      = $dir;
				$new_basename = $basename ? $basename.'_'.$path : $path;
			} else {
				$result[$key] = $this->files_router_available_methods($dir, $path);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
				$new_dir      = "$dir/$path";
				$new_basename = $basename;
			}
			if ($structure && $nested_structure) {
				$this->print_cli_structure_internal($new_dir, $module_name, $new_basename, $nested_structure, $result[$key]);
			}
		}
	}
	/**
	 * @param array  $result
	 * @param string $prefix
	 *
	 * @return string[]
	 */
	protected function print_cli_structure_normalize_result ($result, $prefix = '') {
		$normalized = [];
		foreach ($result as $key => $value) {
			if (is_array_assoc($value)) {
				if (!$prefix && isset($value['index'])) {
					$value[0] = $value['index'];
					unset($value['index']);
				}
				if (is_array(@$value[0]) && $value[0]) {
					$normalized[] = [$prefix.$key, strtolower(implode(', ', $value[0]))];
				}
				unset($value[0]);
				/** @noinspection SlowArrayOperationsInLoopInspection */
				$normalized = array_merge($normalized, $this->print_cli_structure_normalize_result($value, $prefix.$key.'/'));
			} elseif (is_array($value) && $value) {
				$normalized[] = [$prefix.$key, strtolower(implode(', ', $value))];
			}
		}
		return $normalized;
	}
}


1			<?php
2			/**
3			* @package CleverStyle CMS
4			* @author Nazar Mokrynskyi <[email protected]>
5			* @copyright Copyright (c) 2015-2016, Nazar Mokrynskyi
6			* @license MIT License, see license.txt
7			*/
8			namespace cs\App\Router;
9			use
10			cli\Table,
11			cs\Config,
12			cs\Config\Module_Properties,
13			cs\Page;
14
15			trait CLI {
16			protected function print_cli_structure ($path) {
17			$Config = Config::instance();
18			$result = [];
19			foreach ($Config->components['modules'] as $module_name => $data) {
20			if ($data['active'] == Module_Properties::ENABLED) {
21			$working_dir = MODULES."/$module_name/cli";
22			$structure = file_exists("$working_dir/index.json") ? file_get_json("$working_dir/index.json") : [];
23			$this->print_cli_structure_internal($working_dir, $module_name, '', $structure, $result[$module_name]);
24			}
25			}
26			$result = $this->print_cli_structure_normalize_result($result);
27			$Page = Page::instance();
28			// Cut `/cli/` prefix
29			$path = substr($path, 5);
30			if ($path) {
31			$Page->content("%yPaths and methods for \"$path\":%n\n");
32			$result = array_filter(
33			$result,
34			function ($item) use ($path) {
35			return strpos($item[0], $path) === 0;
36			}
37			);
38			} else {
39			$Page->content("%yAll paths and methods:%n\n");
40			}
41			$Page->content(
42			implode("\n", (new Table(['Path', 'Methods available'], $result))->getDisplayLines())."\n"
43			);
44			}
45			/**
46			* @param string $dir
47			* @param string $module_name
48			* @param string $basename
49			* @param array $structure
50			* @param array $result
51			*/
52			protected function print_cli_structure_internal ($dir, $module_name, $basename, $structure, &$result) {
53			/** @noinspection NestedTernaryOperatorInspection */
54			foreach ($structure ?: (!$basename ? ['index'] : []) as $path => $nested_structure) {
55			if (!is_array($nested_structure)) {
56			$path = $nested_structure;
57			$nested_structure = [];
58			}
59			$key = $path == '_' ? 0 : $path;
60			if (file_exists("$dir/Controller.php")) {
61			$result[$key] = $this->controller_router_available_methods(
			1 ignored issue – show Bug introduced 2016-04-16 08:49 UTC by Report Bug Copy Issue Report It seems like `controller_router_available_methods()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
62			$dir,
63			"\\cs\\modules\\$module_name\\cli\\Controller",
64			$basename ? $basename.'_'.$path : $path
65			);
66			$new_dir = $dir;
67			$new_basename = $basename ? $basename.'_'.$path : $path;
68			} else {
69			$result[$key] = $this->files_router_available_methods($dir, $path);
			1 ignored issue – show Bug introduced 2016-04-16 08:49 UTC by Report Bug Copy Issue Report It seems like `files_router_available_methods()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
70			$new_dir = "$dir/$path";
71			$new_basename = $basename;
72			}
73			if ($structure && $nested_structure) {
74			$this->print_cli_structure_internal($new_dir, $module_name, $new_basename, $nested_structure, $result[$key]);
75			}
76			}
77			}
78			/**
79			* @param array $result
80			* @param string $prefix
81			*
82			* @return string[]
83			*/
84			protected function print_cli_structure_normalize_result ($result, $prefix = '') {
85			$normalized = [];
86			foreach ($result as $key => $value) {
87			if (is_array_assoc($value)) {
88			if (!$prefix && isset($value['index'])) {
89			$value[0] = $value['index'];
90			unset($value['index']);
91			}
92			if (is_array(@$value[0]) && $value[0]) {
93			$normalized[] = [$prefix.$key, strtolower(implode(', ', $value[0]))];
94			}
95			unset($value[0]);
96			/** @noinspection SlowArrayOperationsInLoopInspection */
97			$normalized = array_merge($normalized, $this->print_cli_structure_normalize_result($value, $prefix.$key.'/'));
98			} elseif (is_array($value) && $value) {
99			$normalized[] = [$prefix.$key, strtolower(implode(', ', $value))];
100			}
101			}
102			return $normalized;
103			}
104			}
105

nazar-pc / CleverStyle-Framework

Push — master ( 62549b...430ab9 )

CLI::print_cli_structure_internal() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like