Inspection of "Many deprecated features were dropped, moving to 4..." - nazar-pc/CleverStyle-Framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b29ef1...890497 )

by Nazar

created 2016-03-27 11:18 UTC

Status

Indentation +26 added lines, -26 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@  discard block
 block discarded – undo
 <?php
 /**
- * @package   Blogs
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Blogs
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\modules\Blogs;
 use
 	cs\Config,
@@ -27,61 +27,61 @@  discard block
 block discarded – undo
 $Tags   = Tags::instance();
 $Route  = Route::instance();
 /**
- * If no tag specified
- */
+	 * If no tag specified
+	 */
 if (!isset($Route->route[1])) {
 	throw new ExitException(404);
 }
 /**
- * Find tag
- */
+	 * Find tag
+	 */
 $tag = $Tags->get_by_text($Route->route[1]);
 if (!$tag) {
 	throw new ExitException(404);
 }
 $tag = $Tags->get($tag);
 /**
- * Add tag to page title
- */
+	 * Add tag to page title
+	 */
 $Page
 	->title($tag['text']);
 /**
- * Now add link to Atom feed for posts with current tag only
- */
+	 * Now add link to Atom feed for posts with current tag only
+	 */
 $Page->atom(
 	"Blogs/atom.xml/?tag=$tag[id]",
 	implode($Config->core['title_delimiter'], [$L->latest_posts, $L->tag, $tag['text']])
 );
 /**
- * Set page of blog type (Open Graph protocol)
- */
+	 * Set page of blog type (Open Graph protocol)
+	 */
 $Meta->blog();
 /**
- * Determine current page
- */
+	 * Determine current page
+	 */
 $page = max(
 	isset($Route->route[2]) ? $Route->route[2] : 1,
 	1
 );
 /**
- * If this is not first page - show that in page title
- */
+	 * If this is not first page - show that in page title
+	 */
 if ($page > 1) {
 	$Page->title($L->blogs_nav_page($page));
 }
 /**
- * Get posts for current page in JSON-LD structure format
- */
+	 * Get posts for current page in JSON-LD structure format
+	 */
 $posts_per_page = $Config->module('Blogs')->posts_per_page;
 $posts          = $Posts->get_for_tag($tag['id'], $L->clang, $page, $posts_per_page);
 $posts_count    = $Posts->get_for_tag_count($tag['id'], $L->clang);
 /**
- * Base url (without page number)
- */
+	 * Base url (without page number)
+	 */
 $base_url = $Config->base_url().'/'.path($L->Blogs).'/'.path($L->tag).'/'.$Route->route[1];
 /**
- * Render posts page
- */
+	 * Render posts page
+	 */
 Helpers::show_posts_list(
 	$posts,
 	$posts_count,

Please login to merge, or discard this patch.

components/modules/Blogs/latest_posts.php 1 patch

Indentation +22 added lines, -22 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@  discard block
 block discarded – undo
 <?php
 /**
- * @package   Blogs
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Blogs
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\modules\Blogs;
 use
 	cs\Config,
@@ -25,42 +25,42 @@  discard block
 block discarded – undo
 $Posts  = Posts::instance();
 $Route  = Route::instance();
 /**
- * Page title
- */
+	 * Page title
+	 */
 $Page->title($L->latest_posts);
 /**
- * Now add link to Atom feed for latest posts
- */
+	 * Now add link to Atom feed for latest posts
+	 */
 $Page->atom('Blogs/atom.xml', $L->latest_posts);
 /**
- * Set page of blog type (Open Graph protocol)
- */
+	 * Set page of blog type (Open Graph protocol)
+	 */
 $Meta->blog();
 /**
- * Determine current page
- */
+	 * Determine current page
+	 */
 $page = max(
 	isset($Route->ids[0]) ? array_slice($Route->ids, -1)[0] : 1,
 	1
 );
 /**
- * If this is not first page - show that in page title
- */
+	 * If this is not first page - show that in page title
+	 */
 if ($page > 1) {
 	$Page->title($L->blogs_nav_page($page));
 }
 /**
- * Get posts for current page in JSON-LD structure format
- */
+	 * Get posts for current page in JSON-LD structure format
+	 */
 $posts_per_page = $Config->module('Blogs')->posts_per_page;
 $posts          = $Posts->get_latest_posts($page, $posts_per_page);
 /**
- * Base url (without page number)
- */
+	 * Base url (without page number)
+	 */
 $base_url = $Config->base_url().'/'.path($L->Blogs).'/'.path($L->latest_posts);
 /**
- * Render posts page
- */
+	 * Render posts page
+	 */
 Helpers::show_posts_list(
 	$posts,
 	$Posts->get_total_count(),

Please login to merge, or discard this patch.

components/modules/Blogs/atom.xml.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   Blogs
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2015-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Blogs
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2015-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\modules\Blogs;
 use
 	h,

Please login to merge, or discard this patch.

components/modules/Blogs/prepare.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   Blogs
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Blogs
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\modules\Blogs;
 use
 	cs\Language;

Please login to merge, or discard this patch.

components/modules/Blogs/drafts.php 1 patch

Indentation +16 added lines, -16 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@  discard block
 block discarded – undo
 <?php
 /**
- * @package   Blogs
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Blogs
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\modules\Blogs;
 use
 	cs\Config,
@@ -26,31 +26,31 @@  discard block
 block discarded – undo
 $User   = User::instance();
 $Page->title($L->drafts);
 /**
- * Determine current page
- */
+	 * Determine current page
+	 */
 $page = max(
 	isset($Route->ids[0]) ? array_slice($Route->ids, -1)[0] : 1,
 	1
 );
 /**
- * If this is not first page - show that in page title
- */
+	 * If this is not first page - show that in page title
+	 */
 if ($page > 1) {
 	$Page->title($L->blogs_nav_page($page));
 }
 /**
- * Get posts for current page in JSON-LD structure format
- */
+	 * Get posts for current page in JSON-LD structure format
+	 */
 $posts_per_page = $Config->module('Blogs')->posts_per_page;
 $posts          = $Posts->get_drafts($User->id, $page, $posts_per_page);
 $posts_count    = $Posts->get_drafts_count($User->id);
 /**
- * Base url (without page number)
- */
+	 * Base url (without page number)
+	 */
 $base_url = $Config->base_url().'/'.path($L->Blogs).'/'.path($L->drafts);
 /**
- * Render posts page
- */
+	 * Render posts page
+	 */
 Helpers::show_posts_list(
 	$posts,
 	$posts_count,

Please login to merge, or discard this patch.

components/plugins/Json_ld/Json_ld.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   Json_ld
- * @category  plugins
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2015-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Json_ld
+	 * @category  plugins
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2015-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 
 namespace cs\plugins\Json_ld;
 use

Please login to merge, or discard this patch.

components/plugins/Composer_assets/Assets_processing.php 2 patches

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   Composer assets
- * @category  plugins
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2015-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Composer assets
+	 * @category  plugins
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2015-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\plugins\Composer_assets;
 use
 	Exception,

Please login to merge, or discard this patch.

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -88,7 +88,7 @@
 block discarded – undo
 <FilesMatch "\.css$">
 	Header set Content-Type text/css
 </FilesMatch>
-HTACCESS
+htaccess
 			);
 		}
 		foreach ($files as $file) {

Please login to merge, or discard this patch.

components/plugins/Tags/Tags.php 1 patch

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -1,22 +1,22 @@
 block discarded – undo
 <?php
 /**
- * @package   Tags
- * @category  plugins
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2015-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Tags
+	 * @category  plugins
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2015-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\plugins\Tags;
 use
 	cs\DB\Accessor;
 /**
- * Tags trait
- *
- * Provides methods for working with tags for faster development
- *
- * @property \cs\Cache\Prefix $cache
- * @property string           $table
- */
+	 * Tags trait
+	 *
+	 * Provides methods for working with tags for faster development
+	 *
+	 * @property \cs\Cache\Prefix $cache
+	 * @property string           $table
+	 */
 trait Tags {
 	use
 		Accessor;

Please login to merge, or discard this patch.

install/functions.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package    CleverStyle CMS
- * @subpackage Installer
- * @author     Nazar Mokrynskyi <[email protected]>
- * @copyright  Copyright (c) 2011-2016, Nazar Mokrynskyi
- * @license    MIT License, see license.txt
- */
+	 * @package    CleverStyle CMS
+	 * @subpackage Installer
+	 * @author     Nazar Mokrynskyi <[email protected]>
+	 * @copyright  Copyright (c) 2011-2016, Nazar Mokrynskyi
+	 * @license    MIT License, see license.txt
+	 */
 function install_form () {
 	$timezones = get_timezones_list();
 	return h::{'form[method=post]'}(

Please login to merge, or discard this patch.

		@@ -1,11 +1,11 @@ discard block
		block discarded – undo
1	1	<?php
2	2	/**
3		- * @package Blogs
4		- * @category modules
5		- * @author Nazar Mokrynskyi <[email protected]>
6		- * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
7		- * @license MIT License, see license.txt
8		- */
	3	+ * @package Blogs
	4	+ * @category modules
	5	+ * @author Nazar Mokrynskyi <[email protected]>
	6	+ * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
	7	+ * @license MIT License, see license.txt
	8	+ */
9	9	namespace cs\modules\Blogs;
10	10	use
11	11	cs\Config,
		@@ -27,61 +27,61 @@ discard block
		block discarded – undo
27	27	$Tags = Tags::instance();
28	28	$Route = Route::instance();
29	29	/**
30		- * If no tag specified
31		- */
	30	+ * If no tag specified
	31	+ */
32	32	if (!isset($Route->route[1])) {
33	33	throw new ExitException(404);
34	34	}
35	35	/**
36		- * Find tag
37		- */
	36	+ * Find tag
	37	+ */
38	38	$tag = $Tags->get_by_text($Route->route[1]);
39	39	if (!$tag) {
40	40	throw new ExitException(404);
41	41	}
42	42	$tag = $Tags->get($tag);
43	43	/**
44		- * Add tag to page title
45		- */
	44	+ * Add tag to page title
	45	+ */
46	46	$Page
47	47	->title($tag['text']);
48	48	/**
49		- * Now add link to Atom feed for posts with current tag only
50		- */
	49	+ * Now add link to Atom feed for posts with current tag only
	50	+ */
51	51	$Page->atom(
52	52	"Blogs/atom.xml/?tag=$tag[id]",
53	53	implode($Config->core['title_delimiter'], [$L->latest_posts, $L->tag, $tag['text']])
54	54	);
55	55	/**
56		- * Set page of blog type (Open Graph protocol)
57		- */
	56	+ * Set page of blog type (Open Graph protocol)
	57	+ */
58	58	$Meta->blog();
59	59	/**
60		- * Determine current page
61		- */
	60	+ * Determine current page
	61	+ */
62	62	$page = max(
63	63	isset($Route->route[2]) ? $Route->route[2] : 1,
64	64	1
65	65	);
66	66	/**
67		- * If this is not first page - show that in page title
68		- */
	67	+ * If this is not first page - show that in page title
	68	+ */
69	69	if ($page > 1) {
70	70	$Page->title($L->blogs_nav_page($page));
71	71	}
72	72	/**
73		- * Get posts for current page in JSON-LD structure format
74		- */
	73	+ * Get posts for current page in JSON-LD structure format
	74	+ */
75	75	$posts_per_page = $Config->module('Blogs')->posts_per_page;
76	76	$posts = $Posts->get_for_tag($tag['id'], $L->clang, $page, $posts_per_page);
77	77	$posts_count = $Posts->get_for_tag_count($tag['id'], $L->clang);
78	78	/**
79		- * Base url (without page number)
80		- */
	79	+ * Base url (without page number)
	80	+ */
81	81	$base_url = $Config->base_url().'/'.path($L->Blogs).'/'.path($L->tag).'/'.$Route->route[1];
82	82	/**
83		- * Render posts page
84		- */
	83	+ * Render posts page
	84	+ */
85	85	Helpers::show_posts_list(
86	86	$posts,
87	87	$posts_count,

		@@ -1,11 +1,11 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * @package Blogs
4		- * @category modules
5		- * @author Nazar Mokrynskyi <[email protected]>
6		- * @copyright Copyright (c) 2015-2016, Nazar Mokrynskyi
7		- * @license MIT License, see license.txt
8		- */
	3	+ * @package Blogs
	4	+ * @category modules
	5	+ * @author Nazar Mokrynskyi <[email protected]>
	6	+ * @copyright Copyright (c) 2015-2016, Nazar Mokrynskyi
	7	+ * @license MIT License, see license.txt
	8	+ */
9	9	namespace cs\modules\Blogs;
10	10	use
11	11	h,

		@@ -88,7 +88,7 @@
		block discarded – undo
88	88	<FilesMatch "\.css$">
89	89	Header set Content-Type text/css
90	90	</FilesMatch>
91		-HTACCESS
	91	+htaccess
92	92	);
93	93	}
94	94	foreach ($files as $file) {

		@@ -1,22 +1,22 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * @package Tags
4		- * @category plugins
5		- * @author Nazar Mokrynskyi <[email protected]>
6		- * @copyright Copyright (c) 2015-2016, Nazar Mokrynskyi
7		- * @license MIT License, see license.txt
8		- */
	3	+ * @package Tags
	4	+ * @category plugins
	5	+ * @author Nazar Mokrynskyi <[email protected]>
	6	+ * @copyright Copyright (c) 2015-2016, Nazar Mokrynskyi
	7	+ * @license MIT License, see license.txt
	8	+ */
9	9	namespace cs\plugins\Tags;
10	10	use
11	11	cs\DB\Accessor;
12	12	/**
13		- * Tags trait
14		- *
15		- * Provides methods for working with tags for faster development
16		- *
17		- * @property \cs\Cache\Prefix $cache
18		- * @property string $table
19		- */
	13	+ * Tags trait
	14	+ *
	15	+ * Provides methods for working with tags for faster development
	16	+ *
	17	+ * @property \cs\Cache\Prefix $cache
	18	+ * @property string $table
	19	+ */
20	20	trait Tags {
21	21	use
22	22	Accessor;

nazar-pc / CleverStyle-Framework

Push — master ( b29ef1...890497 )

Status

Category

Indentation +26 added lines, -26 removed lines patch added patch discarded remove patch

Indentation +22 added lines, -22 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +16 added lines, -16 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch