Inspection of "Http server module now reuses system functions for..." - nazar-pc/CleverStyle-Framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1ebbbc...a393b8 )

by Nazar

created 2016-03-14 03:30 UTC

Status

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   Http server
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2015-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Http server
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2015-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\modules\Http_server;
 use
 	ArrayAccess,

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -18,7 +18,7 @@  discard block
 block discarded – undo
 	 *
 	 * @return object[]
 	 */
-	function &objects_pool ($update_objects_pool = null) {
+	function &objects_pool($update_objects_pool = null) {
 		static $objects_pool = [];
 		if (is_array($update_objects_pool)) {
 			$objects_pool = $update_objects_pool;
@@ -231,10 +231,10 @@  discard block
 block discarded – undo
 			 * Try to load classes from different places. If not found in one place - try in another.
 			 */
 			if (
-				_require_once($file = DIR."/core/classes/$namespace/$class_name.php", false) ||    //Core classes
+				_require_once($file = DIR."/core/classes/$namespace/$class_name.php", false) || //Core classes
 				_require_once($file = DIR."/core/thirdparty/$namespace/$class_name.php", false) || //Third party classes
-				_require_once($file = DIR."/core/traits/$namespace/$class_name.php", false) ||     //Core traits
-				_require_once($file = ENGINES."/$namespace/$class_name.php", false) ||             //Core engines
+				_require_once($file = DIR."/core/traits/$namespace/$class_name.php", false) || //Core traits
+				_require_once($file = ENGINES."/$namespace/$class_name.php", false) || //Core engines
 				_require_once($file = MODULES."/../$namespace/$class_name.php", false)             //Classes in modules and plugins
 			) {
 				$cache[$class] = realpath($file);

Please login to merge, or discard this patch.

components/modules/Http_server/supervisor.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   Http server
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2015-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Http server
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2015-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\modules\Http_server;
 use
 	ArrayAccess,

Please login to merge, or discard this patch.

components/modules/HybridAuth/admin/providers_list.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   HybridAuth
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2012-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   HybridAuth
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2012-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace	cs;
 Event::instance()->on(
 	'admin/System/components/modules/install/after',

Please login to merge, or discard this patch.

components/modules/HybridAuth/events/enabled/functions.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   HybridAuth
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2012-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   HybridAuth
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2012-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace	cs;
 Event::instance()->on(
 	'admin/System/components/modules/install/after',

Please login to merge, or discard this patch.

components/modules/OAuth2/admin/clients/add.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   OAuth2
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   OAuth2
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs;
 
 Event::instance()

Please login to merge, or discard this patch.

components/modules/OAuth2/admin/clients/edit.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   OAuth2
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   OAuth2
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs;
 
 Event::instance()

Please login to merge, or discard this patch.

components/modules/OAuth2/admin/clients/list.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   OAuth2
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   OAuth2
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs;
 
 Event::instance()

Please login to merge, or discard this patch.

components/modules/OAuth2/events/enabled.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   OAuth2
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   OAuth2
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs;
 
 Event::instance()

Please login to merge, or discard this patch.

components/modules/Photo_gallery/admin/galleries/add.php 2 patches

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   Photo gallery
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2013-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Photo gallery
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2013-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\modules\Photo_gallery;
 use
 	cs\ExitException,

Please login to merge, or discard this patch.

Spacing +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -25,8 +25,7 @@
 block discarded – undo
 			).
 			h::label($L->gallery_title).
 			h::{'input[is=cs-input-text][name=add[title]]'}().
-			($Config->core['simple_admin_mode'] ? '' :
-				h::label(h::info('photo_gallery_gallery_path')).
+			($Config->core['simple_admin_mode'] ? '' : h::label(h::info('photo_gallery_gallery_path')).
 				h::{'input[is=cs-input-text][name=add[path]]'}()
 			).
 			h::label($L->gallery_description).

Please login to merge, or discard this patch.

		@@ -1,11 +1,11 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * @package Http server
4		- * @category modules
5		- * @author Nazar Mokrynskyi <[email protected]>
6		- * @copyright Copyright (c) 2015-2016, Nazar Mokrynskyi
7		- * @license MIT License, see license.txt
8		- */
	3	+ * @package Http server
	4	+ * @category modules
	5	+ * @author Nazar Mokrynskyi <[email protected]>
	6	+ * @copyright Copyright (c) 2015-2016, Nazar Mokrynskyi
	7	+ * @license MIT License, see license.txt
	8	+ */
9	9	namespace cs\modules\Http_server;
10	10	use
11	11	ArrayAccess,

		@@ -18,7 +18,7 @@ discard block
		block discarded – undo
18	18	*
19	19	* @return object[]
20	20	*/
21		- function &objects_pool ($update_objects_pool = null) {
	21	+ function &objects_pool($update_objects_pool = null) {
22	22	static $objects_pool = [];
23	23	if (is_array($update_objects_pool)) {
24	24	$objects_pool = $update_objects_pool;
		@@ -231,10 +231,10 @@ discard block
		block discarded – undo
231	231	* Try to load classes from different places. If not found in one place - try in another.
232	232	*/
233	233	if (
234		- _require_once($file = DIR."/core/classes/$namespace/$class_name.php", false) \|\| //Core classes
	234	+ _require_once($file = DIR."/core/classes/$namespace/$class_name.php", false) \|\| //Core classes
235	235	_require_once($file = DIR."/core/thirdparty/$namespace/$class_name.php", false) \|\| //Third party classes
236		- _require_once($file = DIR."/core/traits/$namespace/$class_name.php", false) \|\| //Core traits
237		- _require_once($file = ENGINES."/$namespace/$class_name.php", false) \|\| //Core engines
	236	+ _require_once($file = DIR."/core/traits/$namespace/$class_name.php", false) \|\| //Core traits
	237	+ _require_once($file = ENGINES."/$namespace/$class_name.php", false) \|\| //Core engines
238	238	_require_once($file = MODULES."/../$namespace/$class_name.php", false) //Classes in modules and plugins
239	239	) {
240	240	$cache[$class] = realpath($file);

		@@ -25,8 +25,7 @@
		block discarded – undo
25	25	).
26	26	h::label($L->gallery_title).
27	27	h::{'input[is=cs-input-text][name=add[title]]'}().
28		- ($Config->core['simple_admin_mode'] ? '' :
29		- h::label(h::info('photo_gallery_gallery_path')).
	28	+ ($Config->core['simple_admin_mode'] ? '' : h::label(h::info('photo_gallery_gallery_path')).
30	29	h::{'input[is=cs-input-text][name=add[path]]'}()
31	30	).
32	31	h::label($L->gallery_description).

nazar-pc / CleverStyle-Framework

Push — master ( 1ebbbc...a393b8 )

Status

Category

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -2 removed lines patch added patch discarded remove patch