Complex classes like Data_and_files often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Data_and_files, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 14 | trait Data_and_files { |
||
| 15 | /** |
||
| 16 | * Data array, similar to `$_POST` |
||
| 17 | * |
||
| 18 | * @var array |
||
| 19 | */ |
||
| 20 | public $data; |
||
| 21 | /** |
||
| 22 | * Normalized files array |
||
| 23 | * |
||
| 24 | * Each file item can be either single file or array of files (in contrast with native PHP arrays where each field like `name` become an array) with keys |
||
| 25 | * `name`, `type`, `size`, `tmp_name`, `stream` and `error` |
||
| 26 | * |
||
| 27 | * `name`, `type`, `size` and `error` keys are similar to native PHP fields in `$_FILES`; `tmp_name` might not be temporary file, but file descriptor |
||
| 28 | * wrapper like `request-file:///file` instead and `stream` is resource like obtained with `fopen('/tmp/xyz', 'rb')` |
||
| 29 | * |
||
| 30 | * @var array[] |
||
| 31 | */ |
||
| 32 | public $files; |
||
| 33 | /** |
||
| 34 | * Data stream resource, similar to `fopen('php://input', 'rb')` |
||
| 35 | * |
||
| 36 | * Make sure you're controlling position in stream where you read something, if code in some other place might seek on this stream |
||
| 37 | * |
||
| 38 | * Stream is read-only |
||
| 39 | * |
||
| 40 | * @var null|resource |
||
| 41 | */ |
||
| 42 | public $data_stream; |
||
| 43 | /** |
||
| 44 | * `$this->init_server()` assumed to be called already |
||
| 45 | * |
||
| 46 | * @param array $data Typically `$_POST` |
||
| 47 | * @param array[] $files Typically `$_FILES`; might be like native PHP array `$_FILES` or normalized; each file item MUST contain keys |
||
| 48 | * `name`, `type`, `size`, `error` and at least one of `tmp_name` or `stream` |
||
| 49 | * @param null|resource|string $data_stream String, like `php://input` or resource, like `fopen('php://input', 'rb')` with request body, will be parsed for |
||
| 50 | * data and files if necessary |
||
| 51 | * @param bool $copy_stream Sometimes data stream can only being read once (like most of times with `php://input`), so it is necessary to |
||
| 52 | * copy it and store its contents for longer period of time |
||
| 53 | * |
||
| 54 | * @throws ExitException |
||
| 55 | */ |
||
| 56 | 52 | public function init_data_and_files ($data = [], $files = [], $data_stream = null, $copy_stream = true) { |
|
| 78 | /** |
||
| 79 | * Get data item by name |
||
| 80 | * |
||
| 81 | * @param string[]|string[][] $name |
||
| 82 | * |
||
| 83 | * @return mixed|mixed[]|null Data items (or associative array of data items) if exists or `null` otherwise (in case if `$name` is an array even one |
||
| 84 | * missing key will cause the whole thing to fail) |
||
| 85 | */ |
||
| 86 | 40 | public function data (...$name) { |
|
| 89 | /** |
||
| 90 | * Get file item by name |
||
| 91 | * |
||
| 92 | * @param string $name |
||
| 93 | * |
||
| 94 | * @return array|null File item if exists or `null` otherwise |
||
| 95 | */ |
||
| 96 | 2 | public function files ($name) { |
|
| 99 | /** |
||
| 100 | * @param array[] $files |
||
| 101 | * @param string $file_path |
||
| 102 | * |
||
| 103 | * @return array[] |
||
| 104 | */ |
||
| 105 | 24 | protected function normalize_files ($files, $file_path = '') { |
|
| 141 | /** |
||
| 142 | * @param array $file |
||
| 143 | * @param string $file_path |
||
| 144 | * |
||
| 145 | * @return array |
||
| 146 | */ |
||
| 147 | 6 | protected function normalize_file ($file, $file_path) { |
|
| 163 | /** |
||
| 164 | * @param null|resource|string $data_stream |
||
| 165 | * @param bool $copy_stream |
||
| 166 | * |
||
| 167 | * @return null|resource |
||
| 168 | */ |
||
| 169 | 24 | protected function prepare_data_stream ($data_stream, $copy_stream) { |
|
| 183 | /** |
||
| 184 | * Parsing request body for following Content-Type: `application/json`, `application/x-www-form-urlencoded` and `multipart/form-data` |
||
| 185 | * |
||
| 186 | * @throws ExitException |
||
| 187 | */ |
||
| 188 | 22 | protected function parse_data_stream () { |
|
| 218 | /** |
||
| 219 | * Parse content stream |
||
| 220 | * |
||
| 221 | * @param resource $stream |
||
| 222 | * @param string $boundary |
||
| 223 | * |
||
| 224 | * @return array[]|false |
||
| 225 | * |
||
| 226 | * @throws UnexpectedValueException |
||
| 227 | * @throws ExitException |
||
| 228 | */ |
||
| 229 | 4 | protected function parse_multipart_into_parts ($stream, $boundary) { |
|
| 298 | /** |
||
| 299 | * @param resource $stream |
||
| 300 | * @param array[] $parts |
||
| 301 | * |
||
| 302 | * @return array[] |
||
| 303 | */ |
||
| 304 | 4 | protected function parse_multipart_analyze_parts ($stream, $parts) { |
|
| 325 | /** |
||
| 326 | * @param array $headers |
||
| 327 | * |
||
| 328 | * @return bool |
||
| 329 | */ |
||
| 330 | 4 | protected function parse_multipart_analyze_parts_is_valid ($headers) { |
|
| 335 | /** |
||
| 336 | * @param array $headers |
||
| 337 | * @param resource $stream |
||
| 338 | * @param int $offset |
||
| 339 | * @param int $size |
||
| 340 | * |
||
| 341 | * @return array |
||
| 342 | */ |
||
| 343 | 4 | protected function parse_multipart_analyze_parts_file ($headers, $stream, $offset, $size) { |
|
| 361 | /** |
||
| 362 | * @param resource $stream |
||
| 363 | * @param int $offset |
||
| 364 | * @param int $size |
||
| 365 | * |
||
| 366 | * @return string |
||
| 367 | */ |
||
| 368 | 4 | protected function parse_multipart_analyze_parts_content ($stream, $offset, $size) { |
|
| 371 | /** |
||
| 372 | * @return int |
||
| 373 | */ |
||
| 374 | 4 | protected function post_max_size () { |
|
| 378 | /** |
||
| 379 | * @return int |
||
| 380 | */ |
||
| 381 | 4 | protected function upload_max_file_size () { |
|
| 385 | /** |
||
| 386 | * @param int|string $size |
||
| 387 | * |
||
| 388 | * @return int |
||
| 389 | */ |
||
| 390 | 4 | protected function convert_size_to_bytes ($size) { |
|
| 401 | /** |
||
| 402 | * @param resource $stream |
||
| 403 | * @param string $next_data |
||
| 404 | * @param string $target |
||
| 405 | * |
||
| 406 | * @return array |
||
| 407 | * |
||
| 408 | * @throws UnexpectedValueException |
||
| 409 | */ |
||
| 410 | 4 | protected function parse_multipart_find ($stream, $next_data, $target) { |
|
| 430 | /** |
||
| 431 | * @param string $content |
||
| 432 | * |
||
| 433 | * @return array |
||
| 434 | */ |
||
| 435 | 4 | protected function parse_multipart_headers ($content) { |
|
| 457 | /** |
||
| 458 | * @param array $source |
||
| 459 | * @param string $name |
||
| 460 | * @param array|string $value |
||
| 461 | */ |
||
| 462 | 4 | protected function parse_multipart_set_target (&$source, $name, $value) { |
|
| 479 | } |
||
| 480 |