admin - Code Metrics - Inspection of "Posts list and deletion in administration on front..." - nazar-pc/CleverStyle-Framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b4e787...2e096b )

by Nazar

created 2016-04-29 18:36 UTC

admin A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	143
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	9

Importance

Changes	5
Bugs	1	Features	0

Metric	Value
wmc	25
c	5
b	1
f	0
lcom	0
cbo	9
dl	0
loc	143
rs	10

8 Methods

Rating	Name	Size	Complexity
A	admin___get_settings()	10	1
A	admin___save_settings()	9	3
A	admin_posts_get()	21	4
A	admin_posts_delete()	13	4
A	admin_sections_get()	3	1
A	admin_sections_post()	16	3
B	admin_sections_put()	14	5
A	admin_sections_delete()	13	4

<?php
/**
 * @package   Blogs
 * @category  modules
 * @author    Nazar Mokrynskyi <[email protected]>
 * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
 * @license   MIT License, see license.txt
 */
namespace cs\modules\Blogs\api\Controller;
use
	cs\Config,
	cs\ExitException,
	cs\Language,
	cs\User,
	cs\modules\Blogs\Posts,
	cs\modules\Blogs\Sections;

trait admin {
	static function admin___get_settings () {
		$module_data = Config::instance()->module('Blogs');
		return [
			'posts_per_page'                => $module_data->posts_per_page,
			'max_sections'                  => $module_data->max_sections,
			'enable_comments'               => $module_data->enable_comments,
			'new_posts_only_from_admins'    => $module_data->new_posts_only_from_admins,
			'allow_iframes_without_content' => $module_data->allow_iframes_without_content
		];
	}
	/**
	 * @param \cs\Request $Request
	 *
	 * @throws ExitException
	 */
	static function admin___save_settings ($Request) {
		$data = $Request->data('posts_per_page', 'max_sections', 'enable_comments', 'new_posts_only_from_admins', 'allow_iframes_without_content');
		if (!$data) {
			throw new ExitException(400);
		}
		if (!Config::instance()->module('Blogs')->set($data)) {
			throw new ExitException(500);
		}
	}
	/**
	 * @param \cs\Request $Request
	 *
	 * @return array

	 *
	 * @throws ExitException
	 */
	static function admin_posts_get ($Request) {
		$id    = $Request->route_ids(0);
		$Posts = Posts::instance();
		if ($id) {
			$data = $Posts->get($id);
			if (!$data) {
				throw new ExitException(404);
			}
			return $data;
		}
		$posts = $Posts->get(
			$Posts->get_all(1, PHP_INT_MAX)
		);
		$L     = Language::instance();
		$User  = User::instance();
		foreach ($posts as &$post) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
			$post['username']       = $User->username($post['user']);
			$post['date_formatted'] = date($L->_datetime, $post['date']);
		}
		return $posts;
	}
	/**
	 * @param \cs\Request $Request
	 *
	 * @throws ExitException
	 */
	static function admin_posts_delete ($Request) {
		$id = $Request->route_ids(0);
		if (!$id) {
			throw new ExitException(400);
		}
		$Posts = Posts::instance();
		if (!$Posts->get($id)) {
			throw new ExitException(404);
		}
		if (!$Posts->del($id)) {
			throw new ExitException(Language::instance()->blogs_changes_save_error, 500);
		}
	}
	/**
	 * @param \cs\Request $Request
	 *
	 * @return array
	 *
	 * @throws ExitException
	 */
	static function admin_sections_get ($Request) {
		return static::sections_get($Request);
	}
	/**
	 * @param \cs\Request  $Request
	 * @param \cs\Response $Response
	 *
	 * @return array
	 *
	 * @throws ExitException
	 */
	static function admin_sections_post ($Request, $Response) {
		$data = $Request->data('title', 'path', 'parent');
		if (!$data) {
			throw new ExitException(400);
		}
		$Sections = Sections::instance();
		$id       = $Sections->add($data['parent'], $data['title'], $data['path']);
		if (!$id) {
			throw new ExitException(Language::instance()->blogs_changes_save_error, 500);
		}
		$Response->code = 201;
		return [
			'id'  => $id,
			'url' => Config::instance()->base_url().'/Blogs/section/'.$Sections->get($id)['full_path']
		];
	}
	/**
	 * @param \cs\Request $Request
	 *
	 * @throws ExitException
	 */
	static function admin_sections_put ($Request) {
		$id   = $Request->route_ids(0);
		$data = $Request->data('title', 'path', 'parent');
		if (!$id || !$data) {
			throw new ExitException(400);
		}
		$Sections = Sections::instance();
		if (!$Sections->get($id)) {
			throw new ExitException(404);
		}
		if (!$Sections->set($id, $data['parent'], $data['title'], $data['path'])) {
			throw new ExitException(Language::instance()->blogs_changes_save_error, 500);
		}
	}
	/**
	 * @param \cs\Request $Request
	 *
	 * @throws ExitException
	 */
	static function admin_sections_delete ($Request) {
		$id = $Request->route_ids(0);
		if (!$id) {
			throw new ExitException(400);
		}
		$Sections = Sections::instance();
		if (!$Sections->get($id)) {
			throw new ExitException(404);
		}
		if (!$Sections->del($id)) {
			throw new ExitException(Language::instance()->blogs_changes_save_error, 500);
		}
	}
}


1			<?php
2			/**
3			* @package Blogs
4			* @category modules
5			* @author Nazar Mokrynskyi <[email protected]>
6			* @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
7			* @license MIT License, see license.txt
8			*/
9			namespace cs\modules\Blogs\api\Controller;
10			use
11			cs\Config,
12			cs\ExitException,
13			cs\Language,
14			cs\User,
15			cs\modules\Blogs\Posts,
16			cs\modules\Blogs\Sections;
17
18			trait admin {
19			static function admin___get_settings () {
20			$module_data = Config::instance()->module('Blogs');
21			return [
22			'posts_per_page' => $module_data->posts_per_page,
23			'max_sections' => $module_data->max_sections,
24			'enable_comments' => $module_data->enable_comments,
25			'new_posts_only_from_admins' => $module_data->new_posts_only_from_admins,
26			'allow_iframes_without_content' => $module_data->allow_iframes_without_content
27			];
28			}
29			/**
30			* @param \cs\Request $Request
31			*
32			* @throws ExitException
33			*/
34			static function admin___save_settings ($Request) {
35			$data = $Request->data('posts_per_page', 'max_sections', 'enable_comments', 'new_posts_only_from_admins', 'allow_iframes_without_content');
36			if (!$data) {
37			throw new ExitException(400);
38			}
39			if (!Config::instance()->module('Blogs')->set($data)) {
40			throw new ExitException(500);
41			}
42			}
43			/**
44			* @param \cs\Request $Request
45			*
46			* @return array
			1 ignored issue – show Documentation introduced 2016-04-29 18:40 UTC by Report Bug Copy Issue Report Should the return type not be `array\|false`? Also, consider making the array more specific, something like `array<String>`, or `String[]`. This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. If the return type contains the type array, this check recommends the use of a more specific type like `String[]` or `array<String>`. Loading history...
47			*
48			* @throws ExitException
49			*/
50			static function admin_posts_get ($Request) {
51			$id = $Request->route_ids(0);
52			$Posts = Posts::instance();
53			if ($id) {
54			$data = $Posts->get($id);
55			if (!$data) {
56			throw new ExitException(404);
57			}
58			return $data;
59			}
60			$posts = $Posts->get(
61			$Posts->get_all(1, PHP_INT_MAX)
62			);
63			$L = Language::instance();
64			$User = User::instance();
65			foreach ($posts as &$post) {
			1 ignored issue – show Bug introduced 2016-04-29 18:40 UTC by Report Bug Copy Issue Report The expression `$posts` of type `array\|false` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
66			$post['username'] = $User->username($post['user']);
67			$post['date_formatted'] = date($L->_datetime, $post['date']);
68			}
69			return $posts;
70			}
71			/**
72			* @param \cs\Request $Request
73			*
74			* @throws ExitException
75			*/
76			static function admin_posts_delete ($Request) {
77			$id = $Request->route_ids(0);
78			if (!$id) {
79			throw new ExitException(400);
80			}
81			$Posts = Posts::instance();
82			if (!$Posts->get($id)) {
83			throw new ExitException(404);
84			}
85			if (!$Posts->del($id)) {
86			throw new ExitException(Language::instance()->blogs_changes_save_error, 500);
87			}
88			}
89			/**
90			* @param \cs\Request $Request
91			*
92			* @return array
93			*
94			* @throws ExitException
95			*/
96			static function admin_sections_get ($Request) {
97			return static::sections_get($Request);
98			}
99			/**
100			* @param \cs\Request $Request
101			* @param \cs\Response $Response
102			*
103			* @return array
104			*
105			* @throws ExitException
106			*/
107			static function admin_sections_post ($Request, $Response) {
108			$data = $Request->data('title', 'path', 'parent');
109			if (!$data) {
110			throw new ExitException(400);
111			}
112			$Sections = Sections::instance();
113			$id = $Sections->add($data['parent'], $data['title'], $data['path']);
114			if (!$id) {
115			throw new ExitException(Language::instance()->blogs_changes_save_error, 500);
116			}
117			$Response->code = 201;
118			return [
119			'id' => $id,
120			'url' => Config::instance()->base_url().'/Blogs/section/'.$Sections->get($id)['full_path']
121			];
122			}
123			/**
124			* @param \cs\Request $Request
125			*
126			* @throws ExitException
127			*/
128			static function admin_sections_put ($Request) {
129			$id = $Request->route_ids(0);
130			$data = $Request->data('title', 'path', 'parent');
131			if (!$id \|\| !$data) {
132			throw new ExitException(400);
133			}
134			$Sections = Sections::instance();
135			if (!$Sections->get($id)) {
136			throw new ExitException(404);
137			}
138			if (!$Sections->set($id, $data['parent'], $data['title'], $data['path'])) {
139			throw new ExitException(Language::instance()->blogs_changes_save_error, 500);
140			}
141			}
142			/**
143			* @param \cs\Request $Request
144			*
145			* @throws ExitException
146			*/
147			static function admin_sections_delete ($Request) {
148			$id = $Request->route_ids(0);
149			if (!$id) {
150			throw new ExitException(400);
151			}
152			$Sections = Sections::instance();
153			if (!$Sections->get($id)) {
154			throw new ExitException(404);
155			}
156			if (!$Sections->del($id)) {
157			throw new ExitException(Language::instance()->blogs_changes_save_error, 500);
158			}
159			}
160			}
161

nazar-pc / CleverStyle-Framework

Push — master ( b4e787...2e096b )

admin A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

Duplication Side-by-Side

Filter issues like