Inspection of "TODO removes as resolved" - nazar-pc/CleverStyle-Framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6b0cd2...000ea2 )

by Nazar

created 2015-12-21 06:22 UTC

Status

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -18,7 +18,7 @@  discard block
 block discarded – undo
 $L              = new Prefix('shop_');
 $Language       = Language::instance();
 $Page           = Page::instance();
-$Session           = Session::instance();
+$Session = Session::instance();
 $Categories     = Categories::instance();
 $Items          = Items::instance();
 $Orders         = Orders::instance();
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
 $page           = @$_GET['page'] ?: 1;
 $count          = @$_GET['count'] ?: Config::instance()->module('Shop')->items_per_page;
 if ($Session->user()) {
-	$orders       = $Orders->get($Orders->search(
+	$orders = $Orders->get($Orders->search(
 		[
 			'user' => $Session->get_user()
 		] + (array)$_GET,

Please login to merge, or discard this patch.

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   Shop
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2014-2015, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Shop
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2014-2015, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\modules\Shop;
 use
 	cs\Config,

Please login to merge, or discard this patch.

components/modules/Shop/pay.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   Shop
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2014-2015, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Shop
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2014-2015, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\modules\Shop;
 use
 	cs\Config,

Please login to merge, or discard this patch.

components/modules/Static_pages/Categories.php 2 patches

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -20,7 +20,7 @@
 block discarded – undo
 	use
 		CRUD,
 		Singleton;
-	protected $data_model          = [
+	protected $data_model = [
 		'id'     => 'int',
 		'title'  => 'ml:text',
 		'path'   => 'ml:text',

Please login to merge, or discard this patch.

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   Static Pages
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2011-2015, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Static Pages
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2011-2015, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\modules\Static_pages;
 use
 	h,

Please login to merge, or discard this patch.

components/modules/Static_pages/Pages.php 2 patches

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -21,7 +21,7 @@  discard block
 block discarded – undo
 	use
 		CRUD,
 		Singleton;
-	protected $data_model                  = [
+	protected $data_model = [
 		'id'        => 'int',
 		'category'  => 'int',
 		'title'     => 'ml:text',
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
 				$Categories->get($parent)
 			);
 		}
-		$pages              = $this->db()->qfas(
+		$pages = $this->db()->qfas(
 			[
 				"SELECT `id`
 				FROM `[prefix]static_pages`
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
 			$structure['pages'][$this->get($id)['path']] = $id;
 		}
 		unset($pages);
-		$categories              = $this->db()->qfa(
+		$categories = $this->db()->qfa(
 			[
 				"SELECT
 					`id`,

Please login to merge, or discard this patch.

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   Static Pages
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2011-2015, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Static Pages
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2011-2015, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\modules\Static_pages;
 use
 	h,

Please login to merge, or discard this patch.

components/modules/Static_pages/admin/delete_category.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package        Static Pages
- * @category       modules
- * @author         Nazar Mokrynskyi <[email protected]>
- * @copyright      Copyright (c) 2011-2015, Nazar Mokrynskyi
- * @license        MIT License, see license.txt
- */
+	 * @package        Static Pages
+	 * @category       modules
+	 * @author         Nazar Mokrynskyi <[email protected]>
+	 * @copyright      Copyright (c) 2011-2015, Nazar Mokrynskyi
+	 * @license        MIT License, see license.txt
+	 */
 namespace cs\modules\Static_pages;
 use
 	h,

Please login to merge, or discard this patch.

components/modules/Static_pages/admin/index.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,9 +1,9 @@
 block discarded – undo
 <?php
 /**
- * @package		Static Pages
- * @category	modules
- * @author		Nazar Mokrynskyi <[email protected]>
- * @copyright	Copyright (c) 2014-2015, Nazar Mokrynskyi
- * @license		MIT License, see license.txt
- */
+	 * @package		Static Pages
+	 * @category	modules
+	 * @author		Nazar Mokrynskyi <[email protected]>
+	 * @copyright	Copyright (c) 2014-2015, Nazar Mokrynskyi
+	 * @license		MIT License, see license.txt
+	 */
 include __DIR__.'/save.php';

Please login to merge, or discard this patch.

components/modules/Static_pages/index.php 1 patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,14 +1,14 @@
 block discarded – undo
 <?php
 /**
- * @package   Static Pages
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2015, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Static Pages
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2015, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 use
 	cs\Page;
 /**
- * Remove automatically added module name from title
- */
+	 * Remove automatically added module name from title
+	 */
 array_pop(Page::instance()->Title);

Please login to merge, or discard this patch.

components/modules/System/Packages_manipulation.php 1 patch

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -1,12 +1,12 @@  discard block
 block discarded – undo
 <?php
 /**
- * @package    CleverStyle CMS
- * @subpackage System module
- * @category   modules
- * @author     Nazar Mokrynskyi <[email protected]>
- * @copyright  Copyright (c) 2015, Nazar Mokrynskyi
- * @license    MIT License, see license.txt
- */
+	 * @package    CleverStyle CMS
+	 * @subpackage System module
+	 * @category   modules
+	 * @author     Nazar Mokrynskyi <[email protected]>
+	 * @copyright  Copyright (c) 2015, Nazar Mokrynskyi
+	 * @license    MIT License, see license.txt
+	 */
 namespace cs\modules\System;
 use
 	cs\Config,
@@ -15,8 +15,8 @@  discard block
 block discarded – undo
 	cs\Language,
 	cs\Page;
 /**
- * Utility functions, necessary during packages manipulation (installation/uninstallation, enabling/disabling)
- */
+	 * Utility functions, necessary during packages manipulation (installation/uninstallation, enabling/disabling)
+	 */
 class Packages_manipulation {
 	/**
 	 * @param string $file_name File key in `$_FILES` superglobal

Please login to merge, or discard this patch.

components/modules/System/admin/Controller/users.php 2 patches

Spacing +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -88,16 +88,14 @@
 block discarded – undo
 				[
 					static::core_input('registration_confirmation_time', 'number', null, false, 1, false, $L->days),
 					[
-						'style' => $Config->core['allow_user_registration'] == 1 && $Config->core['require_registration_confirmation'] == 1 ? '' :
-							'display: none;',
+						'style' => $Config->core['allow_user_registration'] == 1 && $Config->core['require_registration_confirmation'] == 1 ? '' : 'display: none;',
 						'class' => 'cs-allow-user-registration cs-require-registration-confirmation'
 					]
 				],
 				[
 					static::core_input('auto_sign_in_after_registration', 'radio'),
 					[
-						'style' => $Config->core['allow_user_registration'] == 1 && $Config->core['require_registration_confirmation'] == 1 ? '' :
-							'display: none;',
+						'style' => $Config->core['allow_user_registration'] == 1 && $Config->core['require_registration_confirmation'] == 1 ? '' : 'display: none;',
 						'class' => 'cs-allow-user-registration cs-require-registration-confirmation'
 					]
 				],

Please login to merge, or discard this patch.

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -1,12 +1,12 @@
 block discarded – undo
 <?php
 /**
- * @package    CleverStyle CMS
- * @subpackage System module
- * @category   modules
- * @author     Nazar Mokrynskyi <[email protected]>
- * @copyright  Copyright (c) 2015, Nazar Mokrynskyi
- * @license    MIT License, see license.txt
- */
+	 * @package    CleverStyle CMS
+	 * @subpackage System module
+	 * @category   modules
+	 * @author     Nazar Mokrynskyi <[email protected]>
+	 * @copyright  Copyright (c) 2015, Nazar Mokrynskyi
+	 * @license    MIT License, see license.txt
+	 */
 namespace cs;
 
 $Config = Config::instance();

Please login to merge, or discard this patch.

		@@ -88,16 +88,14 @@
		block discarded – undo
88	88	[
89	89	static::core_input('registration_confirmation_time', 'number', null, false, 1, false, $L->days),
90	90	[
91		- 'style' => $Config->core['allow_user_registration'] == 1 && $Config->core['require_registration_confirmation'] == 1 ? '' :
92		- 'display: none;',
	91	+ 'style' => $Config->core['allow_user_registration'] == 1 && $Config->core['require_registration_confirmation'] == 1 ? '' : 'display: none;',
93	92	'class' => 'cs-allow-user-registration cs-require-registration-confirmation'
94	93	]
95	94	],
96	95	[
97	96	static::core_input('auto_sign_in_after_registration', 'radio'),
98	97	[
99		- 'style' => $Config->core['allow_user_registration'] == 1 && $Config->core['require_registration_confirmation'] == 1 ? '' :
100		- 'display: none;',
	98	+ 'style' => $Config->core['allow_user_registration'] == 1 && $Config->core['require_registration_confirmation'] == 1 ? '' : 'display: none;',
101	99	'class' => 'cs-allow-user-registration cs-require-registration-confirmation'
102	100	]
103	101	],

		@@ -18,7 +18,7 @@ discard block
		block discarded – undo
18	18	$L = new Prefix('shop_');
19	19	$Language = Language::instance();
20	20	$Page = Page::instance();
21		-$Session = Session::instance();
	21	+$Session = Session::instance();
22	22	$Categories = Categories::instance();
23	23	$Items = Items::instance();
24	24	$Orders = Orders::instance();
		@@ -27,7 +27,7 @@ discard block
		block discarded – undo
27	27	$page = @$_GET['page'] ?: 1;
28	28	$count = @$_GET['count'] ?: Config::instance()->module('Shop')->items_per_page;
29	29	if ($Session->user()) {
30		- $orders = $Orders->get($Orders->search(
	30	+ $orders = $Orders->get($Orders->search(
31	31	[
32	32	'user' => $Session->get_user()
33	33	] + (array)$_GET,

		@@ -1,11 +1,11 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * @package Shop
4		- * @category modules
5		- * @author Nazar Mokrynskyi <[email protected]>
6		- * @copyright Copyright (c) 2014-2015, Nazar Mokrynskyi
7		- * @license MIT License, see license.txt
8		- */
	3	+ * @package Shop
	4	+ * @category modules
	5	+ * @author Nazar Mokrynskyi <[email protected]>
	6	+ * @copyright Copyright (c) 2014-2015, Nazar Mokrynskyi
	7	+ * @license MIT License, see license.txt
	8	+ */
9	9	namespace cs\modules\Shop;
10	10	use
11	11	cs\Config,

		@@ -20,7 +20,7 @@
		block discarded – undo
20	20	use
21	21	CRUD,
22	22	Singleton;
23		- protected $data_model = [
	23	+ protected $data_model = [
24	24	'id' => 'int',
25	25	'title' => 'ml:text',
26	26	'path' => 'ml:text',

		@@ -21,7 +21,7 @@ discard block
		block discarded – undo
21	21	use
22	22	CRUD,
23	23	Singleton;
24		- protected $data_model = [
	24	+ protected $data_model = [
25	25	'id' => 'int',
26	26	'category' => 'int',
27	27	'title' => 'ml:text',
		@@ -164,7 +164,7 @@ discard block
		block discarded – undo
164	164	$Categories->get($parent)
165	165	);
166	166	}
167		- $pages = $this->db()->qfas(
	167	+ $pages = $this->db()->qfas(
168	168	[
169	169	"SELECT `id`
170	170	FROM `[prefix]static_pages`
		@@ -177,7 +177,7 @@ discard block
		block discarded – undo
177	177	$structure['pages'][$this->get($id)['path']] = $id;
178	178	}
179	179	unset($pages);
180		- $categories = $this->db()->qfa(
	180	+ $categories = $this->db()->qfa(
181	181	[
182	182	"SELECT
183	183	`id`,

		@@ -1,9 +1,9 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * @package Static Pages
4		- * @category modules
5		- * @author Nazar Mokrynskyi <[email protected]>
6		- * @copyright Copyright (c) 2014-2015, Nazar Mokrynskyi
7		- * @license MIT License, see license.txt
8		- */
	3	+ * @package Static Pages
	4	+ * @category modules
	5	+ * @author Nazar Mokrynskyi <[email protected]>
	6	+ * @copyright Copyright (c) 2014-2015, Nazar Mokrynskyi
	7	+ * @license MIT License, see license.txt
	8	+ */
9	9	include __DIR__.'/save.php';

		@@ -1,14 +1,14 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * @package Static Pages
4		- * @category modules
5		- * @author Nazar Mokrynskyi <[email protected]>
6		- * @copyright Copyright (c) 2015, Nazar Mokrynskyi
7		- * @license MIT License, see license.txt
8		- */
	3	+ * @package Static Pages
	4	+ * @category modules
	5	+ * @author Nazar Mokrynskyi <[email protected]>
	6	+ * @copyright Copyright (c) 2015, Nazar Mokrynskyi
	7	+ * @license MIT License, see license.txt
	8	+ */
9	9	use
10	10	cs\Page;
11	11	/**
12		- * Remove automatically added module name from title
13		- */
	12	+ * Remove automatically added module name from title
	13	+ */
14	14	array_pop(Page::instance()->Title);

		@@ -1,12 +1,12 @@ discard block
		block discarded – undo
1	1	<?php
2	2	/**
3		- * @package CleverStyle CMS
4		- * @subpackage System module
5		- * @category modules
6		- * @author Nazar Mokrynskyi <[email protected]>
7		- * @copyright Copyright (c) 2015, Nazar Mokrynskyi
8		- * @license MIT License, see license.txt
9		- */
	3	+ * @package CleverStyle CMS
	4	+ * @subpackage System module
	5	+ * @category modules
	6	+ * @author Nazar Mokrynskyi <[email protected]>
	7	+ * @copyright Copyright (c) 2015, Nazar Mokrynskyi
	8	+ * @license MIT License, see license.txt
	9	+ */
10	10	namespace cs\modules\System;
11	11	use
12	12	cs\Config,
		@@ -15,8 +15,8 @@ discard block
		block discarded – undo
15	15	cs\Language,
16	16	cs\Page;
17	17	/**
18		- * Utility functions, necessary during packages manipulation (installation/uninstallation, enabling/disabling)
19		- */
	18	+ * Utility functions, necessary during packages manipulation (installation/uninstallation, enabling/disabling)
	19	+ */
20	20	class Packages_manipulation {
21	21	/**
22	22	* @param string $file_name File key in `$_FILES` superglobal

		@@ -1,12 +1,12 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * @package CleverStyle CMS
4		- * @subpackage System module
5		- * @category modules
6		- * @author Nazar Mokrynskyi <[email protected]>
7		- * @copyright Copyright (c) 2015, Nazar Mokrynskyi
8		- * @license MIT License, see license.txt
9		- */
	3	+ * @package CleverStyle CMS
	4	+ * @subpackage System module
	5	+ * @category modules
	6	+ * @author Nazar Mokrynskyi <[email protected]>
	7	+ * @copyright Copyright (c) 2015, Nazar Mokrynskyi
	8	+ * @license MIT License, see license.txt
	9	+ */
10	10	namespace cs;
11	11
12	12	$Config = Config::instance();

nazar-pc / CleverStyle-Framework

Push — master ( 6b0cd2...000ea2 )

Status

Category

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch