Inspection of "Unused statement removed" - nazar-pc/CleverStyle-Framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (0964ce)

by Nazar

created 2015-12-27 13:23 UTC

Status

Spacing +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -33,8 +33,7 @@
 block discarded – undo
 			'value' => $gallery['title']
 		]
 	).
-	($Config->core['simple_admin_mode'] ? '' :
-		h::label(h::info('photo_gallery_gallery_path')).
+	($Config->core['simple_admin_mode'] ? '' : h::label(h::info('photo_gallery_gallery_path')).
 		h::{'input[is=cs-input-text][name=edit[path]]'}(
 			[
 				'value' => $gallery['path']

Please login to merge, or discard this patch.

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   Photo gallery
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2013-2015, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Photo gallery
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2013-2015, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\modules\Photo_gallery;
 
 use

Please login to merge, or discard this patch.

components/modules/Photo_gallery/admin/galleries/save.php 2 patches

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -9,13 +9,13 @@
 block discarded – undo
 namespace	cs\modules\Photo_gallery;
 use
 	cs\Index;
-$Index			= Index::instance();
-$Photo_gallery	= Photo_gallery::instance();
+$Index = Index::instance();
+$Photo_gallery = Photo_gallery::instance();
 if (isset($_POST['add'])) {
-	$add	= $_POST['add'];
+	$add = $_POST['add'];
 	$Index->save($Photo_gallery->add_gallery($add['title'], isset($add['path']) ? $add['path'] : null, $add['description'], $add['active'], $add['preview_image']));
 } elseif (isset($_POST['edit'])) {
-	$edit	= $_POST['edit'];
+	$edit = $_POST['edit'];
 	$Index->save($Photo_gallery->set_gallery($edit['id'], $edit['title'], isset($edit['path']) ? $edit['path'] : null, $edit['description'], $edit['active'], $edit['preview_image']));
 } elseif (isset($_POST['delete'])) {
 	$Index->save($Photo_gallery->del_gallery($_POST['delete']));

Please login to merge, or discard this patch.

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package		Photo gallery
- * @category	modules
- * @author		Nazar Mokrynskyi <[email protected]>
- * @copyright	Copyright (c) 2013-2015, Nazar Mokrynskyi
- * @license		MIT License, see license.txt
- */
+	 * @package		Photo gallery
+	 * @category	modules
+	 * @author		Nazar Mokrynskyi <[email protected]>
+	 * @copyright	Copyright (c) 2013-2015, Nazar Mokrynskyi
+	 * @license		MIT License, see license.txt
+	 */
 namespace	cs\modules\Photo_gallery;
 use
 	cs\Config,

Please login to merge, or discard this patch.

components/modules/Photo_gallery/events.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   Photo gallery
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2013-2015, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Photo gallery
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2013-2015, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\modules\Photo_gallery;
 
 use

Please login to merge, or discard this patch.

components/modules/Photo_gallery/events/installed.php 2 patches

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package		Photo gallery
- * @category	modules
- * @author		Nazar Mokrynskyi <[email protected]>
- * @copyright	Copyright (c) 2013-2015, Nazar Mokrynskyi
- * @license		MIT License, see license.txt
- */
+	 * @package		Photo gallery
+	 * @category	modules
+	 * @author		Nazar Mokrynskyi <[email protected]>
+	 * @copyright	Copyright (c) 2013-2015, Nazar Mokrynskyi
+	 * @license		MIT License, see license.txt
+	 */
 namespace	cs\modules\Photo_gallery;
 use
 	cs\Config,

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -17,9 +17,9 @@
 block discarded – undo
 		if ($data['name'] != 'Photo_gallery') {
 			return;
 		}
-		$module_data	= Config::instance()->module('Photo_gallery');
-		$storage		= Storage::instance()->{$module_data->storage('files')};
-		$Photo_gallery	= Photo_gallery::instance();
+		$module_data = Config::instance()->module('Photo_gallery');
+		$storage = Storage::instance()->{$module_data->storage('files')};
+		$Photo_gallery = Photo_gallery::instance();
 		foreach ($Photo_gallery->get_galleries_list() as $gallery) {
 			$Photo_gallery->del_gallery($gallery);
 		}

Please login to merge, or discard this patch.

components/modules/Photo_gallery/prepare.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package        Photo gallery
- * @category       modules
- * @author         Nazar Mokrynskyi <[email protected]>
- * @copyright      Copyright (c) 2013-2015, Nazar Mokrynskyi
- * @license        MIT License, see license.txt
- */
+	 * @package        Photo gallery
+	 * @category       modules
+	 * @author         Nazar Mokrynskyi <[email protected]>
+	 * @copyright      Copyright (c) 2013-2015, Nazar Mokrynskyi
+	 * @license        MIT License, see license.txt
+	 */
 namespace cs\modules\Photo_gallery;
 
 use

Please login to merge, or discard this patch.

components/modules/Plupload/admin/save.php 2 patches

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -9,8 +9,8 @@
 block discarded – undo
  */
 namespace	cs;
 if (isset($_POST['save'])) {
-	$module_data					= Config::instance()->module('Plupload');
-	$module_data->max_file_size		= xap($_POST['max_file_size']);
-	$module_data->confirmation_time	= (int)$_POST['confirmation_time'];
+	$module_data = Config::instance()->module('Plupload');
+	$module_data->max_file_size = xap($_POST['max_file_size']);
+	$module_data->confirmation_time = (int)$_POST['confirmation_time'];
 	Index::instance()->save(true);
 }

Please login to merge, or discard this patch.

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -1,12 +1,12 @@
 block discarded – undo
 <?php
 /**
- * @package		Plupload
- * @category	modules
- * @author		Moxiecode Systems AB
- * @author		Nazar Mokrynskyi <[email protected]> (integration with CleverStyle CMS)
- * @copyright	Moxiecode Systems AB
- * @license		GNU GPL v2, see license.txt
- */
+	 * @package		Plupload
+	 * @category	modules
+	 * @author		Moxiecode Systems AB
+	 * @author		Nazar Mokrynskyi <[email protected]> (integration with CleverStyle CMS)
+	 * @copyright	Moxiecode Systems AB
+	 * @license		GNU GPL v2, see license.txt
+	 */
 namespace	cs;
 Event::instance()->on(
 	'admin/System/components/modules/install/after',

Please login to merge, or discard this patch.

components/modules/Polls/Common_actions.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   Polls
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2015, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Polls
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2015, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\modules\Polls;
 
 /**

Please login to merge, or discard this patch.

components/modules/Polls/events.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   Polls
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2014-2015, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Polls
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2014-2015, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs;
 
 Event::instance()->on(

Please login to merge, or discard this patch.

components/modules/Polls/events/installed.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package        Polls
- * @category       modules
- * @author         Nazar Mokrynskyi <[email protected]>
- * @copyright      Copyright (c) 2014-2015, Nazar Mokrynskyi
- * @license        MIT License, see license.txt
- */
+	 * @package        Polls
+	 * @category       modules
+	 * @author         Nazar Mokrynskyi <[email protected]>
+	 * @copyright      Copyright (c) 2014-2015, Nazar Mokrynskyi
+	 * @license        MIT License, see license.txt
+	 */
 namespace cs\modules\Polls;
 
 use

Please login to merge, or discard this patch.

		@@ -33,8 +33,7 @@
		block discarded – undo
33	33	'value' => $gallery['title']
34	34	]
35	35	).
36		- ($Config->core['simple_admin_mode'] ? '' :
37		- h::label(h::info('photo_gallery_gallery_path')).
	36	+ ($Config->core['simple_admin_mode'] ? '' : h::label(h::info('photo_gallery_gallery_path')).
38	37	h::{'input[is=cs-input-text][name=edit[path]]'}(
39	38	[
40	39	'value' => $gallery['path']

		@@ -1,11 +1,11 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * @package Photo gallery
4		- * @category modules
5		- * @author Nazar Mokrynskyi <[email protected]>
6		- * @copyright Copyright (c) 2013-2015, Nazar Mokrynskyi
7		- * @license MIT License, see license.txt
8		- */
	3	+ * @package Photo gallery
	4	+ * @category modules
	5	+ * @author Nazar Mokrynskyi <[email protected]>
	6	+ * @copyright Copyright (c) 2013-2015, Nazar Mokrynskyi
	7	+ * @license MIT License, see license.txt
	8	+ */
9	9	namespace cs\modules\Photo_gallery;
10	10
11	11	use

		@@ -9,13 +9,13 @@
		block discarded – undo
9	9	namespace cs\modules\Photo_gallery;
10	10	use
11	11	cs\Index;
12		-$Index = Index::instance();
13		-$Photo_gallery = Photo_gallery::instance();
	12	+$Index = Index::instance();
	13	+$Photo_gallery = Photo_gallery::instance();
14	14	if (isset($_POST['add'])) {
15		- $add = $_POST['add'];
	15	+ $add = $_POST['add'];
16	16	$Index->save($Photo_gallery->add_gallery($add['title'], isset($add['path']) ? $add['path'] : null, $add['description'], $add['active'], $add['preview_image']));
17	17	} elseif (isset($_POST['edit'])) {
18		- $edit = $_POST['edit'];
	18	+ $edit = $_POST['edit'];
19	19	$Index->save($Photo_gallery->set_gallery($edit['id'], $edit['title'], isset($edit['path']) ? $edit['path'] : null, $edit['description'], $edit['active'], $edit['preview_image']));
20	20	} elseif (isset($_POST['delete'])) {
21	21	$Index->save($Photo_gallery->del_gallery($_POST['delete']));

		@@ -17,9 +17,9 @@
		block discarded – undo
17	17	if ($data['name'] != 'Photo_gallery') {
18	18	return;
19	19	}
20		- $module_data = Config::instance()->module('Photo_gallery');
21		- $storage = Storage::instance()->{$module_data->storage('files')};
22		- $Photo_gallery = Photo_gallery::instance();
	20	+ $module_data = Config::instance()->module('Photo_gallery');
	21	+ $storage = Storage::instance()->{$module_data->storage('files')};
	22	+ $Photo_gallery = Photo_gallery::instance();
23	23	foreach ($Photo_gallery->get_galleries_list() as $gallery) {
24	24	$Photo_gallery->del_gallery($gallery);
25	25	}

		@@ -9,8 +9,8 @@
		block discarded – undo
9	9	*/
10	10	namespace cs;
11	11	if (isset($_POST['save'])) {
12		- $module_data = Config::instance()->module('Plupload');
13		- $module_data->max_file_size = xap($_POST['max_file_size']);
14		- $module_data->confirmation_time = (int)$_POST['confirmation_time'];
	12	+ $module_data = Config::instance()->module('Plupload');
	13	+ $module_data->max_file_size = xap($_POST['max_file_size']);
	14	+ $module_data->confirmation_time = (int)$_POST['confirmation_time'];
15	15	Index::instance()->save(true);
16	16	}

		@@ -1,12 +1,12 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * @package Plupload
4		- * @category modules
5		- * @author Moxiecode Systems AB
6		- * @author Nazar Mokrynskyi <[email protected]> (integration with CleverStyle CMS)
7		- * @copyright Moxiecode Systems AB
8		- * @license GNU GPL v2, see license.txt
9		- */
	3	+ * @package Plupload
	4	+ * @category modules
	5	+ * @author Moxiecode Systems AB
	6	+ * @author Nazar Mokrynskyi <[email protected]> (integration with CleverStyle CMS)
	7	+ * @copyright Moxiecode Systems AB
	8	+ * @license GNU GPL v2, see license.txt
	9	+ */
10	10	namespace cs;
11	11	Event::instance()->on(
12	12	'admin/System/components/modules/install/after',

nazar-pc / CleverStyle-Framework

Branch — master (0964ce)

Status

Category

Spacing +1 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch