Inspection of "Unused statement removed" - nazar-pc/CleverStyle-Framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (0964ce)

by Nazar

created 2015-12-27 13:23 UTC

Status

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   Deferred tasks
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2013-2015, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Deferred tasks
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2013-2015, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\modules\Deferred_tasks;
 use
 	cs\ExitException,

Please login to merge, or discard this patch.

components/modules/Disqus/Disqus.php 2 patches

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package		Disqus
- * @category	modules
- * @author		Nazar Mokrynskyi <[email protected]>
- * @copyright	Copyright (c) 2013-2015, Nazar Mokrynskyi
- * @license		MIT License, see license.txt
- */
+	 * @package		Disqus
+	 * @category	modules
+	 * @author		Nazar Mokrynskyi <[email protected]>
+	 * @copyright	Copyright (c) 2013-2015, Nazar Mokrynskyi
+	 * @license		MIT License, see license.txt
+	 */
 namespace	cs\modules\Disqus;
 use			h,
 			cs\Config,

Please login to merge, or discard this patch.

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -28,8 +28,8 @@  discard block
 block discarded – undo
 	protected	$shortname;
 
 	protected function construct () {
-		$this->module		= current_module();
-		$this->shortname	= Config::instance()->module('Disqus')->shortname;
+		$this->module = current_module();
+		$this->shortname = Config::instance()->module('Disqus')->shortname;
 	}
 	/**
 	 * Set module (current module assumed by default)
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
 	 * @param string	$module	Module name
 	 */
 	function set_module ($module) {
-		$this->module	= $module;
+		$this->module = $module;
 	}
 	/**
 	 * Count of comments for specified item
@@ -74,11 +74,11 @@  discard block
 block discarded – undo
 		return '<div id="disqus_thread"></div>';
 	}
 	protected function count_js () {
-		static	$added	= false;
+		static	$added = false;
 		if ($added) {
 			return;
 		}
-		$added		= true;
+		$added = true;
 		Page::instance()->js(
 			"var disqus_shortname = '$this->shortname';
 if (!window.disqus_count_items) { window.disqus_count_items = []; }",
@@ -86,11 +86,11 @@  discard block
 block discarded – undo
 		);
 	}
 	protected function block_js ($item) {
-		static	$added	= false;
+		static	$added = false;
 		if ($added) {
 			return;
 		}
-		$added		= true;
+		$added = true;
 		Page::instance()->js(
 			"var disqus_shortname = '$this->shortname', disqus_identifier = '".str_replace("'", "\'", "$this->module/$item")."';",
 			'code'

Please login to merge, or discard this patch.

components/modules/Disqus/admin/index.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   Cron
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2011-2015, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Cron
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2011-2015, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs;
 use
 	h;

Please login to merge, or discard this patch.

components/modules/Disqus/admin/save.php 2 patches

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package		Disqus
- * @category	modules
- * @author		Nazar Mokrynskyi <[email protected]>
- * @copyright	Copyright (c) 2011-2015, Nazar Mokrynskyi
- * @license		MIT License, see license.txt
- */
+	 * @package		Disqus
+	 * @category	modules
+	 * @author		Nazar Mokrynskyi <[email protected]>
+	 * @copyright	Copyright (c) 2011-2015, Nazar Mokrynskyi
+	 * @license		MIT License, see license.txt
+	 */
 namespace	cs;
 if (isset($_POST['shortname'])) {
 	Config::instance()->module('Disqus')->shortname	= $_POST['shortname'];

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -8,6 +8,6 @@
 block discarded – undo
  */
 namespace	cs;
 if (isset($_POST['shortname'])) {
-	Config::instance()->module('Disqus')->shortname	= $_POST['shortname'];
+	Config::instance()->module('Disqus')->shortname = $_POST['shortname'];
 	Index::instance()->save(true);
 }

Please login to merge, or discard this patch.

components/modules/Disqus/events.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package        Comments
- * @category       modules
- * @author         Nazar Mokrynskyi <[email protected]>
- * @copyright      Copyright (c) 2011-2015, Nazar Mokrynskyi
- * @license        MIT License, see license.txt
- */
+	 * @package        Comments
+	 * @category       modules
+	 * @author         Nazar Mokrynskyi <[email protected]>
+	 * @copyright      Copyright (c) 2011-2015, Nazar Mokrynskyi
+	 * @license        MIT License, see license.txt
+	 */
 namespace cs;
 Event::instance()->on(
 	'System/Index/construct',

Please login to merge, or discard this patch.

components/modules/Disqus/events/enabled.php 2 patches

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -1,18 +1,18 @@
 block discarded – undo
 <?php
 /**
- * @package		Disqus
- * @category	modules
- * @author		Nazar Mokrynskyi <[email protected]>
- * @copyright	Copyright (c) 2013-2015, Nazar Mokrynskyi
- * @license		MIT License, see license.txt
- */
+	 * @package		Disqus
+	 * @category	modules
+	 * @author		Nazar Mokrynskyi <[email protected]>
+	 * @copyright	Copyright (c) 2013-2015, Nazar Mokrynskyi
+	 * @license		MIT License, see license.txt
+	 */
 /**
- * Supports next events:
- *  Comments/instance
- *  [
- *   'Comments'		=> <i>&$Comments</i>
- *  ]
- */
+	 * Supports next events:
+	 *  Comments/instance
+	 *  [
+	 *   'Comments'		=> <i>&$Comments</i>
+	 *  ]
+	 */
 namespace	cs\modules\Disqus;
 use
 	cs\Event;

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -19,7 +19,7 @@
 block discarded – undo
 Event::instance()->on(
 	'Comments/instance',
 	function ($data) {
-		$data['Comments']	= Disqus::instance();
+		$data['Comments'] = Disqus::instance();
 		return false;
 	}
 );

Please login to merge, or discard this patch.

components/modules/Feedback/index.php 2 patches

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package		Feedback
- * @category	modules
- * @author		Nazar Mokrynskyi <[email protected]>
- * @copyright	Copyright (c) 2011-2015, Nazar Mokrynskyi
- * @license		MIT License, see license.txt
- */
+	 * @package		Feedback
+	 * @category	modules
+	 * @author		Nazar Mokrynskyi <[email protected]>
+	 * @copyright	Copyright (c) 2011-2015, Nazar Mokrynskyi
+	 * @license		MIT License, see license.txt
+	 */
 namespace	cs;
 use			h;
 $Index			= Index::instance();

Please login to merge, or discard this patch.

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -8,11 +8,11 @@
 block discarded – undo
  */
 namespace	cs;
 use			h;
-$Index			= Index::instance();
-$Index->form	= true;
-$Index->buttons	= false;
-$Config			= Config::instance();
-$L				= Language::instance();
+$Index = Index::instance();
+$Index->form = true;
+$Index->buttons = false;
+$Config = Config::instance();
+$L = Language::instance();
 $Page			= Page::instance();
 $User			= User::instance();
 $Page->css('components/modules/Feedback/includes/css/general.css');

Please login to merge, or discard this patch.

components/modules/Http_server/User.php 1 patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,17 +1,17 @@
 block discarded – undo
 <?php
 /**
- * @package   Http server
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2015, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Http server
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2015, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\custom;
 use
 	cs\User as User_original;
 /**
- * @inheritdoc
- */
+	 * @inheritdoc
+	 */
 class User extends User_original {
 	function construct () {
 		$this->memory_cache = false;

Please login to merge, or discard this patch.

components/modules/Http_server/custom_loader.php 2 patches

Indentation +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -1,15 +1,15 @@  discard block
 block discarded – undo
 <?php
 /**
- * @package   Http server
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2015, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Http server
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2015, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 /**
- * This is custom loader that includes basic files and defines constants,
- * but do not call any class to leave that all for Http server
- */
+	 * This is custom loader that includes basic files and defines constants,
+	 * but do not call any class to leave that all for Http server
+	 */
 namespace cs\modules\Http_server;
 require DIR.'/core/loader_base.php';             //Inclusion of loader base
 @ini_set('error_log', LOGS.'/Http_server.log');
@@ -20,8 +20,8 @@  discard block
 block discarded – undo
 require __DIR__.'/Config.php';                   //Inclusion of `cs\custom\Config` class, which is used instead original `cs\Config` for http server
 require __DIR__.'/User.php';                     //Inclusion of `cs\custom\User` class, which is used instead original `cs\User` for http server
 /**
- * Including of custom files
- */
+	 * Including of custom files
+	 */
 foreach (glob(CUSTOM.'/*.php') ?: [] as $custom) {
 	include $custom;
 }

Please login to merge, or discard this patch.

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -11,14 +11,14 @@
 block discarded – undo
  * but do not call any class to leave that all for Http server
  */
 namespace cs\modules\Http_server;
-require DIR.'/core/loader_base.php';             //Inclusion of loader base
+require DIR.'/core/loader_base.php'; //Inclusion of loader base
 @ini_set('error_log', LOGS.'/Http_server.log');
-require __DIR__.'/functions.php';                //Inclusion of functions needed for http server
+require __DIR__.'/functions.php'; //Inclusion of functions needed for http server
 \cs\Singleton\clean_classes_cache();
-require __DIR__.'/Request.php';                  //Inclusion of Request class, used for http server requests processing
-require __DIR__.'/Singleton.php';                //Inclusion of `Singleton` trait, specific for http server
-require __DIR__.'/Config.php';                   //Inclusion of `cs\custom\Config` class, which is used instead original `cs\Config` for http server
-require __DIR__.'/User.php';                     //Inclusion of `cs\custom\User` class, which is used instead original `cs\User` for http server
+require __DIR__.'/Request.php'; //Inclusion of Request class, used for http server requests processing
+require __DIR__.'/Singleton.php'; //Inclusion of `Singleton` trait, specific for http server
+require __DIR__.'/Config.php'; //Inclusion of `cs\custom\Config` class, which is used instead original `cs\Config` for http server
+require __DIR__.'/User.php'; //Inclusion of `cs\custom\User` class, which is used instead original `cs\User` for http server
 /**
  * Including of custom files
  */

Please login to merge, or discard this patch.

		@@ -28,8 +28,8 @@ discard block
		block discarded – undo
28	28	protected $shortname;
29	29
30	30	protected function construct () {
31		- $this->module = current_module();
32		- $this->shortname = Config::instance()->module('Disqus')->shortname;
	31	+ $this->module = current_module();
	32	+ $this->shortname = Config::instance()->module('Disqus')->shortname;
33	33	}
34	34	/**
35	35	* Set module (current module assumed by default)
		@@ -37,7 +37,7 @@ discard block
		block discarded – undo
37	37	* @param string $module Module name
38	38	*/
39	39	function set_module ($module) {
40		- $this->module = $module;
	40	+ $this->module = $module;
41	41	}
42	42	/**
43	43	* Count of comments for specified item
		@@ -74,11 +74,11 @@ discard block
		block discarded – undo
74	74	return '<div id="disqus_thread"></div>';
75	75	}
76	76	protected function count_js () {
77		- static $added = false;
	77	+ static $added = false;
78	78	if ($added) {
79	79	return;
80	80	}
81		- $added = true;
	81	+ $added = true;
82	82	Page::instance()->js(
83	83	"var disqus_shortname = '$this->shortname';
84	84	if (!window.disqus_count_items) { window.disqus_count_items = []; }",
		@@ -86,11 +86,11 @@ discard block
		block discarded – undo
86	86	);
87	87	}
88	88	protected function block_js ($item) {
89		- static $added = false;
	89	+ static $added = false;
90	90	if ($added) {
91	91	return;
92	92	}
93		- $added = true;
	93	+ $added = true;
94	94	Page::instance()->js(
95	95	"var disqus_shortname = '$this->shortname', disqus_identifier = '".str_replace("'", "\'", "$this->module/$item")."';",
96	96	'code'

		@@ -1,11 +1,11 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * @package Deferred tasks
4		- * @category modules
5		- * @author Nazar Mokrynskyi <[email protected]>
6		- * @copyright Copyright (c) 2013-2015, Nazar Mokrynskyi
7		- * @license MIT License, see license.txt
8		- */
	3	+ * @package Deferred tasks
	4	+ * @category modules
	5	+ * @author Nazar Mokrynskyi <[email protected]>
	6	+ * @copyright Copyright (c) 2013-2015, Nazar Mokrynskyi
	7	+ * @license MIT License, see license.txt
	8	+ */
9	9	namespace cs\modules\Deferred_tasks;
10	10	use
11	11	cs\ExitException,

		@@ -8,6 +8,6 @@
		block discarded – undo
8	8	*/
9	9	namespace cs;
10	10	if (isset($_POST['shortname'])) {
11		- Config::instance()->module('Disqus')->shortname = $_POST['shortname'];
	11	+ Config::instance()->module('Disqus')->shortname = $_POST['shortname'];
12	12	Index::instance()->save(true);
13	13	}

		@@ -1,18 +1,18 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * @package Disqus
4		- * @category modules
5		- * @author Nazar Mokrynskyi <[email protected]>
6		- * @copyright Copyright (c) 2013-2015, Nazar Mokrynskyi
7		- * @license MIT License, see license.txt
8		- */
	3	+ * @package Disqus
	4	+ * @category modules
	5	+ * @author Nazar Mokrynskyi <[email protected]>
	6	+ * @copyright Copyright (c) 2013-2015, Nazar Mokrynskyi
	7	+ * @license MIT License, see license.txt
	8	+ */
9	9	/**
10		- * Supports next events:
11		- * Comments/instance
12		- * [
13		- * 'Comments' => <i>&$Comments</i>
14		- * ]
15		- */
	10	+ * Supports next events:
	11	+ * Comments/instance
	12	+ * [
	13	+ * 'Comments' => <i>&$Comments</i>
	14	+ * ]
	15	+ */
16	16	namespace cs\modules\Disqus;
17	17	use
18	18	cs\Event;

		@@ -19,7 +19,7 @@
		block discarded – undo
19	19	Event::instance()->on(
20	20	'Comments/instance',
21	21	function ($data) {
22		- $data['Comments'] = Disqus::instance();
	22	+ $data['Comments'] = Disqus::instance();
23	23	return false;
24	24	}
25	25	);

		@@ -8,11 +8,11 @@
		block discarded – undo
8	8	*/
9	9	namespace cs;
10	10	use h;
11		-$Index = Index::instance();
12		-$Index->form = true;
13		-$Index->buttons = false;
14		-$Config = Config::instance();
15		-$L = Language::instance();
	11	+$Index = Index::instance();
	12	+$Index->form = true;
	13	+$Index->buttons = false;
	14	+$Config = Config::instance();
	15	+$L = Language::instance();
16	16	$Page = Page::instance();
17	17	$User = User::instance();
18	18	$Page->css('components/modules/Feedback/includes/css/general.css');

		@@ -1,17 +1,17 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * @package Http server
4		- * @category modules
5		- * @author Nazar Mokrynskyi <[email protected]>
6		- * @copyright Copyright (c) 2015, Nazar Mokrynskyi
7		- * @license MIT License, see license.txt
8		- */
	3	+ * @package Http server
	4	+ * @category modules
	5	+ * @author Nazar Mokrynskyi <[email protected]>
	6	+ * @copyright Copyright (c) 2015, Nazar Mokrynskyi
	7	+ * @license MIT License, see license.txt
	8	+ */
9	9	namespace cs\custom;
10	10	use
11	11	cs\User as User_original;
12	12	/**
13		- * @inheritdoc
14		- */
	13	+ * @inheritdoc
	14	+ */
15	15	class User extends User_original {
16	16	function construct () {
17	17	$this->memory_cache = false;

		@@ -1,15 +1,15 @@ discard block
		block discarded – undo
1	1	<?php
2	2	/**
3		- * @package Http server
4		- * @category modules
5		- * @author Nazar Mokrynskyi <[email protected]>
6		- * @copyright Copyright (c) 2015, Nazar Mokrynskyi
7		- * @license MIT License, see license.txt
8		- */
	3	+ * @package Http server
	4	+ * @category modules
	5	+ * @author Nazar Mokrynskyi <[email protected]>
	6	+ * @copyright Copyright (c) 2015, Nazar Mokrynskyi
	7	+ * @license MIT License, see license.txt
	8	+ */
9	9	/**
10		- * This is custom loader that includes basic files and defines constants,
11		- * but do not call any class to leave that all for Http server
12		- */
	10	+ * This is custom loader that includes basic files and defines constants,
	11	+ * but do not call any class to leave that all for Http server
	12	+ */
13	13	namespace cs\modules\Http_server;
14	14	require DIR.'/core/loader_base.php'; //Inclusion of loader base
15	15	@ini_set('error_log', LOGS.'/Http_server.log');
		@@ -20,8 +20,8 @@ discard block
		block discarded – undo
20	20	require __DIR__.'/Config.php'; //Inclusion of `cs\custom\Config` class, which is used instead original `cs\Config` for http server
21	21	require __DIR__.'/User.php'; //Inclusion of `cs\custom\User` class, which is used instead original `cs\User` for http server
22	22	/**
23		- * Including of custom files
24		- */
	23	+ * Including of custom files
	24	+ */
25	25	foreach (glob(CUSTOM.'/*.php') ?: [] as $custom) {
26	26	include $custom;
27	27	}

		@@ -11,14 +11,14 @@
		block discarded – undo
11	11	* but do not call any class to leave that all for Http server
12	12	*/
13	13	namespace cs\modules\Http_server;
14		-require DIR.'/core/loader_base.php'; //Inclusion of loader base
	14	+require DIR.'/core/loader_base.php'; //Inclusion of loader base
15	15	@ini_set('error_log', LOGS.'/Http_server.log');
16		-require __DIR__.'/functions.php'; //Inclusion of functions needed for http server
	16	+require __DIR__.'/functions.php'; //Inclusion of functions needed for http server
17	17	\cs\Singleton\clean_classes_cache();
18		-require __DIR__.'/Request.php'; //Inclusion of Request class, used for http server requests processing
19		-require __DIR__.'/Singleton.php'; //Inclusion of `Singleton` trait, specific for http server
20		-require __DIR__.'/Config.php'; //Inclusion of `cs\custom\Config` class, which is used instead original `cs\Config` for http server
21		-require __DIR__.'/User.php'; //Inclusion of `cs\custom\User` class, which is used instead original `cs\User` for http server
	18	+require __DIR__.'/Request.php'; //Inclusion of Request class, used for http server requests processing
	19	+require __DIR__.'/Singleton.php'; //Inclusion of `Singleton` trait, specific for http server
	20	+require __DIR__.'/Config.php'; //Inclusion of `cs\custom\Config` class, which is used instead original `cs\Config` for http server
	21	+require __DIR__.'/User.php'; //Inclusion of `cs\custom\User` class, which is used instead original `cs\User` for http server
22	22	/**
23	23	* Including of custom files
24	24	*/

nazar-pc / CleverStyle-Framework

Branch — master (0964ce)

Status

Category

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Indentation +11 added lines, -11 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch