Inspection of "Drop `password_hash` index and change its size to..." - nazar-pc/CleverStyle-Framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2676d9...a4ebee )

by Nazar

created 2016-02-23 21:26 UTC

Status

Indentation +20 added lines, -20 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@  discard block
 block discarded – undo
 <?php
 /**
- * @package   Uploader
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2015-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Uploader
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2015-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs;
 use Karwana\Mime\Mime;
 $L    = new Language\Prefix('uploader_');
@@ -13,14 +13,14 @@  discard block
 block discarded – undo
 $User = User::instance();
 interface_off();
 /**
- * File should be specified
- */
+	 * File should be specified
+	 */
 if (!isset($_FILES['file'])) {
 	throw new ExitException('File Not Specified', 400);
 }
 /**
- * Getting Uploader module configuration
- */
+	 * Getting Uploader module configuration
+	 */
 $module_data   = Config::instance()->module('Uploader');
 $max_file_size = (int)$module_data->max_file_size;
 switch (substr(strtolower($module_data->max_file_size), -2)) {
@@ -44,25 +44,25 @@  discard block
 block discarded – undo
 	throw new ExitException(500);
 }
 /**
- * Only registered users allowed
- */
+	 * Only registered users allowed
+	 */
 if (!$User->user()) {
 	throw new ExitException(403);
 }
 /**
- * Getting instances of storage and database
- */
+	 * Getting instances of storage and database
+	 */
 $storage = Storage::instance()->storage($module_data->storage('files'));
 /**
- * @var DB\_Abstract $cdb
- */
+	 * @var DB\_Abstract $cdb
+	 */
 $cdb = DB::instance()->db_prime($module_data->db('files'));
 if (!$storage || !$cdb) {
 	throw new ExitException(500);
 }
 /**
- * Moving file into storage
- */
+	 * Moving file into storage
+	 */
 if (!$module_data->directory_created) {
 	$storage->mkdir('Uploader');
 	$module_data->directory_created = 1;
@@ -82,8 +82,8 @@  discard block
 block discarded – undo
 	throw new ExitException(500);
 }
 /**
- * Registering file in database
- */
+	 * Registering file in database
+	 */
 if (!$cdb->q(
 	"INSERT INTO `[prefix]uploader_files`
 		(`user`, `uploaded`, `source`, `url`)

Please login to merge, or discard this patch.

components/modules/Photo_gallery/admin/galleries.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,9 +1,9 @@
 block discarded – undo
 <?php
 /**
- * @package		Photo gallery
- * @category	modules
- * @author		Nazar Mokrynskyi <[email protected]>
- * @copyright	Copyright (c) 2014-2016, Nazar Mokrynskyi
- * @license		MIT License, see license.txt
- */
+	 * @package		Photo gallery
+	 * @category	modules
+	 * @author		Nazar Mokrynskyi <[email protected]>
+	 * @copyright	Copyright (c) 2014-2016, Nazar Mokrynskyi
+	 * @license		MIT License, see license.txt
+	 */
 include __DIR__.'/galleries/save.php';

Please login to merge, or discard this patch.

components/modules/Photo_gallery/api/images.post.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   Photo gallery
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2013-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   Photo gallery
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2013-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs\modules\Photo_gallery;
 use
 	cs\ExitException,

Please login to merge, or discard this patch.

components/modules/OAuth2/admin/clients.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   OAuth2
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2014-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   OAuth2
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2014-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs;
 include __DIR__.'/clients/save.php';
 Index::instance()->form_attributes['is'] = 'cs-form';

Please login to merge, or discard this patch.

components/modules/OAuth2/invalidate_token.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package        OAuth2
- * @category       modules
- * @author         Nazar Mokrynskyi <[email protected]>
- * @copyright      Copyright (c) 2014-2016, Nazar Mokrynskyi
- * @license        MIT License, see license.txt
- */
+	 * @package        OAuth2
+	 * @category       modules
+	 * @author         Nazar Mokrynskyi <[email protected]>
+	 * @copyright      Copyright (c) 2014-2016, Nazar Mokrynskyi
+	 * @license        MIT License, see license.txt
+	 */
 namespace cs\modules\OAuth2;
 use
 	cs\ExitException;

Please login to merge, or discard this patch.

components/modules/OAuth2/events/uninstalled.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package		OAuth2
- * @category	modules
- * @author		Nazar Mokrynskyi <[email protected]>
- * @copyright	Copyright (c) 2013-2016, Nazar Mokrynskyi
- * @license		MIT License, see license.txt
- */
+	 * @package		OAuth2
+	 * @category	modules
+	 * @author		Nazar Mokrynskyi <[email protected]>
+	 * @copyright	Copyright (c) 2013-2016, Nazar Mokrynskyi
+	 * @license		MIT License, see license.txt
+	 */
 namespace	cs;
 Event::instance()->on(
 	'admin/System/components/modules/install/after',

Please login to merge, or discard this patch.

components/modules/HybridAuth/events.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package   HybridAuth
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
- * @license   MIT License, see license.txt
- */
+	 * @package   HybridAuth
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2011-2016, Nazar Mokrynskyi
+	 * @license   MIT License, see license.txt
+	 */
 namespace cs;
 Event::instance()->on(
 	'System/User/construct/after',

Please login to merge, or discard this patch.

components/modules/Disqus/events.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * @package        Comments
- * @category       modules
- * @author         Nazar Mokrynskyi <[email protected]>
- * @copyright      Copyright (c) 2011-2016, Nazar Mokrynskyi
- * @license        MIT License, see license.txt
- */
+	 * @package        Comments
+	 * @category       modules
+	 * @author         Nazar Mokrynskyi <[email protected]>
+	 * @copyright      Copyright (c) 2011-2016, Nazar Mokrynskyi
+	 * @license        MIT License, see license.txt
+	 */
 namespace cs;
 Event::instance()->on(
 	'System/Index/construct',

Please login to merge, or discard this patch.

components/modules/Plupload/index.php 1 patch

Indentation +20 added lines, -20 removed lines patch added patch discarded remove patch

@@ -1,19 +1,19 @@  discard block
 block discarded – undo
 <?php
 /**
- * @package   Plupload
- * @category  modules
- * @author    Nazar Mokrynskyi <[email protected]>
- * @copyright Copyright (c) 2013-2016, Nazar Mokrynskyi
- * @license   GNU GPL v2, see license.txt
- */
+	 * @package   Plupload
+	 * @category  modules
+	 * @author    Nazar Mokrynskyi <[email protected]>
+	 * @copyright Copyright (c) 2013-2016, Nazar Mokrynskyi
+	 * @license   GNU GPL v2, see license.txt
+	 */
 namespace cs;
 use Karwana\Mime\Mime;
 $Page = Page::instance();
 $User = User::instance();
 interface_off();
 /**
- * Only registered users allowed
- */
+	 * Only registered users allowed
+	 */
 if (!isset($_FILES['file'])) {
 	$Page->json(
 		[
@@ -28,8 +28,8 @@  discard block
 block discarded – undo
 	return;
 }
 /**
- * Getting Plupload module configuration
- */
+	 * Getting Plupload module configuration
+	 */
 $module_data   = Config::instance()->module('Plupload');
 $max_file_size = trim(strtolower($module_data->max_file_size), 'b');
 switch (substr($max_file_size, -1)) {
@@ -73,8 +73,8 @@  discard block
 block discarded – undo
 	return;
 }
 /**
- * Only registered users allowed
- */
+	 * Only registered users allowed
+	 */
 if (!$User->user()) {
 	$Page->json(
 		[
@@ -89,12 +89,12 @@  discard block
 block discarded – undo
 	return;
 }
 /**
- * Getting instances of storage and database
- */
+	 * Getting instances of storage and database
+	 */
 $storage = Storage::instance()->{$module_data->storage('files')};
 /**
- * @var DB\_Abstract $cdb
- */
+	 * @var DB\_Abstract $cdb
+	 */
 $cdb = DB::instance()->db_prime($module_data->db('files'));
 if (!$storage || !$cdb) {
 	$Page->json(
@@ -110,8 +110,8 @@  discard block
 block discarded – undo
 	return;
 }
 /**
- * Moving file into storage
- */
+	 * Moving file into storage
+	 */
 if (!$module_data->directory_created) {
 	$storage->mkdir('Plupload');
 	$module_data->directory_created = 1;
@@ -141,8 +141,8 @@  discard block
 block discarded – undo
 	return;
 }
 /**
- * Registering file in database
- */
+	 * Registering file in database
+	 */
 if (!$cdb->q(
 	"INSERT INTO `[prefix]plupload_files`
 		(`user`, `uploaded`, `source`, `url`)

Please login to merge, or discard this patch.

		@@ -1,11 +1,11 @@ discard block
		block discarded – undo
1	1	<?php
2	2	/**
3		- * @package Uploader
4		- * @category modules
5		- * @author Nazar Mokrynskyi <[email protected]>
6		- * @copyright Copyright (c) 2015-2016, Nazar Mokrynskyi
7		- * @license MIT License, see license.txt
8		- */
	3	+ * @package Uploader
	4	+ * @category modules
	5	+ * @author Nazar Mokrynskyi <[email protected]>
	6	+ * @copyright Copyright (c) 2015-2016, Nazar Mokrynskyi
	7	+ * @license MIT License, see license.txt
	8	+ */
9	9	namespace cs;
10	10	use Karwana\Mime\Mime;
11	11	$L = new Language\Prefix('uploader_');
		@@ -13,14 +13,14 @@ discard block
		block discarded – undo
13	13	$User = User::instance();
14	14	interface_off();
15	15	/**
16		- * File should be specified
17		- */
	16	+ * File should be specified
	17	+ */
18	18	if (!isset($_FILES['file'])) {
19	19	throw new ExitException('File Not Specified', 400);
20	20	}
21	21	/**
22		- * Getting Uploader module configuration
23		- */
	22	+ * Getting Uploader module configuration
	23	+ */
24	24	$module_data = Config::instance()->module('Uploader');
25	25	$max_file_size = (int)$module_data->max_file_size;
26	26	switch (substr(strtolower($module_data->max_file_size), -2)) {
		@@ -44,25 +44,25 @@ discard block
		block discarded – undo
44	44	throw new ExitException(500);
45	45	}
46	46	/**
47		- * Only registered users allowed
48		- */
	47	+ * Only registered users allowed
	48	+ */
49	49	if (!$User->user()) {
50	50	throw new ExitException(403);
51	51	}
52	52	/**
53		- * Getting instances of storage and database
54		- */
	53	+ * Getting instances of storage and database
	54	+ */
55	55	$storage = Storage::instance()->storage($module_data->storage('files'));
56	56	/**
57		- * @var DB\_Abstract $cdb
58		- */
	57	+ * @var DB\_Abstract $cdb
	58	+ */
59	59	$cdb = DB::instance()->db_prime($module_data->db('files'));
60	60	if (!$storage \|\| !$cdb) {
61	61	throw new ExitException(500);
62	62	}
63	63	/**
64		- * Moving file into storage
65		- */
	64	+ * Moving file into storage
	65	+ */
66	66	if (!$module_data->directory_created) {
67	67	$storage->mkdir('Uploader');
68	68	$module_data->directory_created = 1;
		@@ -82,8 +82,8 @@ discard block
		block discarded – undo
82	82	throw new ExitException(500);
83	83	}
84	84	/**
85		- * Registering file in database
86		- */
	85	+ * Registering file in database
	86	+ */
87	87	if (!$cdb->q(
88	88	"INSERT INTO `[prefix]uploader_files`
89	89	(`user`, `uploaded`, `source`, `url`)

		@@ -1,9 +1,9 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * @package Photo gallery
4		- * @category modules
5		- * @author Nazar Mokrynskyi <[email protected]>
6		- * @copyright Copyright (c) 2014-2016, Nazar Mokrynskyi
7		- * @license MIT License, see license.txt
8		- */
	3	+ * @package Photo gallery
	4	+ * @category modules
	5	+ * @author Nazar Mokrynskyi <[email protected]>
	6	+ * @copyright Copyright (c) 2014-2016, Nazar Mokrynskyi
	7	+ * @license MIT License, see license.txt
	8	+ */
9	9	include __DIR__.'/galleries/save.php';

		@@ -1,11 +1,11 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * @package Photo gallery
4		- * @category modules
5		- * @author Nazar Mokrynskyi <[email protected]>
6		- * @copyright Copyright (c) 2013-2016, Nazar Mokrynskyi
7		- * @license MIT License, see license.txt
8		- */
	3	+ * @package Photo gallery
	4	+ * @category modules
	5	+ * @author Nazar Mokrynskyi <[email protected]>
	6	+ * @copyright Copyright (c) 2013-2016, Nazar Mokrynskyi
	7	+ * @license MIT License, see license.txt
	8	+ */
9	9	namespace cs\modules\Photo_gallery;
10	10	use
11	11	cs\ExitException,

		@@ -1,19 +1,19 @@ discard block
		block discarded – undo
1	1	<?php
2	2	/**
3		- * @package Plupload
4		- * @category modules
5		- * @author Nazar Mokrynskyi <[email protected]>
6		- * @copyright Copyright (c) 2013-2016, Nazar Mokrynskyi
7		- * @license GNU GPL v2, see license.txt
8		- */
	3	+ * @package Plupload
	4	+ * @category modules
	5	+ * @author Nazar Mokrynskyi <[email protected]>
	6	+ * @copyright Copyright (c) 2013-2016, Nazar Mokrynskyi
	7	+ * @license GNU GPL v2, see license.txt
	8	+ */
9	9	namespace cs;
10	10	use Karwana\Mime\Mime;
11	11	$Page = Page::instance();
12	12	$User = User::instance();
13	13	interface_off();
14	14	/**
15		- * Only registered users allowed
16		- */
	15	+ * Only registered users allowed
	16	+ */
17	17	if (!isset($_FILES['file'])) {
18	18	$Page->json(
19	19	[
		@@ -28,8 +28,8 @@ discard block
		block discarded – undo
28	28	return;
29	29	}
30	30	/**
31		- * Getting Plupload module configuration
32		- */
	31	+ * Getting Plupload module configuration
	32	+ */
33	33	$module_data = Config::instance()->module('Plupload');
34	34	$max_file_size = trim(strtolower($module_data->max_file_size), 'b');
35	35	switch (substr($max_file_size, -1)) {
		@@ -73,8 +73,8 @@ discard block
		block discarded – undo
73	73	return;
74	74	}
75	75	/**
76		- * Only registered users allowed
77		- */
	76	+ * Only registered users allowed
	77	+ */
78	78	if (!$User->user()) {
79	79	$Page->json(
80	80	[
		@@ -89,12 +89,12 @@ discard block
		block discarded – undo
89	89	return;
90	90	}
91	91	/**
92		- * Getting instances of storage and database
93		- */
	92	+ * Getting instances of storage and database
	93	+ */
94	94	$storage = Storage::instance()->{$module_data->storage('files')};
95	95	/**
96		- * @var DB\_Abstract $cdb
97		- */
	96	+ * @var DB\_Abstract $cdb
	97	+ */
98	98	$cdb = DB::instance()->db_prime($module_data->db('files'));
99	99	if (!$storage \|\| !$cdb) {
100	100	$Page->json(
		@@ -110,8 +110,8 @@ discard block
		block discarded – undo
110	110	return;
111	111	}
112	112	/**
113		- * Moving file into storage
114		- */
	113	+ * Moving file into storage
	114	+ */
115	115	if (!$module_data->directory_created) {
116	116	$storage->mkdir('Plupload');
117	117	$module_data->directory_created = 1;
		@@ -141,8 +141,8 @@ discard block
		block discarded – undo
141	141	return;
142	142	}
143	143	/**
144		- * Registering file in database
145		- */
	144	+ * Registering file in database
	145	+ */
146	146	if (!$cdb->q(
147	147	"INSERT INTO `[prefix]plupload_files`
148	148	(`user`, `uploaded`, `source`, `url`)

nazar-pc / CleverStyle-Framework

Push — master ( 2676d9...a4ebee )

Status

Category

Indentation +20 added lines, -20 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +20 added lines, -20 removed lines patch added patch discarded remove patch