cs\modules\System\api\Controller\admin\upload::admin_upload_post()

Complexity

Conditions	12
Paths	11

Size

Total Lines	52
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	156

Importance

Changes

0

<?php
	public static function admin_upload_post () {
		$file = Request::instance()->files('file');
		if (!$file) {
			throw new ExitException(400);
		}
		$L = Language::prefix('system_admin_');
		switch ($file['error']) {
			case UPLOAD_ERR_INI_SIZE:
			case UPLOAD_ERR_FORM_SIZE:
				throw new ExitException($L->file_too_large, 400);

The property file_too_large does not exist on cs\Language\Prefix. Since you implemented __get, consider adding a @property annotation.

			case UPLOAD_ERR_NO_TMP_DIR:
				throw new ExitException($L->temporary_folder_is_missing, 400);

The property temporary_folder_is_missing does not exist on cs\Language\Prefix. Since you implemented __get, consider adding a @property annotation.

			case UPLOAD_ERR_CANT_WRITE:
				throw new ExitException($L->cant_write_file_to_disk, 500);

The property cant_write_file_to_disk does not exist on cs\Language\Prefix. Since you implemented __get, consider adding a @property annotation.

		}
		if ($file['error'] != UPLOAD_ERR_OK) {
			throw new ExitException(400);
		}
		$target_directory = TEMP.'/System/admin';
		if (!@mkdir($target_directory, 0770, true) && !is_dir($target_directory)) {
			throw new ExitException(500);
		}
		$tmp_filename = Session::instance()->get_id().'.phar';

Are you sure cs\Session::instance()->get_id() of type false|string can be used in concatenation?

		$tmp_location = "$target_directory/$tmp_filename";
		// Cleanup
		get_files_list(
			$target_directory,
			'/.*\.phar$/',
			'f',
			true,
			false,
			false,
			false,
			false,
			function ($file) {
				unlink($file);
			}
		);
		if (!copy($file['tmp_name'], $tmp_location)) {
			throw new ExitException(500);
		}
		$tmp_dir = "phar://$tmp_location";
		if (!file_exists("$tmp_dir/meta.json")) {
			unlink($tmp_location);
			throw new ExitException(400);
		}
		$meta = file_get_json("$tmp_dir/meta.json");
		if (!isset($meta['category'], $meta['package'], $meta['version'])) {
			unlink($tmp_location);
			throw new ExitException(400);
		}
		return $meta;
	}