nazar-pc /
CleverStyle-Framework
| Total Complexity | 63 |
| Total Lines | 412 |
| Duplicated Lines | 0 % |
| Coverage | 98.54% |
| Changes | 0 | ||
Complex classes like CRUD often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use CRUD, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 17 | trait CRUD { |
||
| 18 | use |
||
| 19 | Accessor, |
||
| 20 | Data_model_processing; |
||
| 21 | /** |
||
| 22 | * Create item |
||
| 23 | * |
||
| 24 | * @param array $arguments First element `id` can be omitted if it is autoincrement field |
||
| 25 | * |
||
| 26 | * @return false|int|string Id of created item on success, `false` otherwise |
||
| 27 | */ |
||
| 28 | 66 | protected function create (...$arguments) { |
|
| 29 | 66 | if (count($arguments) == 1 && !is_array(array_values($this->data_model)[1])) { |
|
| 30 | 54 | $arguments = $arguments[0]; |
|
| 31 | } |
||
| 32 | /** @noinspection ExceptionsAnnotatingAndHandlingInspection */ |
||
| 33 | 66 | $this->db_prime()->transaction( |
|
| 34 | 66 | function () use (&$id, $arguments) { |
|
| 35 | 66 | $id = $this->create_internal($this->table, $this->data_model, $arguments); |
|
| 36 | 66 | } |
|
| 37 | ); |
||
| 38 | 66 | return $id; |
|
| 39 | } |
||
| 40 | /** |
||
| 41 | * Create item |
||
| 42 | * |
||
| 43 | * @param string $table |
||
| 44 | * @param callable[]|string[] $data_model |
||
| 45 | * @param array $arguments First element `id` can be omitted if it is autoincrement field |
||
| 46 | * |
||
| 47 | * @return false|int|string Id of created item on success (or specified primary key), `false` otherwise |
||
| 48 | */ |
||
| 49 | 66 | private function create_internal ($table, $data_model, $arguments) { |
|
| 50 | 66 | $arguments = $this->fix_arguments_order($data_model, $arguments); |
|
| 51 | 66 | $insert_id = count($data_model) == count($arguments) ? $arguments[0] : false; |
|
| 52 | 66 | list($prepared_arguments, $joined_tables) = $this->crud_arguments_preparation( |
|
| 53 | 66 | $insert_id !== false ? $data_model : array_slice($data_model, 1), |
|
| 54 | 66 | $arguments, |
|
| 55 | 66 | $insert_id, |
|
| 56 | 66 | $update_needed |
|
| 57 | ); |
||
| 58 | 66 | $columns = '`'.implode('`,`', array_keys($prepared_arguments)).'`'; |
|
| 59 | 66 | $values = implode(',', array_fill(0, count($prepared_arguments), '?')); |
|
| 60 | 66 | $return = $this->db_prime()->q( |
|
| 61 | 66 | "INSERT IGNORE INTO `$table` |
|
| 62 | ( |
||
| 63 | 66 | $columns |
|
| 64 | ) VALUES ( |
||
| 65 | 66 | $values |
|
| 66 | )", |
||
| 67 | 66 | $prepared_arguments |
|
| 68 | ); |
||
| 69 | 66 | $id = $insert_id !== false ? $insert_id : $this->db_prime()->id(); |
|
| 70 | /** |
||
| 71 | * Id might be 0 if insertion failed or if we insert duplicate entry (which is fine since we use 'INSERT IGNORE' |
||
| 72 | */ |
||
| 73 | 66 | if (!$return || $id === 0) { |
|
|
introduced
by
|
|||
| 74 | return false; |
||
| 75 | } |
||
| 76 | 66 | $this->update_joined_tables($id, $joined_tables); |
|
| 77 | 66 | $this->find_update_files_tags($id, [], $arguments); |
|
| 78 | /** |
||
| 79 | * If on creation request without specified primary key and multilingual fields present - update needed |
||
| 80 | * after creation (there is no id before creation) |
||
| 81 | */ |
||
| 82 | 66 | if ($update_needed) { |
|
| 83 | 6 | $this->update_internal( |
|
| 84 | 6 | $table, |
|
| 85 | 6 | array_filter($data_model, [$this, 'format_without_data_model']), |
|
| 86 | 6 | array_merge([array_keys($data_model)[0] => $id], $prepared_arguments), |
|
| 87 | 6 | false |
|
| 88 | ); |
||
| 89 | } |
||
| 90 | 66 | return $id; |
|
| 91 | } |
||
| 92 | /** |
||
| 93 | * @param mixed $format |
||
| 94 | * |
||
| 95 | * @return bool |
||
| 96 | */ |
||
| 97 | 78 | private function format_without_data_model ($format) { |
|
| 98 | 78 | return !$this->format_with_data_model($format); |
|
| 99 | } |
||
| 100 | /** |
||
| 101 | * @param mixed $format |
||
| 102 | * |
||
| 103 | * @return bool |
||
| 104 | */ |
||
| 105 | 78 | private function format_with_data_model ($format) { |
|
| 106 | 78 | return is_array($format) && isset($format['data_model']); |
|
| 107 | } |
||
| 108 | /** |
||
| 109 | * @param int|string $id |
||
| 110 | * @param array $joined_tables |
||
| 111 | */ |
||
| 112 | 72 | private function update_joined_tables ($id, $joined_tables) { |
|
| 113 | 72 | $clang = $this->db_prime()->s(Language::instance()->clang, false); |
|
| 114 | /** |
||
| 115 | * At first we remove all old data |
||
| 116 | */ |
||
| 117 | 72 | foreach ($this->data_model as $table => $model) { |
|
| 118 | 72 | if ($this->format_without_data_model($model)) { |
|
| 119 | 72 | continue; |
|
| 120 | } |
||
| 121 | 12 | $id_field = array_keys($model['data_model'])[0]; |
|
| 122 | 12 | $language_field_condition = isset($model['language_field']) |
|
| 123 | 6 | ? "AND `$model[language_field]` = '$clang'" |
|
| 124 | 12 | : ''; |
|
| 125 | 12 | $this->db_prime()->q( |
|
| 126 | 12 | "DELETE FROM `{$this->table}_$table` |
|
| 127 | WHERE |
||
| 128 | 12 | `$id_field` = ? |
|
| 129 | 12 | $language_field_condition", |
|
| 130 | 12 | $id |
|
| 131 | ); |
||
| 132 | } |
||
| 133 | 72 | $id = $this->db_prime()->s($id, false); |
|
| 134 | /** |
||
| 135 | * Now walk through all tables and insert new valued |
||
| 136 | */ |
||
| 137 | 72 | foreach ($joined_tables as $table => $model) { |
|
| 138 | 12 | if (!@$model['data']) { |
|
| 139 | 9 | continue; |
|
| 140 | } |
||
| 141 | 12 | $fields = "`$model[id_field]`, "; |
|
| 142 | 12 | $values = "'$id'"; |
|
| 143 | 12 | if (isset($model['language_field'])) { |
|
| 144 | 6 | $fields .= "`$model[language_field]`, "; |
|
| 145 | 6 | $values .= ",'$clang'"; |
|
| 146 | } |
||
| 147 | 12 | $fields .= '`'.implode('`,`', array_keys($model['fields'])).'`'; |
|
| 148 | 12 | $values .= str_repeat(',?', count($model['fields'])); |
|
| 149 | 12 | $this->db_prime()->insert( |
|
| 150 | 12 | "INSERT INTO `{$this->table}_$table` |
|
| 151 | ( |
||
| 152 | 12 | $fields |
|
| 153 | ) VALUES ( |
||
| 154 | 12 | $values |
|
| 155 | )", |
||
| 156 | 12 | $model['data'] |
|
| 157 | ); |
||
| 158 | } |
||
| 159 | 72 | } |
|
| 160 | /** |
||
| 161 | * Read item |
||
| 162 | * |
||
| 163 | * @param int|int[]|string|string[] $id |
||
| 164 | * |
||
| 165 | * @return array|false |
||
| 166 | */ |
||
| 167 | 51 | protected function read ($id) { |
|
| 168 | /** @noinspection ExceptionsAnnotatingAndHandlingInspection */ |
||
| 169 | 51 | $this->db()->transaction( |
|
| 170 | 51 | function () use (&$result, $id) { |
|
| 171 | 51 | $result = $this->read_internal($this->table, $this->data_model, $id); |
|
| 172 | 51 | } |
|
| 173 | ); |
||
| 174 | 51 | return $result; |
|
| 175 | } |
||
| 176 | /** |
||
| 177 | * Read item |
||
| 178 | * |
||
| 179 | * @param string $table |
||
| 180 | * @param callable[]|string[] $data_model |
||
| 181 | * @param int|int[]|string|string[] $id |
||
| 182 | * |
||
| 183 | * @return array|false |
||
| 184 | */ |
||
| 185 | 69 | private function read_internal ($table, $data_model, $id) { |
|
| 221 | } |
||
| 222 | /** |
||
| 223 | * @param false|string|string[] $value |
||
| 224 | * @param callable|string $model |
||
| 225 | * |
||
| 226 | * @return array|false|float|int|string |
||
| 227 | */ |
||
| 228 | 72 | private function read_field_post_processing ($value, $model) { |
|
| 251 | } |
||
| 252 | /** |
||
| 253 | * @param int|string $id |
||
| 254 | * @param string $table |
||
| 255 | * @param array $model |
||
| 256 | * @param null|string $force_clang |
||
| 257 | * |
||
| 258 | * @return array |
||
| 259 | */ |
||
| 260 | 9 | private function read_joined_table ($id, $table, $model, $force_clang = null) { |
|
| 311 | } |
||
| 312 | /** |
||
| 313 | * Update item |
||
| 314 | * |
||
| 315 | * @param array $arguments |
||
| 316 | * |
||
| 317 | * @return bool |
||
| 318 | */ |
||
| 319 | 27 | protected function update (...$arguments) { |
|
| 320 | 27 | if (count($arguments) == 1) { |
|
| 321 | 15 | $arguments = $arguments[0]; |
|
| 322 | } |
||
| 323 | /** @noinspection ExceptionsAnnotatingAndHandlingInspection */ |
||
| 324 | 27 | $this->db_prime()->transaction( |
|
| 325 | 27 | function () use (&$result, $arguments) { |
|
| 326 | 27 | $result = $this->update_internal($this->table, $this->data_model, $arguments); |
|
| 327 | 27 | } |
|
| 328 | ); |
||
| 329 | 27 | return $result; |
|
| 330 | } |
||
| 331 | /** |
||
| 332 | * Update item |
||
| 333 | * |
||
| 334 | * @param string $table |
||
| 335 | * @param callable[]|string[] $data_model |
||
| 336 | * @param array $arguments |
||
| 337 | * @param bool $files_update |
||
| 338 | * |
||
| 339 | * @return bool |
||
| 340 | */ |
||
| 341 | 27 | private function update_internal ($table, $data_model, $arguments, $files_update = true) { |
|
| 375 | } |
||
| 376 | /** |
||
| 377 | * Delete item |
||
| 378 | * |
||
| 379 | * @param int|int[]|string|string[] $id |
||
| 380 | * |
||
| 381 | * @return bool |
||
| 382 | */ |
||
| 383 | 30 | protected function delete ($id) { |
|
| 384 | /** @noinspection ExceptionsAnnotatingAndHandlingInspection */ |
||
| 385 | 30 | $this->db_prime()->transaction( |
|
| 386 | 30 | function () use (&$result, $id) { |
|
| 387 | 30 | $result = $this->delete_internal($this->table, $this->data_model, $id); |
|
| 388 | 30 | } |
|
| 389 | ); |
||
| 390 | 30 | return $result; |
|
| 391 | } |
||
| 392 | /** |
||
| 393 | * Delete item |
||
| 394 | * |
||
| 395 | * @param string $table |
||
| 396 | * @param callable[]|string[] $data_model |
||
| 397 | * @param int|int[]|string|string[] $id |
||
| 398 | * |
||
| 399 | * @return bool |
||
| 400 | */ |
||
| 401 | 30 | private function delete_internal ($table, $data_model, $id) { |
|
| 429 | } |
||
| 430 | } |
||
| 431 |
Loading history...