MultiPartMotiveTrait - Code Metrics - Inspection of "End returning for Banco do Brasil" - naylonkessler/smart-cnab - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 95299a...ed19e2 )

by Naylon Kessler de

created 2017-03-01 21:19 UTC

MultiPartMotiveTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	2
lcom	1
cbo	0
dl	0
loc	20
rs	10
c	1
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	getMotives()	0	11	2

<?php

namespace SmartCNAB\Services\Returning;

use StdClass;

/**
 * Trait for mixin code that supports motive information with more than one part.
 */
trait MultiPartMotiveTrait
{
    /**
     * Fetch and return motives descriptions from received detail data.
     *
     * @param  \StdClass  $data
     * @return array
     */
    public function getMotives(StdClass $data)
    {
        $map = $this->supportBank->motives($data->occurrenceCode);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $parts = $this->parseMotiveParts($data);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $mapper = function ($motive) use ($map) {
            return empty($map[$motive]) ? null : $map[$motive];
        };

        return array_filter(array_map($mapper, $parts));
    }
}


1			<?php
2
3			namespace SmartCNAB\Services\Returning;
4
5			use StdClass;
6
7			/**
8			* Trait for mixin code that supports motive information with more than one part.
9			*/
10			trait MultiPartMotiveTrait
11			{
12			/**
13			* Fetch and return motives descriptions from received detail data.
14			*
15			* @param \StdClass $data
16			* @return array
17			*/
18			public function getMotives(StdClass $data)
19			{
20			$map = $this->supportBank->motives($data->occurrenceCode);
			0 ignored issues – show Bug introduced 2017-03-01 21:21 UTC by Report Bug Copy Issue Report The property `supportBank` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
21			$parts = $this->parseMotiveParts($data);
			0 ignored issues – show Bug introduced 2017-03-01 21:21 UTC by Report Bug Copy Issue Report It seems like `parseMotiveParts()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
22
23			$mapper = function ($motive) use ($map) {
24			return empty($map[$motive]) ? null : $map[$motive];
25			};
26
27			return array_filter(array_map($mapper, $parts));
28			}
29			}
30

naylonkessler / smart-cnab

Push — master ( 95299a...ed19e2 )

MultiPartMotiveTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like