navidonskis / silverstripe-language-editor

code/LangEditor.php

<?php

/**
 * @author    Donatas Navidonskis <donatas@navidonskis.com>
 * @since     2017
 * @class     LangEditor
 *
 */
class LangEditor extends LeftAndMain implements PermissionProvider {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

    /**
     * @var string
     * @config
     */
    private static $menu_title = 'Lang Editor';

Consider using a different property name as you override a private property of the parent class.

The property $menu_title is not used and could be removed.

    /**
     * @var string
     * @config
     */
    private static $url_segment = 'lang-editor';

Consider using a different property name as you override a private property of the parent class.

The property $url_segment is not used and could be removed.

    /**
     * @var float
     * @config
     */
    private static $menu_priority = -0.6;

Consider using a different property name as you override a private property of the parent class.

The property $menu_priority is not used and could be removed.

    /**
     * @var array
     * @config
     */
    private static $allowed_actions = [

Consider using a different property name as you override a private property of the parent class.

The property $allowed_actions is not used and could be removed.

        'FormEntities',
    ];

    /**
     * Default configuration of items per page.
     * Set "null" if unlimited.
     *
     * @var int
     * @config
     */
    private static $items_per_page = 30;

The property $items_per_page is not used and could be removed.

    /**
     * @return array
     */
    public function providePermissions() {
        $title = _t('LangEditor.MENU_TITLE', 'Lang Editor');

        return [
            "CMS_ACCESS_LangEditorAdmin" => [
                'name'     => _t('CMSMain.ACCESS', "Access to '{title}' section", ['title' => $title]),

array('title' => $title) is of type array<string,string,{"title":"string"}>, but the function expects a string.

                'category' => _t('Permission.CMS_ACCESS_CATEGORY', 'CMS Access'),
            ],
        ];
    }

    /**
     *
     * @param Member $member
     *
     * @return int|bool
     */
    public function canView($member = null) {
        return Permission::check('CMS_ACCESS_LangEditorAdmin', 'any', $member);

The expression \Permission::check('CMS_ACCESS_LangEditorAdmin', 'any', $member); of type boolean|string|null adds the type string to the return on line 67 which is incompatible with the return type of the parent method LeftAndMain::canView of type boolean.

    }

    public function init() {
        static::config()->menu_title = _t('LangEditor.MENU_TITLE', 'Lang Editor');

        return parent::init();
    }

    public static function flushCache() {
        $cache = SS_Cache::factory(static::class);
        $cache->clean(Zend_Cache::CLEANING_MODE_ALL);
    }

    public function getModules() {
        $list = new ArrayList();
        $parameters = $this->getRequest()->getVars();

        unset($parameters['url']);
        unset($parameters['start']);
        unset($parameters['search']);

        LangModule::get()->each(function (LangModule $module) use ($parameters, &$list) {
            if (array_key_exists('moduleId', $parameters) && $parameters['moduleId'] == $module->ID) {
                $module->Current = true;

The property Current does not exist on object<LangModule>. Since you implemented __set, maybe consider adding a @property annotation.

            }

            $parameters['moduleId'] = $module->ID;

            $module->Link = Controller::join_links(

The property Link does not exist on object<LangModule>. Since you implemented __set, maybe consider adding a @property annotation.

                Controller::curr()->Link(),
                "?".http_build_query($parameters)
            );

            $list->push($module);
        });

        if (! $list->filter('Current', true)->first() && $list->count() > 0) {
            $list->first()->Current = true;
        }

        return $list;
    }

    public function getCurrentModule() {
        return $this->getModules()->filter('Current', true)->first();
    }

    public function getCurrentSearchTerm() {
        return $this->getRequest()->getVar('search');
    }

    public function FormEntities() {
        /** @var LangModule $module */
        if ($module = $this->getModules()->filter('Current', true)->first()) {
            $entities = $module->Entities();
            $searchTerm = $this->getRequest()->getVar('search');

            if (! empty($searchTerm)) {
                $entities = $entities->filter('SearchFields:LangFulltextBoolean', $searchTerm);
            }

            $parameters = $this->getRequest()->getVars();

            unset($parameters['url']);

            $parameters = count($parameters) > 0 ? '?'.http_build_query($parameters) : '';

            $form = new FormEntities(Controller::curr(), __FUNCTION__, $entities);
            $form->clearMessage();
            $form->setFormAction(Controller::join_links(
                $this->Link('FormEntities'),
                $parameters
            ));

            return $form;
        }

        return false;
    }
}