Sniffer::sniffFiles() - Code Metrics - Inspection of "Make SnifferParser's functions static" - natanmoraes/sniffer-report-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (6be85c)

by Natan

created 2017-05-08 23:31 UTC

Sniffer::sniffFiles() A

↳ Parent: Sniffer

Complexity

Conditions	3
Paths	3

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	13
rs	9.4285
cc	3
eloc	8
nc	3
nop	3

<?php

namespace SnifferReport\Service;

abstract class Sniffer
{
    /**
     * Run PHPCS on given files.
     *
     * @param array $files
     * @param string $standards
     * @param string $extensions
     *
     * @return array
     */
    public static function sniffFiles(array $files, $standards = '', $extensions = '')
    {
        $results = [];
        foreach ($files as $file) {
            $sniff_result = self::sniffFile($file, $standards, $extensions);
            if (is_null($sniff_result)) {
                continue;
            }
            $results[$file] = $sniff_result->$file;
        }

        return $results;
    }

    /**
     * Run PHPCS in a single file.
     *
     * @param $file
     * @param string $standards
     * @param string $extensions
     *
     * @return string|null
     */
    private static function sniffFile($file, $standards = '', $extensions = '')
    {
        $command = COMPOSER_VENDOR_DIR . '/bin/phpcs';

        if (!empty($standards)) {
            $command .= " --standard=$standards";
        }

        // @fixme: handle extensions properly (ex: the code is trying to sniff a .json file)
        if (!empty($extensions)) {
            $command .= " --extensions=$extensions";
        }

        $command .= ' --report=json';

        $command .= " $file";

        $command = escapeshellcmd($command);

        // Run phpcs and grab the output.
        exec($command, $output);

        if (is_null($output)) {
            return null;
        }

        $result = json_decode(reset($output));

        return $result->files;
    }
}


1			<?php
2
3			namespace SnifferReport\Service;
4
5			abstract class Sniffer
6			{
7			/**
8			* Run PHPCS on given files.
9			*
10			* @param array $files
11			* @param string $standards
12			* @param string $extensions
13			*
14			* @return array
15			*/
16			public static function sniffFiles(array $files, $standards = '', $extensions = '')
17			{
18			$results = [];
19			foreach ($files as $file) {
20			$sniff_result = self::sniffFile($file, $standards, $extensions);
21			if (is_null($sniff_result)) {
22			continue;
23			}
24			$results[$file] = $sniff_result->$file;
25			}
26
27			return $results;
28			}
29
30			/**
31			* Run PHPCS in a single file.
32			*
33			* @param $file
34			* @param string $standards
35			* @param string $extensions
36			*
37			* @return string\|null
38			*/
39			private static function sniffFile($file, $standards = '', $extensions = '')
40			{
41			$command = COMPOSER_VENDOR_DIR . '/bin/phpcs';
42
43			if (!empty($standards)) {
44			$command .= " --standard=$standards";
45			}
46
47			// @fixme: handle extensions properly (ex: the code is trying to sniff a .json file)
48			if (!empty($extensions)) {
49			$command .= " --extensions=$extensions";
50			}
51
52			$command .= ' --report=json';
53
54			$command .= " $file";
55
56			$command = escapeshellcmd($command);
57
58			// Run phpcs and grab the output.
59			exec($command, $output);
60
61			if (is_null($output)) {
62			return null;
63			}
64
65			$result = json_decode(reset($output));
66
67			return $result->files;
68			}
69			}
70

natanmoraes / sniffer-report-api

Branch — master (6be85c)

Sniffer::sniffFiles() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like