| Conditions | 10 |
| Paths | 28 |
| Total Lines | 66 |
| Code Lines | 40 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 30 | public static function processSniff(Application $app, Request $request) |
||
|
1 ignored issue
–
show
|
|||
| 31 | { |
||
| 32 | $file = $request->files->get('file'); |
||
| 33 | $git_url = $request->get('git_url'); |
||
| 34 | $options = $request->get('options'); |
||
| 35 | |||
| 36 | $valid_git_url = (is_null($git_url) || !Validator::isGitUrl($git_url)); |
||
| 37 | if ($valid_git_url && is_null($file)) { |
||
| 38 | throw new SnifferReportException('File or Git URL required', 400); |
||
| 39 | } |
||
| 40 | |||
| 41 | if (!is_null($file)) { |
||
| 42 | $file_name = $file->getClientOriginalName(); |
||
| 43 | $file->move(FILES_DIRECTORY_ROOT, $file_name); |
||
| 44 | $files = FilesHandler::handle($file_name, $file->getClientMimeType()); |
||
| 45 | } else { |
||
| 46 | try { |
||
| 47 | $files = GitHandler::handle($git_url); |
||
| 48 | } catch (Exception $e) { |
||
| 49 | throw new SnifferReportException("Error when trying to clone git repository: {$e->getMessage()}", 500); |
||
| 50 | } |
||
| 51 | } |
||
| 52 | |||
| 53 | // @fixme Temporary |
||
| 54 | if (empty($options)) { |
||
| 55 | throw new SnifferReportException( |
||
| 56 | 'Missing options', |
||
| 57 | 400 |
||
| 58 | ); |
||
| 59 | } |
||
| 60 | |||
| 61 | $options = json_decode($options); |
||
| 62 | |||
| 63 | if (!Validator::areStandardsValid($options->standards)) { |
||
| 64 | throw new SnifferReportException( |
||
| 65 | 'One or more standards are not valid. Please try again with different values', |
||
| 66 | 400 |
||
| 67 | ); |
||
| 68 | } |
||
| 69 | |||
| 70 | if (!Validator::areExtensionsValid($options->extensions)) { |
||
| 71 | throw new SnifferReportException( |
||
| 72 | 'One or more extensions are not valid. Please try again with different values', |
||
| 73 | 400 |
||
| 74 | ); |
||
| 75 | } |
||
| 76 | |||
| 77 | $standards = implode(',', $options->standards); |
||
| 78 | $extensions = implode(',', $options->extensions); |
||
| 79 | |||
| 80 | $sniff_result = Sniffer::sniffFiles($files, $standards, $extensions); |
||
| 81 | |||
| 82 | // Delete all files that were generated in this request. |
||
| 83 | $fs = new Filesystem(); |
||
| 84 | $fs->remove(FILES_DIRECTORY_ROOT); |
||
| 85 | |||
| 86 | try { |
||
| 87 | // @todo: Make class abstract |
||
| 88 | $sniffParser = new SniffParser(); |
||
| 89 | $response = $sniffParser->parseSniff($sniff_result); |
||
| 90 | } catch (\PDOException $e) { |
||
| 91 | throw new SnifferReportException("Error when trying to save sniff: {$e->getMessage()}", 500); |
||
| 92 | } |
||
| 93 | |||
| 94 | return $response; |
||
| 95 | } |
||
| 96 | } |
||
| 97 |
This check looks from parameters that have been defined for a function or method, but which are not used in the method body.