AppKernel::setupServices() - Code Metrics - nastoletni/code - Measure and Improve Code Quality continuously with Scrutinizer

AppKernel::setupServices() B
last analyzed 2018-12-28 17:31 UTC

↳ Parent: AppKernel

Complexity

Conditions	3
Paths	1

Size

Total Lines

105

Duplication

Lines	22
Ratio	20.95 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	22
loc	105
ccs	0
cts	91
cp	0
rs	8
c	0
b	0
f	0
cc	3
nc	1
nop	0
crap	12

How to fix Long Method

<?php

declare(strict_types=1);

namespace Nastoletni\Code;

use Doctrine\DBAL\Configuration;
use Doctrine\DBAL\DriverManager;
use Monolog\Handler\StreamHandler;
use Monolog\Logger;
use Nastoletni\Code\Infrastructure\AES256Crypter;
use Nastoletni\Code\Infrastructure\Dbal\DbalPasteMapper;
use Nastoletni\Code\Infrastructure\Dbal\DbalPasteRepository;
use Nastoletni\Code\Infrastructure\HttpsXkcdRepository;
use Nastoletni\Code\Slim\DecoratingCallableResolver;
use Nastoletni\Code\Slim\Middleware\SymfonySessionMiddleware;
use Nastoletni\Code\Twig\SymfonyValidatorExtension;
use Nastoletni\Code\Twig\TransExtension;
use Nastoletni\Code\UserInterface\Controller\ControllerDecorator;
use Nastoletni\Code\UserInterface\Web\Controller\ErrorController;
use Nastoletni\Code\UserInterface\Web\Controller\PasteController;
use Slim\App;
use Slim\Container;
use Slim\Handlers\Error;
use Slim\Handlers\PhpError;
use Slim\Handlers\Strategies\RequestResponseArgs;
use Slim\Views\Twig;
use Slim\Views\TwigExtension;
use Symfony\Component\HttpFoundation\Session\Session;
use Symfony\Component\Translation\Loader\PhpFileLoader;
use Symfony\Component\Translation\Translator;
use Symfony\Component\Yaml\Yaml;

class AppKernel
{
    /**
     * @var App
     */
    private $slim;

    /**
     * AppKernel constructor.
     */
    public function __construct()
    {
        $this->slim = new App();

        $this->setupConfig();
        $this->setupServices();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        $this->setupRoutes();

        // Middlewares
        $this->slim->add(new SymfonySessionMiddleware($this->slim->getContainer()['session']));
    }

    /**
     * Sets up config in container.
     */
    private function setupConfig(): void
    {
        $config = Yaml::parse(file_get_contents(__DIR__.'/config.yml'));

        $this->slim->getContainer()['config'] = $config;
    }

    /**
     * Sets up dependencies in container.
     */
    private function setupServices(): void
    {
        $container = $this->slim->getContainer();
        $container['settings']['displayErrorDetails'] = $container['config']['debug'];
        $container['logger'] = function () {
            return new Logger('application', [
                new StreamHandler(__DIR__.'/../logs/logs.log'),
            ]);
        };
        $container['foundHandler'] = function () {
            return new RequestResponseArgs();
        };
        $container['notFoundHandler'] = function (Container $container) {
            return [$container[ErrorController::class], 'notFound'];
        };
        $container['errorHandler'] = function (Container $container) {

            // Show pretty error page on production and Slim debug info on development.
            $next = $container['config']['debug'] ?
                new Error($container['config']['debug']) :
                [$container[ErrorController::class], 'error'];

            return new Slim\Handler\LoggingErrorHandler(
                $container->get('logger'),
                $next
            );
        };
        $container['phpErrorHandler'] = function (Container $container) {

            // Show pretty error page on production and Slim debug info on development.
            $next = $container['config']['debug'] ?
                new PhpError($container['config']['debug']) :
                [$container[ErrorController::class], 'error'];

            return new Slim\Handler\LoggingErrorHandler(
                $container->get('logger'),
                $next
            );
        };
        $container['translator'] = function (Container $container) {
            $translator = new Translator($container['config']['locale']);
            $translator->setFallbackLocales(['en']);

            $translator->addLoader('php', new PhpFileLoader());
            $translator->addResource('php', __DIR__.'/../resources/translations/messages.php', 'en');
            $translator->addResource('php', __DIR__.'/../resources/translations/messages.pl.php', 'pl');

            return $translator;
        };
        $container['twig'] = function (Container $container) {
            $twig = new Twig(__DIR__.'/../resources/views/', [
                'debug' => $container['config']['debug'],
            ]);
            $twig->addExtension(new TwigExtension($container['router'], $container['config']['base_url']));
            $twig->addExtension(new SymfonyValidatorExtension());
            $twig->addExtension(new TransExtension($container['translator']));

            return $twig;
        };
        $container['session'] = function () {
            return new Session();
        };
        $container['controllerDecorator'] = function (Container $container) {
            return new ControllerDecorator(
                $container['twig'],
                $container['router'],
                $container['session']
            );
        };
        $container['callableResolver'] = function (Container $container) {
            return new DecoratingCallableResolver(
                $container,
                $container['controllerDecorator']
            );
        };
        $container['dbal'] = function (Container $container) {
            $config = new Configuration();

            return DriverManager::getConnection([
                'driver'   => 'pdo_mysql',
                'host'     => $container['config']['database']['host'],
                'port'     => $container['config']['database']['port'],
                'dbname'   => $container['config']['database']['name'],
                'user'     => $container['config']['database']['user'],
                'password' => $container['config']['database']['password'],
                'charset'  => $container['config']['database']['charset'],
            ], $config);
        };

        // Controllers
        $container[PasteController::class] = function (Container $container) {
            $pasteRepository = new DbalPasteRepository($container['dbal'], new DbalPasteMapper());

            return new PasteController($pasteRepository, new AES256Crypter());
        };
        $container[ErrorController::class] = function (Container $container) {
            /** @var ControllerDecorator $controllerDecorator */
            $controllerDecorator = $container['controllerDecorator'];

            $errorController = new ErrorController(
                new HttpsXkcdRepository()
            );
            $controllerDecorator->decorate($errorController);

            return $errorController;
        };
    }

    /**
     * Sets up routes.
     */
    private function setupRoutes(): void
    {
        $routes = Yaml::parse(file_get_contents(__DIR__.'/routes.yml'));

        foreach ($routes as $routeName => $route) {
            $this->slim->map([$route['method']], $route['path'], $route['controller'])->setName($routeName);
        }
    }

    /**
     * Sends response to the client.
     */
    public function handle(): void
    {
        $this->slim->run();
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Nastoletni\Code;
6
7		use Doctrine\DBAL\Configuration;
8		use Doctrine\DBAL\DriverManager;
9		use Monolog\Handler\StreamHandler;
10		use Monolog\Logger;
11		use Nastoletni\Code\Infrastructure\AES256Crypter;
12		use Nastoletni\Code\Infrastructure\Dbal\DbalPasteMapper;
13		use Nastoletni\Code\Infrastructure\Dbal\DbalPasteRepository;
14		use Nastoletni\Code\Infrastructure\HttpsXkcdRepository;
15		use Nastoletni\Code\Slim\DecoratingCallableResolver;
16		use Nastoletni\Code\Slim\Middleware\SymfonySessionMiddleware;
17		use Nastoletni\Code\Twig\SymfonyValidatorExtension;
18		use Nastoletni\Code\Twig\TransExtension;
19		use Nastoletni\Code\UserInterface\Controller\ControllerDecorator;
20		use Nastoletni\Code\UserInterface\Web\Controller\ErrorController;
21		use Nastoletni\Code\UserInterface\Web\Controller\PasteController;
22		use Slim\App;
23		use Slim\Container;
24		use Slim\Handlers\Error;
25		use Slim\Handlers\PhpError;
26		use Slim\Handlers\Strategies\RequestResponseArgs;
27		use Slim\Views\Twig;
28		use Slim\Views\TwigExtension;
29		use Symfony\Component\HttpFoundation\Session\Session;
30		use Symfony\Component\Translation\Loader\PhpFileLoader;
31		use Symfony\Component\Translation\Translator;
32		use Symfony\Component\Yaml\Yaml;
33
34		class AppKernel
35		{
36		/**
37		* @var App
38		*/
39		private $slim;
40
41		/**
42		* AppKernel constructor.
43		*/
44		public function __construct()
45		{
46		$this->slim = new App();
47
48		$this->setupConfig();
49		$this->setupServices();
		0 ignored issues – show Unused Code introduced 2017-06-13 22:06 UTC by Report Bug Copy Issue Report The call to the method `Nastoletni\Code\AppKernel::setupServices()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
50		$this->setupRoutes();
51
52		// Middlewares
53		$this->slim->add(new SymfonySessionMiddleware($this->slim->getContainer()['session']));
54		}
55
56		/**
57		* Sets up config in container.
58		*/
59		private function setupConfig(): void
60		{
61		$config = Yaml::parse(file_get_contents(__DIR__.'/config.yml'));
62
63		$this->slim->getContainer()['config'] = $config;
64		}
65
66		/**
67		* Sets up dependencies in container.
68		*/
69		private function setupServices(): void
70		{
71		$container = $this->slim->getContainer();
72		$container['settings']['displayErrorDetails'] = $container['config']['debug'];
73		$container['logger'] = function () {
74		return new Logger('application', [
75		new StreamHandler(__DIR__.'/../logs/logs.log'),
76		]);
77		};
78		$container['foundHandler'] = function () {
79		return new RequestResponseArgs();
80		};
81		$container['notFoundHandler'] = function (Container $container) {
82		return [$container[ErrorController::class], 'notFound'];
83		};
84	View Code Duplication	$container['errorHandler'] = function (Container $container) {
		0 ignored issues – show Duplication introduced 2017-06-13 22:06 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
85		// Show pretty error page on production and Slim debug info on development.
86		$next = $container['config']['debug'] ?
87		new Error($container['config']['debug']) :
88		[$container[ErrorController::class], 'error'];
89
90		return new Slim\Handler\LoggingErrorHandler(
91		$container->get('logger'),
92		$next
93		);
94		};
95	View Code Duplication	$container['phpErrorHandler'] = function (Container $container) {
		0 ignored issues – show Duplication introduced 2017-06-13 22:06 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
96		// Show pretty error page on production and Slim debug info on development.
97		$next = $container['config']['debug'] ?
98		new PhpError($container['config']['debug']) :
99		[$container[ErrorController::class], 'error'];
100
101		return new Slim\Handler\LoggingErrorHandler(
102		$container->get('logger'),
103		$next
104		);
105		};
106		$container['translator'] = function (Container $container) {
107		$translator = new Translator($container['config']['locale']);
108		$translator->setFallbackLocales(['en']);
109
110		$translator->addLoader('php', new PhpFileLoader());
111		$translator->addResource('php', __DIR__.'/../resources/translations/messages.php', 'en');
112		$translator->addResource('php', __DIR__.'/../resources/translations/messages.pl.php', 'pl');
113
114		return $translator;
115		};
116		$container['twig'] = function (Container $container) {
117		$twig = new Twig(__DIR__.'/../resources/views/', [
118		'debug' => $container['config']['debug'],
119		]);
120		$twig->addExtension(new TwigExtension($container['router'], $container['config']['base_url']));
121		$twig->addExtension(new SymfonyValidatorExtension());
122		$twig->addExtension(new TransExtension($container['translator']));
123
124		return $twig;
125		};
126		$container['session'] = function () {
127		return new Session();
128		};
129		$container['controllerDecorator'] = function (Container $container) {
130		return new ControllerDecorator(
131		$container['twig'],
132		$container['router'],
133		$container['session']
134		);
135		};
136		$container['callableResolver'] = function (Container $container) {
137		return new DecoratingCallableResolver(
138		$container,
139		$container['controllerDecorator']
140		);
141		};
142		$container['dbal'] = function (Container $container) {
143		$config = new Configuration();
144
145		return DriverManager::getConnection([
146		'driver' => 'pdo_mysql',
147		'host' => $container['config']['database']['host'],
148		'port' => $container['config']['database']['port'],
149		'dbname' => $container['config']['database']['name'],
150		'user' => $container['config']['database']['user'],
151		'password' => $container['config']['database']['password'],
152		'charset' => $container['config']['database']['charset'],
153		], $config);
154		};
155
156		// Controllers
157		$container[PasteController::class] = function (Container $container) {
158		$pasteRepository = new DbalPasteRepository($container['dbal'], new DbalPasteMapper());
159
160		return new PasteController($pasteRepository, new AES256Crypter());
161		};
162		$container[ErrorController::class] = function (Container $container) {
163		/** @var ControllerDecorator $controllerDecorator */
164		$controllerDecorator = $container['controllerDecorator'];
165
166		$errorController = new ErrorController(
167		new HttpsXkcdRepository()
168		);
169		$controllerDecorator->decorate($errorController);
170
171		return $errorController;
172		};
173		}
174
175		/**
176		* Sets up routes.
177		*/
178		private function setupRoutes(): void
179		{
180		$routes = Yaml::parse(file_get_contents(__DIR__.'/routes.yml'));
181
182		foreach ($routes as $routeName => $route) {
183		$this->slim->map([$route['method']], $route['path'], $route['controller'])->setName($routeName);
184		}
185		}
186
187		/**
188		* Sends response to the client.
189		*/
190		public function handle(): void
191		{
192		$this->slim->run();
193		}
194		}
195

nastoletni / code

AppKernel::setupServices() B last analyzed 2018-12-28 17:31 UTC

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

AppKernel::setupServices() B
last analyzed 2018-12-28 17:31 UTC