Nastoletni\Code\UserInterface\Web\Controller\PasteController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	111
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	13

Test Coverage

Coverage

0%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	home()	0	7	1
A	create()	0	29	2
A	paste()	0	20	3

<?php

declare(strict_types=1);

namespace Nastoletni\Code\UserInterface\Web\Controller;

use Nastoletni\Code\Application\Crypter\CrypterException;
use Nastoletni\Code\Application\Crypter\PasteCrypter;
use Nastoletni\Code\Application\Form\CreatePasteFormValidator;
use Nastoletni\Code\Application\Service\CreatePasteService;
use Nastoletni\Code\Domain\Paste\Id;
use Nastoletni\Code\Domain\Paste\NotExistsException;
use Nastoletni\Code\Domain\PasteRepository;
use Nastoletni\Code\UserInterface\Controller\AbstractController;
use Psr\Http\Message\ResponseInterface as Response;
use Psr\Http\Message\ServerRequestInterface as Request;
use Slim\Exception\NotFoundException;

class PasteController extends AbstractController
{
    /**
     * @var PasteRepository
     */
    private $pasteRepository;

    /**
     * @var PasteCrypter
     */
    private $pasteCrypter;

    /**
     * PasteController constructor.
     *
     * @param PasteRepository $pasteRepository
     * @param PasteCrypter    $pasteCrypter
     */
    public function __construct(PasteRepository $pasteRepository, PasteCrypter $pasteCrypter)
    {
        $this->pasteRepository = $pasteRepository;
        $this->pasteCrypter = $pasteCrypter;
    }

    /**
     * home: GET /.
     *
     * @param Request  $request
     * @param Response $response
     *
     * @return Response
     */
    public function home(Request $request, Response $response): Response

The parameter $request is not used and could be removed.

    {
        return $this->twig->render($response, 'home.twig', [
            'errors' => $this->getFlash('errors'),
            'old'    => $this->getFlash('old'),
        ]);
    }

    /**
     * create: POST /.
     *
     * @param Request  $request
     * @param Response $response
     *
     * @return Response
     */
    public function create(Request $request, Response $response): Response
    {
        $data = $request->getParsedBody();

        $validator = CreatePasteFormValidator::create();

        $errors = $validator->validate($data);

It seems like $data defined by $request->getParsedBody() on line 69 can also be of type null or object; however, Nastoletni\Code\Application\Form\CreatePasteFormValidator::validate() does only seem to accept array, maybe add an additional type check?

        if (count($errors) > 0) {
            $this->flash('errors', $errors);
            $this->flash('old', $data);

            return $response
                ->withStatus(302)
                ->withHeader('Location', $this->router->relativePathFor('home'));
        }

        $createPasteService = new CreatePasteService($this->pasteRepository, $this->pasteCrypter);
        $payload = $createPasteService->handle($data);

It seems like $data defined by $request->getParsedBody() on line 69 can also be of type null or object; however, Nastoletni\Code\Application\Service\CreatePasteService::handle() does only seem to accept array, maybe add an additional type check?

        $paste = $payload->getPaste();

        return $response
            ->withStatus(302)
            ->withHeader('Location', $this->router->relativePathFor('paste', [
                'id'  => $paste->getId()->getBase62Id(),
                'key' => $payload->getEncryptionKey(),
            ]));
    }

    /**
     * paste: GET /{id}/{key}.
     *
     * @param Request  $request
     * @param Response $response
     * @param string   $id
     * @param string   $key
     *
     * @throws NotFoundException
     *
     * @return Response
     */
    public function paste(Request $request, Response $response, string $id, string $key): Response
    {
        try {
            $paste = $this->pasteRepository->getById(Id::createFromBase62($id));
        } catch (NotExistsException $e) {
            throw new NotFoundException($request, $response);
        }

        try {
            $this->pasteCrypter->decrypt($paste, $key);
        } catch (CrypterException $e) {
            // CrypterException is almost always when user has modified
            // encryption key in the URL and that is considered as not found.
            throw new NotFoundException($request, $response);
        }

        return $this->twig->render($response, 'paste.twig', [
            'paste' => $paste,
        ]);
    }
}