DonorRepository::findCompatibleRedBloodCellGroup() - Code Metrics - Inspection of "Reduce DonorRepository->parseCriteria() code compl..." - nash-ye/ebloodbank - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c04040...869fe9 )

by Nashwan

created 2019-09-07 09:58 UTC

DonorRepository::findCompatibleRedBloodCellGroup() B

↳ Parent: DonorRepository

Complexity

Conditions	10
Paths	10

Size

Total Lines	35
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	10
eloc	30
c	1
b	0
f	0
nc	10
nop	1
dl	0
loc	35
rs	7.6666

How to fix Complexity

<?php
/**
 * Donor entity repository class file
 *
 * @package    EBloodBank
 * @subpackage Models
 * @since      1.0
 */
namespace EBloodBank\Models;

use EBloodBank as EBB;

/**
 * Donor entity repository class
 *
 * @since 1.0
 */
class DonorRepository extends EntityRepository
{
    /**
     * Finds entities by a set of criteria.
     *
     * @param array      $criteria
     * @param array|null $orderBy
     * @param int|null   $limit
     * @param int|null   $offset
     *
     * @return array The objects.
     */
    public function findBy(array $criteria, array $orderBy = null, $limit = null, $offset = null)
    {
        $criteria = $this->parseCriteria($criteria);
        return parent::findBy($criteria, $orderBy, $limit, $offset);
    }

    /**
     * Finds a single entity by a set of criteria.
     *
     * @param array $criteria
     * @param array|null $orderBy
     *
     * @return object|null The entity instance or NULL if the entity can not be found.
     */
    public function findOneBy(array $criteria, array $orderBy = null)
    {
        $criteria = $this->parseCriteria($criteria);
        return parent::findOneBy($criteria, $orderBy);
    }

    /**
     * @return array
     * @since 1.0
     */
    protected function parseCriteria(array $criteria)
    {
        if (isset($criteria['blood_group_alternatives']) && $criteria['blood_group_alternatives']) {
            if (isset($criteria['blood_group']) && is_string($criteria['blood_group'])) {
                $criteria['blood_group'] = $this->findCompatibleRedBloodCellGroup($criteria['blood_group']);
            }
        }

        unset($criteria['blood_group_alternatives']); // Remove the alternative blood-groups criteria.

        if (isset($criteria['blood_group']) && 'any' === $criteria['blood_group']) {
            unset($criteria['blood_group']); // Remove the blood-group criteria.
        }

        if (isset($criteria['district']) && -1 == $criteria['district']) {
            unset($criteria['district']); // Remove the district criteria.
        }

        if (isset($criteria['city']) && empty($criteria['district'])) {
            $districts = [];

            if ($criteria['city'] instanceof City) {
                $districts = $criteria['city']->get('districts');
            } elseif (EBB\isValidID($criteria['city'])) {
            } elseif (/** @scrutinizer ignore-call */ EBB\isValidID($criteria['city'])) {
                $em = $this->getEntityManager();
                $city = $em->find('Entities:City', $criteria['city']);
                if (! empty($city)) {
                    $districts = $city->get('districts');
                }
            }

            if (! empty($districts)) {
                $criteria['district'] = [];

                foreach ($districts as $district) {
                    $criteria['district'][] = (int) $district->get('id');
                }
            }
        }

        unset($criteria['city']); // Remove the city criteria in any condition.

        if (isset($criteria['status']) && 'any' === $criteria['status']) {
            unset($criteria['status']); // Remove the status criteria.
        }

        return $criteria;
    }

    /**
     * @return array
     * @since  1.6
     */
    protected function findCompatibleRedBloodCellGroup(string $bloodGroup)
    {
        $compatibleGroups = [];

        switch ($bloodGroup) {
            case 'A+':
                $compatibleGroups = ['A+', 'A-', 'O+', 'O-'];
                break;
            case 'A-':
                $compatibleGroups = ['A-', 'O-'];
                break;
            case 'B+':
                $compatibleGroups = ['B+', 'B-', 'O+', 'O-'];
                break;
            case 'B+':
                $compatibleGroups = ['B+', 'B-', 'O+', 'O-'];
                break;
            case 'B-':
                $compatibleGroups = ['B-', 'O-'];
                break;
            case 'O+':
                $compatibleGroups = ['O+', 'O-'];
                break;
            case 'O-':
                $compatibleGroups = ['O-'];
                break;
            case 'AB+':
                $compatibleGroups = ['any'];
                break;
            case 'AB-':
                $compatibleGroups = ['A-', 'B-', 'O-', 'AB-'];
                break;
        }

        return $compatibleGroups;
    }
}


nash-ye / ebloodbank

Push — master ( c04040...869fe9 )

DonorRepository::findCompatibleRedBloodCellGroup() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like