EBloodBank\Controllers\EditCity

Complexity

Total Complexity

20

Size/Duplication

Total Lines	125
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__invoke()	0	29	6
A	__construct()	0	5	2
B	doSubmitAction()	0	35	8
A	doActions()	0	6	2
A	addNotices()	0	4	2

<?php
/**
 * Edit city page controller class file
 *
 * @package    EBloodBank
 * @subpackage Controllers
 * @since      1.0
 */
namespace EBloodBank\Controllers;

use InvalidArgumentException;
use EBloodBank as EBB;
use EBloodBank\Notices;
use Psr\Container\ContainerInterface;

/**
 * Edit city page controller class
 *
 * @since 1.0
 */
class EditCity extends Controller
{
    /**
     * @var   int
     * @since 1.6
     */
    protected $cityId = 0;

    /**
     * @var \EBloodBank\Models\City|null
     * @since 1.0
     */
    protected $city;

    /**
     * @since 1.0
     */
    public function __construct(ContainerInterface $container, $cityId)
    {
        parent::__construct($container);
        if (EBB\isValidID($cityId)) {

The function isValidID was not found. Maybe you did not declare it correctly or list all dependencies?

            $this->cityId = $cityId;
        }
    }

    /**
     * @return void
     * @since 1.0
     */
    public function __invoke()
    {
        if (! $this->hasAuthenticatedUser() || ! $this->getAcl()->isUserAllowed($this->getAuthenticatedUser(), 'City', 'edit')) {
            $this->viewFactory->displayView('error-403');
            return;
        }

        if (EBB\isValidID($this->cityId)) {

The function isValidID was not found. Maybe you did not declare it correctly or list all dependencies?

            $this->city = $this->getCityRepository()->find($this->cityId);
        }

        if (! $this->city) {
            $this->viewFactory->displayView('error-404');
            return;
        }

        $city = $this->city;

        if (! $this->getAcl()->canEditEntity($this->getAuthenticatedUser(), $city)) {
            $this->viewFactory->displayView('error-403');
            return;
        }

        $this->doActions();
        $this->addNotices();
        $this->viewFactory->displayView(
            'edit-city',
            [
                'city' => $city,
            ]
        );
    }

    /**
     * @return void
     * @since 1.0
     */
    protected function doActions()
    {
        switch (filter_input(INPUT_POST, 'action')) {
            case 'submit_city':
                $this->doSubmitAction();
                break;
        }
    }

    /**
     * @return void
     * @since 1.0
     */
    protected function addNotices()
    {
        if (filter_has_var(INPUT_GET, 'flag-edited')) {
            Notices::addNotice('edited', __('City edited.'), 'success');
        }
    }

    /**
     * @return void
     * @since 1.0
     */
    protected function doSubmitAction()
    {
        try {
            $sessionToken = $this->getSession()->getCsrfToken();
            $actionToken = filter_input(INPUT_POST, 'token');

            if (! $actionToken || ! $sessionToken->isValid($actionToken)) {
                return;
            }

            $city = $this->city;

            if (! $this->hasAuthenticatedUser() || ! $this->getAcl()->canEditEntity($this->getAuthenticatedUser(), $city)) {

It seems like $city can also be of type null; however, parameter $resource of EBloodBank\AclInterface::canEditEntity() does only seem to accept EBloodBank\Models\Entity, maybe add an additional type check?

                return;
            }

            // Set the city name.
            $city->set('name', filter_input(INPUT_POST, 'city_name'), true);

The method set() does not exist on null.

            $duplicateCity = $this->getCityRepository()->findOneBy(['name' => $city->get('name')]);

            if (! empty($duplicateCity) && $duplicateCity->get('id') != $city->get('id')) {
                throw new InvalidArgumentException(__('Please enter a unique city name.'));
            }

            $this->getEntityManager()->flush($city);

            EBB\redirect(

The function redirect was not found. Maybe you did not declare it correctly or list all dependencies?

                EBB\addQueryArgs(

The function addQueryArgs was not found. Maybe you did not declare it correctly or list all dependencies?

                    EBB\getEditCityURL($city->get('id')),

The function getEditCityURL was not found. Maybe you did not declare it correctly or list all dependencies?

                    ['flag-edited' => true]
                )
            );
        } catch (InvalidArgumentException $ex) {
            Notices::addNotice('invalid_city_argument', $ex->getMessage());
        }
    }
}