StringMixin::toXml() - Code Metrics - Inspection of "Work in progress, moving desktops" - nark3d/PhalueObjects - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c64181...1843e0 )

by Adam

created 2017-04-03 17:10 UTC

StringMixin::toXml() A

↳ Parent: StringMixin

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php

namespace BestServedCold\PhalueObjects\Format;

use BestServedCold\PhalueObjects\VOArray\Mixin;

/**
 * Class SringMixin
 *
 * @package BestServedCold\PhalueObjects\Format
 */
trait StringMixin
{
    use Mixin;

    /**
     * @param  Yaml $yaml
     * @return Json
     */
    public static function fromYaml(Yaml $yaml)
    {
        return static::fromArray($yaml->toArray());

    }

    /**
     * @return Yaml
     */
    public function toYaml()
    {
        return Yaml::fromArray($this->toArray());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param  Xml  $xml
     * @return Json
     */
    public function fromXml(Xml $xml)
    {
        return static::fromArray($xml->toArray());

    }

    /**
     * @return string

     */
    public function toXml()
    {
        return Xml::fromArray($this->toArray());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			namespace BestServedCold\PhalueObjects\Format;
4
5			use BestServedCold\PhalueObjects\VOArray\Mixin;
6
7			/**
8			* Class SringMixin
9			*
10			* @package BestServedCold\PhalueObjects\Format
11			*/
12			trait StringMixin
13			{
14			use Mixin;
15
16			/**
17			* @param Yaml $yaml
18			* @return Json
19			*/
20			public static function fromYaml(Yaml $yaml)
21			{
22			return static::fromArray($yaml->toArray());
			0 ignored issues – show Bug introduced 2017-04-03 17:24 UTC by Report Bug Copy Issue Report The method `fromArray()` does not exist on `BestServedCold\PhalueObjects\Format\StringMixin`. Did you maybe mean `fromVOArray()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
23			}
24
25			/**
26			* @return Yaml
27			*/
28			public function toYaml()
29			{
30			return Yaml::fromArray($this->toArray());
			0 ignored issues – show Bug introduced 2017-04-03 17:24 UTC by Report Bug Copy Issue Report It seems like `toArray()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
31			}
32
33			/**
34			* @param Xml $xml
35			* @return Json
36			*/
37			public function fromXml(Xml $xml)
38			{
39			return static::fromArray($xml->toArray());
			0 ignored issues – show Bug introduced 2017-04-03 17:24 UTC by Report Bug Copy Issue Report The method `fromArray()` does not exist on `BestServedCold\PhalueObjects\Format\StringMixin`. Did you maybe mean `fromVOArray()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
40			}
41
42			/**
43			* @return string
			0 ignored issues – show Documentation introduced 2017-04-03 17:24 UTC by Report Bug Copy Issue Report Should the return type not be `Xml`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
44			*/
45			public function toXml()
46			{
47			return Xml::fromArray($this->toArray());
			0 ignored issues – show Bug introduced 2017-04-03 17:24 UTC by Report Bug Copy Issue Report It seems like `toArray()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
48			}
49			}
50

nark3d / PhalueObjects

Push — master ( c64181...1843e0 )

StringMixin::toXml() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like