Pointer - Code Metrics - Inspection of "Working on array value object" - nark3d/PhalueObjects - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a4e176...8c9478 )

by Adam

created 2017-03-17 07:53 UTC

Pointer A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

50%

Importance

Changes

Metric	Value
wmc	2
lcom	0
cbo	1
dl	0
loc	18
ccs	2
cts	4
cp	0.5
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	isLast()	0	4	1
A	isFirst()	0	4	1

<?php

namespace BestServedCold\PhalueObjects\VOArray;

use BestServedCold\PhalueObjects\VOArray;

/**
 * Class Pointer
 *
 * @package BestServedCold\PhalueObjects\VOArray
 */
trait Pointer
{
    /**
     * @return bool
     */
    public function isLast()
    {
        return $this->key() === VOArray::fromArray($this->getValue())->getLastKey();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @return bool
     */
    public function isFirst()
    {
        return $this->key() === VOArray::fromArray($this->getValue())->getFirstKey();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1		<?php
2
3		namespace BestServedCold\PhalueObjects\VOArray;
4
5		use BestServedCold\PhalueObjects\VOArray;
6
7		/**
8		* Class Pointer
9		*
10		* @package BestServedCold\PhalueObjects\VOArray
11		*/
12		trait Pointer
13		{
14		/**
15		* @return bool
16		*/
17	3	public function isLast()
18		{
19	3	return $this->key() === VOArray::fromArray($this->getValue())->getLastKey();
		0 ignored issues – show Bug introduced 2017-03-17 07:56 UTC by Report Bug Copy Issue Report It seems like `key()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2017-03-17 07:56 UTC by Report Bug Copy Issue Report It seems like `getValue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
20		}
21
22		/**
23		* @return bool
24		*/
25		public function isFirst()
26		{
27		return $this->key() === VOArray::fromArray($this->getValue())->getFirstKey();
		0 ignored issues – show Bug introduced 2017-03-17 07:56 UTC by Report Bug Copy Issue Report It seems like `key()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2017-03-17 07:56 UTC by Report Bug Copy Issue Report It seems like `getValue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
28		}
29		}
30

nark3d / PhalueObjects

Push — master ( a4e176...8c9478 )

Pointer A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Duplication Side-by-Side

Filter issues like