Mutate - Code Metrics - Inspection of "Working on array value object" - nark3d/PhalueObjects - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a4e176...8c9478 )

by Adam

created 2017-03-17 07:53 UTC

Mutate A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	19
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	2
lcom	0
cbo	0
dl	0
loc	19
ccs	4
cts	4
cp	1
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	dropFirst()	0	4	1
A	dropLast()	0	4	1

<?php

namespace BestServedCold\PhalueObjects\VOArray;

/**
 * Class Mutate
 *
 * @package BestServedCold\PhalueObjects\VOArray
 */
trait Mutate
{

    /**
     * @return static
     */
    public function dropFirst()
    {
        return new static(array_slice($this->getValue(), 1, $this->count()));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @return static
     */
    public function dropLast()
    {
        return new static(array_slice($this->getValue(), 0, -1));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1		<?php
2
3		namespace BestServedCold\PhalueObjects\VOArray;
4
5		/**
6		* Class Mutate
7		*
8		* @package BestServedCold\PhalueObjects\VOArray
9		*/
10		trait Mutate
11		{
12
13		/**
14		* @return static
15		*/
16	4	public function dropFirst()
17		{
18	4	return new static(array_slice($this->getValue(), 1, $this->count()));
		0 ignored issues – show Bug introduced 2017-03-17 07:56 UTC by Report Bug Copy Issue Report It seems like `getValue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2017-03-17 07:56 UTC by Report Bug Copy Issue Report It seems like `count()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Unused Code introduced 2017-03-17 07:56 UTC by Report Bug Copy Issue Report The call to `Mutate::__construct()` has too many arguments starting with `array_slice($this->getValue(), 1, $this->count())`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
19		}
20
21		/**
22		* @return static
23		*/
24	1	public function dropLast()
25		{
26	1	return new static(array_slice($this->getValue(), 0, -1));
		0 ignored issues – show Bug introduced 2017-03-17 07:56 UTC by Report Bug Copy Issue Report It seems like `getValue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Unused Code introduced 2017-03-17 07:56 UTC by Report Bug Copy Issue Report The call to `Mutate::__construct()` has too many arguments starting with `array_slice($this->getValue(), 0, -1)`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
27		}
28		}
29

nark3d / PhalueObjects

Push — master ( a4e176...8c9478 )

Mutate A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Duplication Side-by-Side

Filter issues like