BestServedCold\PhalueObjects\VOArray\Metric

Complexity

Total Complexity

4

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	count()	0	4	1
A	isEmpty()	0	4	1
A	equals()	0	8	2

<?php

namespace BestServedCold\PhalueObjects\VOArray;

use BestServedCold\PhalueObjects\VOArray;
use BestServedCold\PhalueObjects\Exception\InvalidTypeException;
use BestServedCold\PhalueObjects\Contract\ValueObject;

/**
 * Trait Metric
 */
trait Metric
{
    /**
     * @return int
     */
    public function count()
    {
        return count($this->getValue());

It seems like getValue() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @return bool
     */
    public function isEmpty()
    {
        return empty($this->value);

The property value does not exist. Did you maybe forget to declare it?

    }

    /**
     * @param  ValueObject $object
     * @return bool
     */
    public function equals(ValueObject $object)

function equals() does not seem to conform to the naming convention (^(?:is|has|should|may|supports)).

    {
        if (! $object instanceof VOArray) {
            throw new InvalidTypeException($object, [ VOArray::class ]);
        }

        return parent::equals($object);
    }
}