Key - Code Metrics - Inspection of "Working on array value object" - nark3d/PhalueObjects - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a4e176...8c9478 )

by Adam

created 2017-03-17 07:53 UTC

Key A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	6
lcom	0
cbo	0
dl	0
loc	47
ccs	12
cts	12
cp	1
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	getKey()	4	2
A	getKeys()	4	1
A	getFirstKey()	5	1
A	getLastKey()	5	1
A	keyExists()	4	1

<?php

namespace BestServedCold\PhalueObjects\VOArray;

/**
 * Class KeyTrait
 * @package BestServedCold\PhalueObjects
 */
trait Key
{
    /**
     * @param  string|int $key
     * @return bool|mixed
     */
    public function getKey($key)
    {
        return $this->keyExists($key) ? $this->getValue()[$key] : false;
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @return array
     */
    public function getKeys()
    {
        return array_keys($this->getValue());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @return mixed
     */
    public function getFirstKey()
    {
        $keys = $this->getKeys();
        return array_shift($keys);
    }

    /**
     * @return mixed
     */
    public function getLastKey()
    {
        $keys = $this->getKeys();
        return end($keys);
    }

    /**
     * @param  $key
     * @return bool
     */
    public function keyExists($key)

    {
        return array_key_exists($key, $this->getValue());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

}


1		<?php
2
3		namespace BestServedCold\PhalueObjects\VOArray;
4
5		/**
6		* Class KeyTrait
7		* @package BestServedCold\PhalueObjects
8		*/
9		trait Key
10		{
11		/**
12		* @param string\|int $key
13		* @return bool\|mixed
14		*/
15	3	public function getKey($key)
16		{
17	3	return $this->keyExists($key) ? $this->getValue()[$key] : false;
		0 ignored issues – show Bug introduced 2017-03-17 07:56 UTC by Report Bug Copy Issue Report It seems like `getValue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
18		}
19
20		/**
21		* @return array
22		*/
23	5	public function getKeys()
24		{
25	5	return array_keys($this->getValue());
		0 ignored issues – show Bug introduced 2017-03-17 07:56 UTC by Report Bug Copy Issue Report It seems like `getValue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
26		}
27
28		/**
29		* @return mixed
30		*/
31	1	public function getFirstKey()
32		{
33	1	$keys = $this->getKeys();
34	1	return array_shift($keys);
35		}
36
37		/**
38		* @return mixed
39		*/
40	4	public function getLastKey()
41		{
42	4	$keys = $this->getKeys();
43	4	return end($keys);
44		}
45
46		/**
47		* @param $key
48		* @return bool
49		*/
50	3	public function keyExists($key)
		0 ignored issues – show Coding Style introduced 2017-03-17 07:56 UTC by Report Bug Copy Issue Report `function keyExists()` does not seem to conform to the naming convention (`^(?:is\|has\|should\|may\|supports)`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
51		{
52	3	return array_key_exists($key, $this->getValue());
		0 ignored issues – show Bug introduced 2017-03-17 07:56 UTC by Report Bug Copy Issue Report It seems like `getValue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
53		}
54
55		}
56

nark3d / PhalueObjects

Push — master ( a4e176...8c9478 )

Key A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

Duplication Side-by-Side

Filter issues like