BestServedCold\PhalueObjects\VOArray\Find

Complexity

Total Complexity

5

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	jsonNotation()	0	4	1
A	nativeArray()	0	4	1
A	voArray()	0	10	3

<?php

namespace BestServedCold\PhalueObjects\VOArray;

use BestServedCold\PhalueObjects\Format\Json\Notation;
use BestServedCold\PhalueObjects\VOArray;

/**
 * Class Find
 *
 * @package BestServedCold\PhalueObjects\VOArray
 */
trait Find
{
    /**
     * @param  Notation $notation
     * @return bool
     */
    public function jsonNotation(Notation $notation)

function jsonNotation() does not seem to conform to the naming convention (^(?:is|has|should|may|supports)).

    {
        return $this->voArray($notation->toVOArray());
    }

    /**
     * @param  array $array
     * @return bool|mixed
     */
    public function nativeArray(array $array)
    {
        return $this->voArray(VOArray::fromArray($array));
    }

    /**
     * Iterates through an array of values and finds a key.  If it makes it to the final value,
     * it returns what ever value matches that key.
     *
     * @param  VOArray    $arrayValueObject
     * @return bool|mixed
     */
    public function voArray(VOArray $arrayValueObject)
    {
        if ($key = VOArray::fromArray($this->getValue())->getKey($arrayValueObject->current())) {

It seems like getValue() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return $arrayValueObject->isLast() ? $key
                : VOArray::fromArray($key)
                    ->voArray($arrayValueObject->dropFirst());
        }

        return false;
    }
}