Mixin - Code Metrics - nark3d/PhalueObjects - Measure and Improve Code Quality continuously with Scrutinizer

Mixin A
last analyzed 2017-04-08 14:03 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	19
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	2
lcom	0
cbo	1
dl	0
loc	19
ccs	4
cts	4
cp	1
rs	10
c	1
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	toVOString()	0	4	1
A	fromVOString()	0	4	1

<?php

namespace BestServedCold\PhalueObjects\VOString;

use BestServedCold\PhalueObjects\VOString;

/**
 * Class StringableTrait
 *
 * @package BestServedCold\PhalueObjects\VOString
 */
trait Mixin
{
    /**
     * @return VOString
     */
    public function toVOString()
    {
        return VOString::fromString($this->toString());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param  VOString $voString
     * @return static
     */
    public static function fromVOString(VOString $voString)
    {
        return static::fromString($voString->getValue());

    }
}


1		<?php
2
3		namespace BestServedCold\PhalueObjects\VOString;
4
5		use BestServedCold\PhalueObjects\VOString;
6
7		/**
8		* Class StringableTrait
9		*
10		* @package BestServedCold\PhalueObjects\VOString
11		*/
12		trait Mixin
13		{
14		/**
15		* @return VOString
16		*/
17	3	public function toVOString()
18		{
19	3	return VOString::fromString($this->toString());
		0 ignored issues – show Bug introduced 2017-03-29 10:04 UTC by Report Bug Copy Issue Report It seems like `toString()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
20		}
21
22		/**
23		* @param VOString $voString
24		* @return static
25		*/
26	1	public static function fromVOString(VOString $voString)
27		{
28	1	return static::fromString($voString->getValue());
		0 ignored issues – show Bug introduced 2017-03-28 21:16 UTC by Report Bug Copy Issue Report The method `fromString()` does not exist on `BestServedCold\PhalueObjects\VOString\Mixin`. Did you maybe mean `fromVOString()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
29		}
30		}
31

nark3d / PhalueObjects

Mixin A last analyzed 2017-04-08 14:03 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Duplication Side-by-Side

Filter issues like

Mixin A
last analyzed 2017-04-08 14:03 UTC