Metric - Code Metrics - nark3d/PhalueObjects - Measure and Improve Code Quality continuously with Scrutinizer

Metric A
last analyzed 2017-04-08 14:03 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
dl	0
loc	44
c	0
b	0
f	0
wmc	4
lcom	1
cbo	0
ccs	14
cts	14
cp	1
rs	10

4 Methods

Rating	Name	Size	Complexity
A	count()	4	1
A	isEmpty()	4	1
A	isMultiDim()	4	1
A	getDepth()	15	1

<?php

namespace BestServedCold\PhalueObjects\VOArray;

use BestServedCold\PhalueObjects\VOArray;
use BestServedCold\PhalueObjects\Exception\InvalidTypeException;
use BestServedCold\PhalueObjects\Contract\ValueObject;

/**
 * Trait Metric
 */
trait Metric
{
    /**
     * @return int
     */
    public function count()
    {
        return count($this->getValue());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @return bool
     */
    public function isEmpty()
    {
        return empty($this->value);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * @return boolean
     */
    public function isMultiDim()
    {
        return count($this->getValue()) !== count($this->getValue(), COUNT_RECURSIVE);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function getDepth()
    {
        $max = 0;
        $depth = function (&$max) {
            return function($line) use (&$max) {
                // every line-indent equals 4 spaces
                $max = max([$max, (strlen($line) - strlen(ltrim($line))) / 4]);
            };
        };

        // print_r returns formatted textual array presentation
        array_map($depth($max), explode("\n", print_r($this->getValue(), true)));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        // [1,2] -> 1, [3,4] -> 2, ..., [N,N+1] -> (N+1)/2

        return ceil(($max - 1) / 2) + 1;
    }


}


1		<?php
2
3		namespace BestServedCold\PhalueObjects\VOArray;
4
5		use BestServedCold\PhalueObjects\VOArray;
6		use BestServedCold\PhalueObjects\Exception\InvalidTypeException;
7		use BestServedCold\PhalueObjects\Contract\ValueObject;
8
9		/**
10		* Trait Metric
11		*/
12		trait Metric
13		{
14		/**
15		* @return int
16		*/
17	9	public function count()
18		{
19	9	return count($this->getValue());
		0 ignored issues – show Bug introduced 2017-03-17 07:56 UTC by Report Bug Copy Issue Report It seems like `getValue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
20		}
21
22		/**
23		* @return bool
24		*/
25	1	public function isEmpty()
26		{
27	1	return empty($this->value);
		0 ignored issues – show Bug introduced 2017-03-17 07:56 UTC by Report Bug Copy Issue Report The property `value` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
28		}
29
30		/**
31		* @return boolean
32		*/
33	17	public function isMultiDim()
34		{
35	17	return count($this->getValue()) !== count($this->getValue(), COUNT_RECURSIVE);
		0 ignored issues – show Bug introduced 2017-03-28 21:16 UTC by Report Bug Copy Issue Report It seems like `getValue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
36		}
37
38	1	public function getDepth()
39		{
40	1	$max = 0;
41		$depth = function (&$max) {
42	1	return function($line) use (&$max) {
43		// every line-indent equals 4 spaces
44	1	$max = max([$max, (strlen($line) - strlen(ltrim($line))) / 4]);
45	1	};
46	1	};
47
48		// print_r returns formatted textual array presentation
49	1	array_map($depth($max), explode("\n", print_r($this->getValue(), true)));
		0 ignored issues – show Bug introduced 2017-03-28 21:16 UTC by Report Bug Copy Issue Report It seems like `getValue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
50		// [1,2] -> 1, [3,4] -> 2, ..., [N,N+1] -> (N+1)/2
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-03-28 21:16 UTC by Report Bug Copy Issue Report `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
51	1	return ceil(($max - 1) / 2) + 1;
52		}
53
54
55		}
56

nark3d / PhalueObjects

Metric A last analyzed 2017-04-08 14:03 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

Duplication Side-by-Side

Filter issues like

Metric A
last analyzed 2017-04-08 14:03 UTC