Store::uid() - Code Metrics - Inspection of "Adding in unit tests for the Lucene side of things..." - nark3d/LaravelZendSearch - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f92c24...681df7 )

by Adam

created 2016-09-30 08:18 UTC

Store::uid() A

↳ Parent: Store

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	5
ccs	3
cts	3
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	1
crap	1

<?php 

namespace BestServedCold\LaravelZendSearch\Lucene;

use BestServedCold\LaravelZendSearch\Lucene\Store\Insert;
use BestServedCold\LaravelZendSearch\Lucene\Store\Delete;

/**
 * Class Store
 *
 * @package BestServedCold\LaravelZendSearch\Lucene
 */
class Store
{
    /**
     * @var string
     */
    private $uid;

    /**
     * @var Delete
     */
    private $delete;

    /**
     * @var Insert
     */
    private $insert;

    /**
     * Store constructor.
     *
     * @param Delete $delete
     * @param Insert $insert
     */
    public function __construct(Delete $delete, Insert $insert)
    {
        $this->delete = $delete;
        $this->insert = $insert;
    }

    /**
     * Delete
     *
     * @param  integer $id
     * @param  bool    $uid
     * @return Delete
     */
    public function delete($id, $uid = false)
    {
        return $this->delete->delete($id, $uid ?: $this->uid);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     * Insert
     *
     * @param  $id
     * @param  array $fields
     * @param  bool  $uid
     * @return mixed
     */
    public function insert($id, array $fields, $uid = false, $deleteFirst = true)
    {
        $deleteFirst ? $this->delete($id, $uid) : null;
        return $this->insert->insert($id, $fields, $uid ?: $this->uid);
    }

    /**
     * Uid
     *
     * @param  $uid
     * @return $this
     */
    public function uid($uid)
    {
        $this->uid = $uid;
        return $this;
    }
}


1		<?php
2
3		namespace BestServedCold\LaravelZendSearch\Lucene;
4
5		use BestServedCold\LaravelZendSearch\Lucene\Store\Insert;
6		use BestServedCold\LaravelZendSearch\Lucene\Store\Delete;
7
8		/**
9		* Class Store
10		*
11		* @package BestServedCold\LaravelZendSearch\Lucene
12		*/
13		class Store
14		{
15		/**
16		* @var string
17		*/
18		private $uid;
19
20		/**
21		* @var Delete
22		*/
23		private $delete;
24
25		/**
26		* @var Insert
27		*/
28		private $insert;
29
30		/**
31		* Store constructor.
32		*
33		* @param Delete $delete
34		* @param Insert $insert
35		*/
36	3	public function __construct(Delete $delete, Insert $insert)
37		{
38	3	$this->delete = $delete;
39	3	$this->insert = $insert;
40	3	}
41
42		/**
43		* Delete
44		*
45		* @param integer $id
46		* @param bool $uid
47		* @return Delete
48		*/
49	2	public function delete($id, $uid = false)
50		{
51	2	return $this->delete->delete($id, $uid ?: $this->uid);
		0 ignored issues – show Bug introduced 2016-09-12 09:56 UTC by Report Bug Copy Issue Report It seems like `$uid ?: $this->uid` can also be of type `string`; however, `BestServedCold\LaravelZe...\Store\Delete::delete()` does only seem to accept `boolean`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
52		}
53
54		/**
55		* Insert
56		*
57		* @param $id
58		* @param array $fields
59		* @param bool $uid
60		* @return mixed
61		*/
62	1	public function insert($id, array $fields, $uid = false, $deleteFirst = true)
63		{
64	1	$deleteFirst ? $this->delete($id, $uid) : null;
65	1	return $this->insert->insert($id, $fields, $uid ?: $this->uid);
66		}
67
68		/**
69		* Uid
70		*
71		* @param $uid
72		* @return $this
73		*/
74	1	public function uid($uid)
75		{
76	1	$this->uid = $uid;
77	1	return $this;
78		}
79		}
80

nark3d / LaravelZendSearch

Push — master ( f92c24...681df7 )

Store::uid() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like