BestServedCold\LaravelZendSearch\Lucene\Index

Complexity

Total Complexity

10

Size/Duplication

Total Lines	93
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

96.15%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	open()	0	7	2
A	limit()	0	5	1
A	index()	0	14	3
A	setPath()	0	4	1
A	path()	0	8	2
A	get()	0	4	1

<?php

namespace BestServedCold\LaravelZendSearch\Lucene;

use ZendSearch\Lucene\Analysis\Analyzer\Analyzer;
use ZendSearch\Lucene\Analysis\Analyzer\Common\Utf8Num\CaseInsensitive;
use ZendSearch\Lucene\Lucene;
use ZendSearch\Exception\ExceptionInterface;
use ZendSearch\Lucene\Index as LuceneIndex;
use ZendSearch\Lucene\SearchIndexInterface;

/**
 * Class Index
 * @package BestServedCold\LaravelZendSearch\Lucene
 */
class Index
{
    /**
     * @var LuceneIndex
     */
    private static $index;

    /**
     * @var string
     */
    protected $path;

    /**
     * Open
     *
     * @param  bool $path
     * @param  bool $forceCreate
     * @return \ZendSearch\Lucene\SearchIndexInterface
     * @throws ExceptionInterface
     * @throws \Exception
     */
    public function open($path = false, $forceCreate = true)
    {
        $path ? $this->path = $path : null;

The property $path was declared of type string, but $path is of type boolean. Maybe add a type cast?

        Analyzer::setDefault(new CaseInsensitive);
        self::$index = $this->index($this->path(), $forceCreate);
        return self::$index;
    }

    /**
     * @param integer $limit
     * @return $this
     */
    public function limit($limit)
    {
        Lucene::setResultSetLimit($limit);
        return $this;
    }

    /**
     * Index
     *
     * Extends the Lucene "open" method to create the index if it doesn't exist.
     *
     * @param  string|boolean $path
     * @param  boolean        $forceCreate
     * @return SearchIndexInterface
     * @throws \Exception
     */
    private function index($path, $forceCreate = true)

Please use __construct() instead of a PHP4-style constructor that is named after the class.

    {
        try {
            $index = Lucene::open($path);
        } catch (ExceptionInterface $error) {
            if ($forceCreate) {
                $index = Lucene::create($path);
            } else {
                throw $error;
            }
        }
        
        return $index;
    }

    /**
     * @param $path
     */
    public function setPath($path)
    {
        $this->path = $path;
    }

    /**
     * @return string
     * @throws \Exception
     */
    protected function path()
    {
        if (!$this->path) {
            throw new \Exception('No path specified nor config variable set.');
        }

        return $this->path;
    }

    /**
     * @return LuceneIndex
     */
    public function get()
    {
        return self::$index;
    }
}