BestServedCold\LaravelZendSearch\Lucene\Store\Insert

Complexity

Total Complexity

7

Size/Duplication

Total Lines	81
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	insert()	0	7	1
A	field()	0	4	1
A	addUid()	0	8	2
A	addFields()	0	8	2

<?php

namespace BestServedCold\LaravelZendSearch\Lucene\Store;

use BestServedCold\LaravelZendSearch\Lucene\Index;
use BestServedCold\LaravelZendSearch\Lucene\Search;
use ZendSearch\Lucene\Document;
use ZendSearch\Lucene\Document\Field;

/**
 * Class Insert
 *
 * @package BestServedCold\LaravelZendSearch\Lucene\Store
 */
final class Insert
{
    /**
     * @var Index
     */
    private $index;

    /**
     * @var Document
     */
    private $document;

    /**
     * Insert constructor.
     *
     * @param Search   $search
     * @param Index    $index
     * @param Document $document
     */
    public function __construct(Search $search, Index $index, Document $document)
    {
        $this->search   = $search;

The property search does not exist. Did you maybe forget to declare it?

        $this->index    = $index;
        $this->document = $document;
    }

    /**             
     * Insert
     *
     * @param  $id
     * @param  array          $fields     fields that are indexed
     * @param  boolean|string $uid        unique identifier, if required
     * @return mixed
     */
    public function insert($id, array $fields, $uid = false)
    {
        $this->document->addField($this->field('xref_id', $id));
        $this->document = $this->addUid($this->document, $uid);

It seems like $uid defined by parameter $uid on line 49 can also be of type string; however, BestServedCold\LaravelZendSearch\Lucene\Store\Insert::addUid() does only seem to accept boolean, maybe add an additional type check?

        $this->document = $this->addFields($this->document, $fields);
        return $this->index->get()->addDocument($this->document);
    }

    /**
     * @param  string $keyword
     * @param  string $value
     * @param  string $type
     * @return Field
     */
    private function field($keyword, $value, $type = 'keyword')
    {
        return Field::$type($keyword, $value);
    }

    /**
     * @param  Document $document
     * @param  bool     $uid
     * @return Document
     */
    private function addUid(Document $document, $uid = false)
    {
        if ($uid) {
            $document->addField($this->field('uid', strtoupper($uid)));
        }

        return $document;
    }

    /**
     * @param  Document $document
     * @param  array    $fields
     * @return Document
     */
    private function addFields(Document $document, array $fields)
    {
        foreach ($fields as $key => $field) {
            $document->addField($this->field($key, strtoupper($field)));
        }

        return $document;
    }
}