Store::insertModel() - Code Metrics - Inspection of "More unit tests" - nark3d/LaravelZendSearch - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (ddcd57)

by Adam

created 2016-10-01 15:55 UTC

Store::insertModel() A

↳ Parent: Store

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	8
cts	8
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	8
nc	1
nop	2
crap	1

<?php

namespace BestServedCold\LaravelZendSearch\Laravel;

use BestServedCold\LaravelZendSearch\Lucene\Store as LuceneStore;
use Illuminate\Database\Eloquent\Model;
use BestServedCold\LaravelZendSearch\Lucene\Store\Delete;
use BestServedCold\LaravelZendSearch\Lucene\Store\Insert;

/**
 * Class Store
 * @package BestServedCold\LaravelZendSearch\Laravel
 */
final class Store extends LuceneStore
{
    use EloquentTrait;

    private $index;

    public function __construct(Delete $delete, Insert $insert, Index $index)
    {
        parent::__construct($delete, $insert);
        $this->index = $index;
    }

    /**
     * @param Model $model
     */
    public function insertModel(Model $model, $deleteFirst = true)
    {
        $this->index->open();
        $this->model($model);
        return $this->insert(
            $model->id,
            $this->filterFields($model),
            $this->uid,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $deleteFirst
        );
    }

    /**
     * @param Model $model
     */
    public function deleteModel(Model $model)
    {
        $this->delete($model->id, $this->uid);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @param Model $model
     * @return array
     */
    private function filterFields($model)
    {
        return $this->filterKeysFromArray($model->attributesToArray(), $model::getSearchFields());
    }

    /**
     * @param  array $haystack
     * @param  array $needle
     * @return array
     * @todo   refactor this out of here.
     */
    private function filterKeysFromArray(array $haystack, array $needle)
    {
        return array_intersect_key($haystack, array_flip($needle));
    }
}


1		<?php
2
3		namespace BestServedCold\LaravelZendSearch\Laravel;
4
5		use BestServedCold\LaravelZendSearch\Lucene\Store as LuceneStore;
6		use Illuminate\Database\Eloquent\Model;
7		use BestServedCold\LaravelZendSearch\Lucene\Store\Delete;
8		use BestServedCold\LaravelZendSearch\Lucene\Store\Insert;
9
10		/**
11		* Class Store
12		* @package BestServedCold\LaravelZendSearch\Laravel
13		*/
14		final class Store extends LuceneStore
15		{
16		use EloquentTrait;
17
18		private $index;
19
20	9	public function __construct(Delete $delete, Insert $insert, Index $index)
21		{
22	9	parent::__construct($delete, $insert);
23	9	$this->index = $index;
24	9	}
25
26		/**
27		* @param Model $model
28		*/
29	1	public function insertModel(Model $model, $deleteFirst = true)
30		{
31	1	$this->index->open();
32	1	$this->model($model);
33	1	return $this->insert(
34	1	$model->id,
35	1	$this->filterFields($model),
36	1	$this->uid,
		0 ignored issues – show Bug introduced 2016-09-12 17:54 UTC by Report Bug Copy Issue Report The property `uid` cannot be accessed from this context as it is declared `private` in class `BestServedCold\LaravelZendSearch\Lucene\Store`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history... Documentation introduced 2016-09-12 17:54 UTC by Report Bug Copy Issue Report `$this->uid` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
37		$deleteFirst
38	1	);
39		}
40
41		/**
42		* @param Model $model
43		*/
44	1	public function deleteModel(Model $model)
45		{
46	1	$this->delete($model->id, $this->uid);
		0 ignored issues – show Bug introduced 2016-09-12 09:56 UTC by Report Bug Copy Issue Report The property `uid` cannot be accessed from this context as it is declared `private` in class `BestServedCold\LaravelZendSearch\Lucene\Store`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history... Documentation introduced 2016-09-12 09:56 UTC by Report Bug Copy Issue Report `$this->uid` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
47	1	}
48
49		/**
50		* @param Model $model
51		* @return array
52		*/
53	1	private function filterFields($model)
54		{
55	1	return $this->filterKeysFromArray($model->attributesToArray(), $model::getSearchFields());
56		}
57
58		/**
59		* @param array $haystack
60		* @param array $needle
61		* @return array
62		* @todo refactor this out of here.
63		*/
64	1	private function filterKeysFromArray(array $haystack, array $needle)
65		{
66	1	return array_intersect_key($haystack, array_flip($needle));
67		}
68		}
69

nark3d / LaravelZendSearch

Branch — master (ddcd57)

Store::insertModel() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like