BestServedCold\Benchmark\Benchmark

Complexity

Total Complexity

12

Size/Duplication

Total Lines	91
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	getName()	0	5	2
A	reset()	0	5	1
A	__construct()	0	4	1
A	start()	0	6	1
A	stop()	0	6	2
A	getMarkers()	0	4	2
A	get()	0	4	2
A	getLastName()	0	6	1

<?php

namespace BestServedCold\Benchmark;

use BestServedCold\Benchmark\Factory\Measure;
use BestServedCold\Benchmark\Factory\Peak;

/**
 * Class Benchmark
 * 
 * @package BestServedCold\Benchmark
 */
class Benchmark
{
    /**
     * @var array
     */
    protected static $markers = [];

    /**
     * @var string
     */
    protected static $lastName;

    /**
     * Benchmark constructor.
     *
     * @param $markers
     */
    public function __construct($markers = [])
    {
        self::$markers = $markers;
    }

    /**
     * @param  bool|string $name
     * @return string
     */
    public static function start($name = false)
    {
        $name = self::getName($name);

It seems like $name defined by self::getName($name) on line 41 can also be of type string; however, BestServedCold\Benchmark\Benchmark::getName() does only seem to accept boolean, maybe add an additional type check?

        self::$markers[$name] = Measure::now();
        return $name;
    }

    /**
     * @param  bool   $name
     * @return string
     */
    public static function stop($name = null)
    {
        $name = $name ?: self::getLastName();
        self::$markers[$name] = array_merge(Measure::diff(self::$markers[$name]), Peak::now());
        return $name;
    }

    /**
     * @param  bool        $name
     * @return array|mixed
     */
    public static function getMarkers($name = false)
    {
        return $name ? [ $name => self::$markers[$name]] : self::$markers;
    }

    /**
     * @param  string|bool $name
     * @return static
     */
    public static function get($name = false)
    {
        return $name ? new self([$name => self::$markers[$name]]) : new static(self::$markers);
    }

    /**
     * @return string
     */
    private static function getLastName()
    {
        $name           = self::$lastName;
        self::$lastName = null;
        return $name;
    }

    /**
     * @param  bool   $name
     * @return string
     */
    private static function getName($name = false)
    {
        self::$lastName = $name ?: uniqid();

It seems like $name ?: uniqid() can also be of type boolean. However, the property $lastName is declared as type string. Maybe add an additional type check?

        return self::$lastName;
    }

    /**
     * @return void
     */
    public static function reset()
    {
        self::$lastName = null;
        self::$markers  = null;

It seems like null of type null is incompatible with the declared type array of property $markers.

    }
}