Issues in Versioner.php (master) - Issues in master - naneau/php-project-versioner - Measure and Improve Code Quality continuously with Scrutinizer

Issues (11)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Naneau/ProjectVersioner/Versioner.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Versioner.php
 *
 * @package         ProjectVersioner
 * @subpackage      Versioner
 */

namespace Naneau\ProjectVersioner;

use Naneau\ProjectVersioner\ReaderInterface as Reader;

use \RuntimeException;

/**
 * Versioner
 *
 * Uses a set of readers to fetch versions from directories
 *
 * @category        Naneau
 * @package         ProjectVersioner
 * @subpackage      Versioner
 */
class Versioner
{
    /**
     * The readers
     *
     * @var Reader[]
     **/
    private $readers;

    /**
     * Constructor
     *
     * @param  Reader[] $readers
     * @return void

     **/
    public function __construct(array $readers = array())
    {
        $this->setReaders($readers);
    }

    /**
     * Get the version for a directory
     *
     * @param  string $directory
     * @return string
     **/
    public function get($directory)
    {
        foreach ($this->getReaders() as $reader) {
            if ($reader->canRead($directory)) {
                return $reader->read($directory);
            }
        }

        throw new RuntimeException(sprintf(
            'Can not read version from directory "%s"',
            $directory
        ));
    }

    /**
     * Get the version for a directory
     *
     * Combining the output of all writers using the given separator
     *
     * Version will be considered "found" if at least one versioner returns
     * output.
     *
     * @param  string $directory
     * @param  string $separator
     * @return string
     **/
    public function getCombined($directory, $separator = '-')
    {
        $found = array();
        foreach ($this->getReaders() as $reader) {
            if ($reader->canRead($directory)) {
                $found[] = $reader->read($directory);
            }
        }

        if (count($found) === 0) {
            throw new RuntimeException(sprintf(
                'Can not read version from directory "%s"',
                $directory
            ));
        }

        return implode($separator, $found);
    }

    /**
     * Does a directory have a version?
     *
     * @param string $directory
     * @return bool
     **/
    public function has($directory)
    {
        foreach ($this->getReaders() as $reader) {
            if ($reader->canRead($directory)) {
                return true;
            }
        }

        return false;
    }

    /**
     * Get the set of readers
     *
     * @return Reader[]
     */
    public function getReaders()
    {
        return $this->readers;
    }

    /**
     * Set the set of readers
     *
     * @param  Reader[]  $readers
     * @return Versioner
     */
    public function setReaders(array $readers)
    {
        $this->readers = $readers;

        return $this;
    }

    /**
     * Add a reader
     *
     * @param  Reader[]  $reader
     * @return Versioner
     */
    public function addReader(Reader $reader)
    {
        $this->readers[] = $reader;

        return $this;
    }
}


1			<?php
2			/**
3			* Versioner.php
4			*
5			* @package ProjectVersioner
6			* @subpackage Versioner
7			*/
8
9			namespace Naneau\ProjectVersioner;
10
11			use Naneau\ProjectVersioner\ReaderInterface as Reader;
12
13			use \RuntimeException;
14
15			/**
16			* Versioner
17			*
18			* Uses a set of readers to fetch versions from directories
19			*
20			* @category Naneau
21			* @package ProjectVersioner
22			* @subpackage Versioner
23			*/
24			class Versioner
25			{
26			/**
27			* The readers
28			*
29			* @var Reader[]
30			**/
31			private $readers;
32
33			/**
34			* Constructor
35			*
36			* @param Reader[] $readers
37			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2017-06-15 15:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
38			**/
39			public function __construct(array $readers = array())
40			{
41			$this->setReaders($readers);
42			}
43
44			/**
45			* Get the version for a directory
46			*
47			* @param string $directory
48			* @return string
49			**/
50			public function get($directory)
51			{
52			foreach ($this->getReaders() as $reader) {
53			if ($reader->canRead($directory)) {
54			return $reader->read($directory);
55			}
56			}
57
58			throw new RuntimeException(sprintf(
59			'Can not read version from directory "%s"',
60			$directory
61			));
62			}
63
64			/**
65			* Get the version for a directory
66			*
67			* Combining the output of all writers using the given separator
68			*
69			* Version will be considered "found" if at least one versioner returns
70			* output.
71			*
72			* @param string $directory
73			* @param string $separator
74			* @return string
75			**/
76			public function getCombined($directory, $separator = '-')
77			{
78			$found = array();
79			foreach ($this->getReaders() as $reader) {
80			if ($reader->canRead($directory)) {
81			$found[] = $reader->read($directory);
82			}
83			}
84
85			if (count($found) === 0) {
86			throw new RuntimeException(sprintf(
87			'Can not read version from directory "%s"',
88			$directory
89			));
90			}
91
92			return implode($separator, $found);
93			}
94
95			/**
96			* Does a directory have a version?
97			*
98			* @param string $directory
99			* @return bool
100			**/
101			public function has($directory)
102			{
103			foreach ($this->getReaders() as $reader) {
104			if ($reader->canRead($directory)) {
105			return true;
106			}
107			}
108
109			return false;
110			}
111
112			/**
113			* Get the set of readers
114			*
115			* @return Reader[]
116			*/
117			public function getReaders()
118			{
119			return $this->readers;
120			}
121
122			/**
123			* Set the set of readers
124			*
125			* @param Reader[] $readers
126			* @return Versioner
127			*/
128			public function setReaders(array $readers)
129			{
130			$this->readers = $readers;
131
132			return $this;
133			}
134
135			/**
136			* Add a reader
137			*
138			* @param Reader[] $reader
139			* @return Versioner
140			*/
141			public function addReader(Reader $reader)
142			{
143			$this->readers[] = $reader;
144
145			return $this;
146			}
147			}
148

GitHub Access Token became invalid

Issues (11)

Security Analysis no request data

src/Naneau/ProjectVersioner/Versioner.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

naneau / php-project-versioner

GitHub Access Token became invalid

Issues (11)

Security Analysis no request data

src/Naneau/ProjectVersioner/Versioner.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like