Exec::exec() - Code Metrics - naneau/php-project-versioner - Measure and Improve Code Quality continuously with Scrutinizer

Exec::exec() A
last analyzed 2017-06-15 15:50 UTC

↳ Parent: Exec

Complexity

Conditions	2
Paths	2

Size

Total Lines	19
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	9
nc	2
nop	1

<?php
/**
 * Exec.php
 *
 * @package         ProjectVersioner
 * @subpackage      Reader
 */

namespace Naneau\ProjectVersioner\Reader\Git;

use Naneau\ProjectVersioner\ReaderInterface;

/**
 * Exec
 *
 * Base class for exec based git reading
 *
 * @category        Naneau
 * @package         ProjectVersioner
 * @subpackage      Reader
 */
abstract class Exec implements ReaderInterface
{
    /**
     * {@inheritDoc}
     **/
    public function canRead($directory)
    {
        return $this->canExec(
            $this->getCommandForDirectory($directory),
            $directory
        );
    }

    /**
     * {@inheritDoc}
     **/
    public function read($directory)
    {
        return $this->exec(
            $this->getCommandForDirectory($directory)
        );
    }

    /**
     * Get the command for a directory
     *
     * @param  string $directory
     * @return string
     **/
    abstract protected function getCommandForDirectory($directory);

    /**
     * Can a git command be executed?
     *
     * @param  string $command
     * @param  string $directory
     * @return void
     **/
    private function canExec($command, $directory)
    {
        // We rely on exec, so it needs to exist
        if (!function_exists('exec')) {
            return false;
        }

        // (Cheap) check for git directory
        if (!is_dir($directory . '/.git')) {
            return false;
        }

        // Try to exec()
        $output = array();
        $return = 0;
        @exec($command, $output, $return);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        // Check return code
        return $return === 0;
    }

    /**
     * Execute a git command and return first line of output
     *
     * @param  string $command
     * @return string
     **/
    private function exec($command)
    {
        $output = array();
        $return = 0;

        // Try to find last commit hash
        @exec($command, $output, $return);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        // Make sure it worked
        if ($return !== 0) {
            throw new RuntimeException(sprintf(
                'Can not parse version from git using %s',
                $command
            ));
        }

        // Return first line of output
        return $output[0];
    }
}


1			<?php
2			/**
3			* Exec.php
4			*
5			* @package ProjectVersioner
6			* @subpackage Reader
7			*/
8
9			namespace Naneau\ProjectVersioner\Reader\Git;
10
11			use Naneau\ProjectVersioner\ReaderInterface;
12
13			/**
14			* Exec
15			*
16			* Base class for exec based git reading
17			*
18			* @category Naneau
19			* @package ProjectVersioner
20			* @subpackage Reader
21			*/
22			abstract class Exec implements ReaderInterface
23			{
24			/**
25			* {@inheritDoc}
26			**/
27			public function canRead($directory)
28			{
29			return $this->canExec(
30			$this->getCommandForDirectory($directory),
31			$directory
32			);
33			}
34
35			/**
36			* {@inheritDoc}
37			**/
38			public function read($directory)
39			{
40			return $this->exec(
41			$this->getCommandForDirectory($directory)
42			);
43			}
44
45			/**
46			* Get the command for a directory
47			*
48			* @param string $directory
49			* @return string
50			**/
51			abstract protected function getCommandForDirectory($directory);
52
53			/**
54			* Can a git command be executed?
55			*
56			* @param string $command
57			* @param string $directory
58			* @return void
59			**/
60			private function canExec($command, $directory)
61			{
62			// We rely on exec, so it needs to exist
63			if (!function_exists('exec')) {
64			return false;
65			}
66
67			// (Cheap) check for git directory
68			if (!is_dir($directory . '/.git')) {
69			return false;
70			}
71
72			// Try to exec()
73			$output = array();
74			$return = 0;
75			@exec($command, $output, $return);
			0 ignored issues – show Security Best Practice introduced 2017-06-15 15:29 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
76
77			// Check return code
78			return $return === 0;
79			}
80
81			/**
82			* Execute a git command and return first line of output
83			*
84			* @param string $command
85			* @return string
86			**/
87			private function exec($command)
88			{
89			$output = array();
90			$return = 0;
91
92			// Try to find last commit hash
93			@exec($command, $output, $return);
			0 ignored issues – show Security Best Practice introduced 2017-06-15 15:29 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
94
95			// Make sure it worked
96			if ($return !== 0) {
97			throw new RuntimeException(sprintf(
98			'Can not parse version from git using %s',
99			$command
100			));
101			}
102
103			// Return first line of output
104			return $output[0];
105			}
106			}
107

naneau / php-project-versioner

GitHub Access Token became invalid

Exec::exec() A last analyzed 2017-06-15 15:50 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Exec::exec() A
last analyzed 2017-06-15 15:50 UTC