StringBased::setContents() - Code Metrics - naneau/filegen - Measure and Improve Code Quality continuously with Scrutinizer

StringBased::setContents() A
last analyzed 2017-07-04 14:02 UTC

↳ Parent: StringBased

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	6
rs	9.4285
c	1
b	0
f	0
cc	1
eloc	3
nc	1
nop	1

<?php
namespace Naneau\FileGen\File\Contents;

use Naneau\FileGen\File\Contents;

/**
 * String based file contents
 */
class StringBased implements Contents
{
    /**
     * Contents of the file
     *
     * @var string
     **/
    private $contents;

    /**
     * Constructor
     *
     * @param string $contents
     * @return void

     **/
    public function __construct($contents)
    {
        $this->setContents($contents);
    }

    /**
     * Get the contents of the file
     *
     * @return string
     */
    public function getContents()
    {
        return $this->contents;
    }

    /**
     * Set the contents of the file
     *
     * @param  ContentGenerator|string $contents
     * @return self
     */
    public function setContents($contents)
    {
        $this->contents = $contents;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}

        return $this;
    }
}


1			<?php
2			namespace Naneau\FileGen\File\Contents;
3
4			use Naneau\FileGen\File\Contents;
5
6			/**
7			* String based file contents
8			*/
9			class StringBased implements Contents
10			{
11			/**
12			* Contents of the file
13			*
14			* @var string
15			**/
16			private $contents;
17
18			/**
19			* Constructor
20			*
21			* @param string $contents
22			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2017-02-09 14:23 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
23			**/
24			public function __construct($contents)
25			{
26			$this->setContents($contents);
27			}
28
29			/**
30			* Get the contents of the file
31			*
32			* @return string
33			*/
34			public function getContents()
35			{
36			return $this->contents;
37			}
38
39			/**
40			* Set the contents of the file
41			*
42			* @param ContentGenerator\|string $contents
43			* @return self
44			*/
45			public function setContents($contents)
46			{
47			$this->contents = $contents;
			0 ignored issues – show Documentation Bug introduced 2017-02-09 14:23 UTC by Report Bug Copy Issue Report It seems like `$contents` can also be of type `object<Naneau\FileGen\Fi...tents\ContentGenerator>`. However, the property `$contents` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
48
49			return $this;
50			}
51			}
52

naneau / filegen

GitHub Access Token became invalid

StringBased::setContents() A last analyzed 2017-07-04 14:02 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

StringBased::setContents() A
last analyzed 2017-07-04 14:02 UTC